-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV Matter Media: Updated existing cluster to resolve the issue #31320 #31865
TV Matter Media: Updated existing cluster to resolve the issue #31320 #31865
Conversation
fec5612
to
f9d3713
Compare
PR #31865: Size comparison from 2823126 to f9d3713 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
"reportableChange": 0 | ||
}, | ||
{ | ||
"name": "GeneratedCommandList", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see GeneratedCommandList, AcceptedCommandList, EventList, and AttributeList on some of the clusters in zap but not others. Should these be present on all?
For example, I don't see them on Channel or WakeOnLan or Target Navigator, but I do see them on Media Playback. Just wondering what the convention is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on @bzbarsky-apple answer - these commands are ignored by SDK code generator, that's why they are included.
Now this doesn't answer the question should they be there as the global attributes?
PR #31865: Size comparison from 8834be1 to d6a533a Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31865: Size comparison from e59f2ad to b179d70 Full report (19 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
b179d70
to
a9893aa
Compare
PR #31865: Size comparison from fd9ddb1 to 48f3575 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31865: Size comparison from 849f882 to 5a859d0 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Problem
This PR targets problems from the created issue #31320
Change overview
Tests
Build the TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/
Built the CHIP tool test client using command:
scripts/examples/gn_build_example.sh examples/chip-tool out/debug/ chip_config_network_layer_ble=false
Run tests using command:
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --runner chip_tool_python \ --chip-tool ./out/debug/chip-tool \ run \ --iterations 1 \ --test-timeout-seconds 120 \ --tv-app ./out/debug/chip-tv-app \ "