Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Pass advertising name directly to BluezAdvertisement #31824

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Feb 1, 2024

Problem

The name passed to the BluezEndpoint is not the owning name of the D-Bus - Matter SDK does not own any D-Bus name. In current form the code is misleading.

Changes

  • Pass advertising name directly to BluezAdvertisement
  • Remove non-existing strings from certification TC

Testing

CI will verify potential build breaks.

Copy link

github-actions bot commented Feb 1, 2024

PR #31824: Size comparison from cfd1551 to 797e4e9

Increases (1 build for linux)
platform target config section cfd1551 797e4e9 change % change
linux chip-tool-ipv6only arm64 (read/write) 588832 589040 208 0.0
Decreases (12 builds for efr32, linux)
platform target config section cfd1551 797e4e9 change % change
efr32 window-app BRD4187C (read/write) 1146544 1146536 -8 -0.0
.text 976084 976076 -8 -0.0
linux air-purifier-app debug (read only) 2576197 2575877 -320 -0.0
.rodata 181768 181736 -32 -0.0
.text 2217877 2217589 -288 -0.0
all-clusters-app debug (read only) 5784169 5783865 -304 -0.0
.rodata 343460 343428 -32 -0.0
.text 5014035 5013763 -272 -0.0
all-clusters-minimal-app debug (read only) 5134569 5134249 -320 -0.0
.rodata 286773 286741 -32 -0.0
.text 4613971 4613683 -288 -0.0
bridge-app debug (read only) 4550329 4550025 -304 -0.0
.rodata 227573 227541 -32 -0.0
.text 4102915 4102643 -272 -0.0
chip-tool debug (read only) 12162721 1216236 -352 -0.0
.rodata 442329 442265 -64 -0.0
.text 11010227 11009939 -288 -0.0
chip-tool-ipv6only arm64 (read only) 11684592 11684368 -224 -0.0
.rodata 349548 349532 -16 -0.0
.text 10442508 10442300 -208 -0.0
lighting-app debug+rpc+ui (read only) 5471417 5471065 -352 -0.0
.rodata 352340 352276 -64 -0.0
.text 4873139 4872851 -288 -0.0
lock-app debug (read only) 4625401 4625081 -320 -0.0
.rodata 254709 254677 -32 -0.0
.text 4159251 4158963 -288 -0.0
shell debug (read only) 2860745 2860409 -336 -0.0
.rodata 186016 185952 -64 -0.0
.text 2502130 2501858 -272 -0.0
tv-app debug (read only) 5575561 5575257 -304 -0.0
.rodata 283925 283893 -32 -0.0
.text 5051539 5051267 -272 -0.0
tv-casting-app debug (read only) 10023921 10023585 -336 -0.0
.rodata 378728 378664 -64 -0.0
.text 9171507 9171235 -272 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section cfd1551 797e4e9 change % change
bl602 lighting-app bl602 (read/write) 1429390 1429390 0 0.0
.bss 85320 85320 0 0.0
.data 9488 9488 0 0.0
.rodata 157344 157344 0 0.0
.text 1096592 1096592 0 0.0
bl602+mfd (read/write) 1444038 1444038 0 0.0
.bss 85480 85480 0 0.0
.data 9456 9456 0 0.0
.rodata 156304 156304 0 0.0
.text 1112150 1112150 0 0.0
bl602+rpc (read/write) 1477030 1477030 0 0.0
.bss 93352 93352 0 0.0
.data 9856 9856 0 0.0
.rodata 164920 164920 0 0.0
.text 1128234 1128234 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1194187 1194187 0 0.0
.bss 11121 11121 0 0.0
.data 3664 3664 0 0.0
.rodata 106732 106732 0 0.0
.text 965850 965850 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1205263 1205263 0 0.0
.bss 11297 11297 0 0.0
.data 3648 3648 0 0.0
.rodata 105672 105672 0 0.0
.text 977860 977860 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1285919 1285919 0 0.0
.bss 19589 19589 0 0.0
.data 4216 4216 0 0.0
.rodata 122104 122104 0 0.0
.text 1040794 1040794 0 0.0
bl706-eth (read/write) 1012593 1012593 0 0.0
.bss 23680 23680 0 0.0
.data 3240 3240 0 0.0
.rodata 100052 100052 0 0.0
.text 757668 757668 0 0.0
bl706-wifi (read/write) 1245810 1245810 0 0.0
.bss 10565 10565 0 0.0
.data 3672 3672 0 0.0
.rodata 121032 121032 0 0.0
.text 988152 988152 0 0.0
bl702l lighting-app bl702l (read/write) 1164288 1164288 0 0.0
.bss 16316 16316 0 0.0
.data 5032 5032 0 0.0
.rodata 100736 100736 0 0.0
.text 958956 958956 0 0.0
bl702l+mfd (read/write) 1175688 1175688 0 0.0
.bss 16492 16492 0 0.0
.data 5008 5008 0 0.0
.rodata 99676 99676 0 0.0
.text 971278 971278 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780484 780484 0 0.0
(read/write) 168856 168856 0 0.0
.bss 90876 90876 0 0.0
.data 3552 3552 0 0.0
.rodata 90316 90316 0 0.0
.text 689904 689904 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799212 799212 0 0.0
(read/write) 179116 179116 0 0.0
.bss 101076 101076 0 0.0
.data 3580 3580 0 0.0
.rodata 84724 84724 0 0.0
.text 714220 714220 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787716 787716 0 0.0
(read/write) 173572 173572 0 0.0
.bss 95532 95532 0 0.0
.data 3580 3580 0 0.0
.rodata 111436 111436 0 0.0
.text 676012 676012 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738348 738348 0 0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86036 86036 0 0.0
.text 652048 652048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 723972 723972 0 0.0
(read/write) 168040 168040 0 0.0
.bss 89840 89840 0 0.0
.data 3536 3536 0 0.0
.rodata 81884 81884 0 0.0
.text 641824 641824 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 572034 572034 0 0.0
(read/write) 207872 207872 0 0.0
.bss 201156 201156 0 0.0
.data 1592 1592 0 0.0
.rodata 84554 84554 0 0.0
.text 485360 485360 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627282 627282 0 0.0
(read/write) 208304 208304 0 0.0
.bss 201664 201664 0 0.0
.data 1520 1520 0 0.0
.rodata 106946 106946 0 0.0
.text 518212 518212 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 563971 563971 0 0.0
.app_xip_area 453845 453845 0 0.0
.bss 64968 64968 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 548819 548819 0 0.0
.app_xip_area 433933 433933 0 0.0
.bss 69688 69688 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565643 565643 0 0.0
.app_xip_area 457013 457013 0 0.0
.bss 63512 63512 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562379 562379 0 0.0
.app_xip_area 450477 450477 0 0.0
.bss 66672 66672 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 928128 928128 0 0.0
.bss 197904 197904 0 0.0
.data 1372 1372 0 0.0
.text 728832 728832 0 0.0
BRD4187C (read/write) 1107068 1107068 0 0.0
.bss 195156 195156 0 0.0
.data 3384 3384 0 0.0
.text 908508 908508 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121776 1121776 0 0.0
.bss 188208 188208 0 0.0
.data 2800 2800 0 0.0
.text 930748 930748 0 0.0
window-app BRD4187C (read/write) 1146544 1146536 -8 -0.0
.bss 167148 167148 0 0.0
.data 3292 3292 0 0.0
.text 976084 976076 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1197324 1197324 0 0.0
(read/write) 1744736 1744736 0 0.0
.dram0.bss 73392 73392 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 248224 248224 0 0.0
.flash.text 1197324 1197324 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1239455 1239455 0 0.0
(read/write) 529680 529680 0 0.0
.dram0.bss 80256 80256 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 278372 278372 0 0.0
.flash.text 1233291 1233291 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 610040 610040 0 0.0
(read/write) 81324 81324 0 0.0
.bss 69104 69104 0 0.0
.data 2236 2236 0 0.0
.text 609504 609504 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 695716 695716 0 0.0
.bss 67752 67752 0 0.0
.data 2788 2788 0 0.0
.text 581704 581704 0 0.0
light k32w0+release (read only) 598480 598480 0 0.0
(read/write) 79332 79332 0 0.0
.bss 67160 67160 0 0.0
.data 2188 2188 0 0.0
.text 597944 597944 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 786648 786648 0 0.0
.bss 77428 77428 0 0.0
.data 2000 2000 0 0.0
.text 663768 663768 0 0.0
lock k32w0+release (read only) 580832 580832 0 0.0
(read/write) 78772 78772 0 0.0
.bss 66624 66624 0 0.0
.data 2164 2164 0 0.0
.text 580296 580296 0 0.0
linux air-purifier-app debug (read only) 2576197 2575877 -320 -0.0
(read/write) 127832 127832 0 0.0
.bss 46272 46272 0 0.0
.data 2176 2176 0 0.0
.data.rel.ro 73464 73464 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 181768 181736 -32 -0.0
.text 2217877 2217589 -288 -0.0
all-clusters-app debug (read only) 5784169 5783865 -304 -0.0
(read/write) 472456 472456 0 0.0
.bss 132928 132928 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 327720 327720 0 0.0
.dynamic 624 624 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 343460 343428 -32 -0.0
.text 5014035 5013763 -272 -0.0
all-clusters-minimal-app debug (read only) 5134569 5134249 -320 -0.0
(read/write) 235656 235656 0 0.0
.bss 127456 127456 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 96792 96792 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 286773 286741 -32 -0.0
.text 4613971 4613683 -288 -0.0
bridge-app debug (read only) 4550329 4550025 -304 -0.0
(read/write) 216728 216728 0 0.0
.bss 117952 117952 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85904 85904 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 227573 227541 -32 -0.0
.text 4102915 4102643 -272 -0.0
chip-tool debug (read only) 12162721 1216236 -352 -0.0
(read/write) 520304 520304 0 0.0
.bss 94232 94232 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 413744 413744 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 442329 442265 -64 -0.0
.text 11010227 11009939 -288 -0.0
chip-tool-ipv6only arm64 (read only) 11684592 11684368 -224 -0.0
(read/write) 588832 589040 208 0.0
.bss 103304 103304 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 453408 453408 0 0.0
.dynamic 512 512 0 0.0
.got 20440 20440 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 349548 349532 -16 -0.0
.text 10442508 10442300 -208 -0.0
lighting-app debug+rpc+ui (read only) 5471417 5471065 -352 -0.0
(read/write) 225552 225552 0 0.0
.bss 118912 118912 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94320 94320 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 352340 352276 -64 -0.0
.text 4873139 4872851 -288 -0.0
lock-app debug (read only) 4625401 4625081 -320 -0.0
(read/write) 204440 204440 0 0.0
.bss 113376 113376 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80216 80216 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 254709 254677 -32 -0.0
.text 4159251 4158963 -288 -0.0
ota-provider-app debug (read only) 4258737 4258737 0 0.0
(read/write) 192912 192912 0 0.0
.bss 113216 113216 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 69520 69520 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206517 206517 0 0.0
.text 3860035 3860035 0 0.0
ota-requestor-app debug (read only) 4374137 4374137 0 0.0
(read/write) 197160 197160 0 0.0
.bss 114112 114112 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 72464 72464 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 212469 212469 0 0.0
.text 3965203 3965203 0 0.0
shell debug (read only) 2860745 2860409 -336 -0.0
(read/write) 154920 154920 0 0.0
.bss 62224 62224 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 85560 85560 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 186016 185952 -64 -0.0
.text 2502130 2501858 -272 -0.0
thermostat-no-ble arm64 (read only) 4445640 4445640 0 0.0
(read/write) 245840 245840 0 0.0
.bss 121720 121720 0 0.0
.data 3344 3344 0 0.0
.data.rel.ro 103464 103464 0 0.0
.dynamic 512 512 0 0.0
.got 12200 12200 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158652 158652 0 0.0
.text 3942652 3942652 0 0.0
tv-app debug (read only) 5575561 5575257 -304 -0.0
(read/write) 350456 350456 0 0.0
.bss 243232 243232 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 93432 93432 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 283925 283893 -32 -0.0
.text 5051539 5051267 -272 -0.0
tv-casting-app debug (read only) 10023921 10023585 -336 -0.0
(read/write) 343064 343064 0 0.0
.bss 156032 156032 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 177224 177224 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 378728 378664 -64 -0.0
.text 9171507 9171235 -272 -0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531240 2531240 0 0.0
.bss 220400 220400 0 0.0
.data 5208 5208 0 0.0
.text 1493924 1493924 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1094536 1094536 0 0.0
bss 129817 129817 0 0.0
rodata 111416 111416 0 0.0
text 805488 805488 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1214668 1214668 0 0.0
bss 121955 121955 0 0.0
rodata 141248 141248 0 0.0
text 800972 800972 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1044664 1044664 0 0.0
bss 129531 129531 0 0.0
rodata 99256 99256 0 0.0
text 768164 768164 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835368 835368 0 0.0
(read/write) 1789036 1789036 0 0.0
.bss 195332 195332 0 0.0
.data 2640 2640 0 0.0
.text 1582676 1582676 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837656 837656 0 0.0
(read/write) 1713524 1713524 0 0.0
.bss 193068 193068 0 0.0
.data 2616 2616 0 0.0
.text 1509452 1509452 0 0.0
light cy8ckit_062s2_43012 (read only) 844360 844360 0 0.0
(read/write) 1633932 1633932 0 0.0
.bss 186548 186548 0 0.0
.data 2432 2432 0 0.0
.text 1436564 1436564 0 0.0
lock cy8ckit_062s2_43012 (read only) 817224 817224 0 0.0
(read/write) 1665580 1665580 0 0.0
.bss 213660 213660 0 0.0
.data 2456 2456 0 0.0
.text 1441076 1441076 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124052 1124052 0 0.0
.bss 102376 102376 0 0.0
.data 808 808 0 0.0
.text 636432 636432 0 0.0
lock-app qpg6105+debug (read/write) 1088524 1088524 0 0.0
.bss 98592 98592 0 0.0
.data 852 852 0 0.0
.text 600900 600900 0 0.0
stm32 light STM32WB5MM-DK (read/write) 596485 596485 0 0.0
.bss 128280 128280 0 0.0
.data 660 660 0 0.0
.rodata 78756 78756 0 0.0
.text 379064 379064 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824910 824910 0 0.0
bss 51028 51028 0 0.0
text 616792 616792 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1112324 1112324 0 0.0
bss 100768 100768 0 0.0
text 787000 787000 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1090936 1090936 0 0.0
bss 109928 109928 0 0.0
text 759226 759226 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935152 935152 0 0.0
bss 92976 92976 0 0.0
text 648958 648958 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 826506 826506 0 0.0
bss 51080 51080 0 0.0
text 618454 618454 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 984436 984436 0 0.0
bss 79120 79120 0 0.0
text 699160 699160 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1096412 1096412 0 0.0
bss 100056 100056 0 0.0
text 772446 772446 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 971524 971524 0 0.0
bss 97440 97440 0 0.0
text 653382 653382 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952752 952752 0 0.0
bss 92552 92552 0 0.0
text 666668 666668 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884096 884096 0 0.0
bss 69144 69144 0 0.0
text 625328 625328 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 824716 824716 0 0.0
bss 57388 57388 0 0.0
text 592220 592220 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705780 705780 0 0.0
bss 73640 73640 0 0.0
text 462172 462172 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 828186 828186 0 0.0
bss 51208 51208 0 0.0
text 621154 621154 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883473 883473 0 0.0
bss 60864 60864 0 0.0
text 635464 635464 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850736 850736 0 0.0
bss 57676 57676 0 0.0
text 612220 612220 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 843492 843492 0 0.0
bss 57988 57988 0 0.0
text 604856 604856 0 0.0

@mergify mergify bot merged commit e75f229 into project-chip:master Feb 1, 2024
57 checks passed
@arkq arkq deleted the linux-bluez-cleanup branch February 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants