Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell] Fixes for Matter cli #31768

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[shell] Fixes for Matter cli #31768

merged 2 commits into from
Jan 31, 2024

Conversation

andrei-menzopol
Copy link
Contributor

@andrei-menzopol andrei-menzopol commented Jan 30, 2024 •
edited
Loading

  • Add backspace character handling in ReadLine
  • The otcli command buffer (128) was to small for some ot commands like otcli dataset set active . The 128 value was taken from an OT config a long time ago and since was increased to 384.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

PR #31768: Size comparison from f5ca5ad to 0d4bdcc

Increases (4 builds for linux, telink)
platform target config section f5ca5ad 0d4bdcc change % change
linux shell debug (read only) 2868177 2868193 16 0.0
.text 2509970 2509986 16 0.0
tv-app debug (read only) 5581025 5581041 16 0.0
.text 5057059 5057075 16 0.0
tv-casting-app debug (read only) 10025825 10025857 32 0.0
.text 9173891 9173923 32 0.0
telink shell tlsr9518adk80d (read/write) 705772 705804 32 0.0
text 462164 462196 32 0.0
Decreases (1 build for efr32)
platform target config section f5ca5ad 0d4bdcc change % change
efr32 window-app BRD4187C (read/write) 1147864 1147856 -8 -0.0
.text 977404 977396 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section f5ca5ad 0d4bdcc change % change
bl602 lighting-app bl602 (read/write) 1428286 1428286 0 0.0
.bss 85320 85320 0 0.0
.data 9488 9488 0 0.0
.rodata 157288 157288 0 0.0
.text 1095542 1095542 0 0.0
bl602+mfd (read/write) 1442678 1442678 0 0.0
.bss 85480 85480 0 0.0
.data 9456 9456 0 0.0
.rodata 156248 156248 0 0.0
.text 1110844 1110844 0 0.0
bl602+rpc (read/write) 1475662 1475662 0 0.0
.bss 93352 93352 0 0.0
.data 9856 9856 0 0.0
.rodata 164864 164864 0 0.0
.text 1126928 1126928 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1192955 1192955 0 0.0
.bss 11121 11121 0 0.0
.data 3664 3664 0 0.0
.rodata 106676 106676 0 0.0
.text 964674 964674 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1204031 1204031 0 0.0
.bss 11297 11297 0 0.0
.data 3648 3648 0 0.0
.rodata 105616 105616 0 0.0
.text 976684 976684 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1284703 1284703 0 0.0
.bss 19589 19589 0 0.0
.data 4216 4216 0 0.0
.rodata 122048 122048 0 0.0
.text 1039634 1039634 0 0.0
bl706-eth (read/write) 1011489 1011489 0 0.0
.bss 23680 23680 0 0.0
.data 3240 3240 0 0.0
.rodata 99996 99996 0 0.0
.text 756618 756618 0 0.0
bl706-wifi (read/write) 1244370 1244370 0 0.0
.bss 10565 10565 0 0.0
.data 3672 3672 0 0.0
.rodata 120976 120976 0 0.0
.text 986766 986766 0 0.0
bl702l lighting-app bl702l (read/write) 1163056 1163056 0 0.0
.bss 16316 16316 0 0.0
.data 5032 5032 0 0.0
.rodata 100680 100680 0 0.0
.text 957780 957780 0 0.0
bl702l+mfd (read/write) 1174456 1174456 0 0.0
.bss 16492 16492 0 0.0
.data 5008 5008 0 0.0
.rodata 99620 99620 0 0.0
.text 970102 970102 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 781428 781428 0 0.0
(read/write) 168856 168856 0 0.0
.bss 90876 90876 0 0.0
.data 3552 3552 0 0.0
.rodata 90292 90292 0 0.0
.text 690872 690872 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798916 798916 0 0.0
(read/write) 179100 179100 0 0.0
.bss 101060 101060 0 0.0
.data 3580 3580 0 0.0
.rodata 84636 84636 0 0.0
.text 714012 714012 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787388 787388 0 0.0
(read/write) 173556 173556 0 0.0
.bss 95516 95516 0 0.0
.data 3580 3580 0 0.0
.rodata 111356 111356 0 0.0
.text 675764 675764 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738732 738732 0 0.0
(read/write) 167828 167828 0 0.0
.bss 89616 89616 0 0.0
.data 3540 3540 0 0.0
.rodata 86012 86012 0 0.0
.text 652456 652456 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724348 724348 0 0.0
(read/write) 168040 168040 0 0.0
.bss 89840 89840 0 0.0
.data 3536 3536 0 0.0
.rodata 81852 81852 0 0.0
.text 642232 642232 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 572818 572818 0 0.0
(read/write) 207872 207872 0 0.0
.bss 201156 201156 0 0.0
.data 1592 1592 0 0.0
.rodata 84498 84498 0 0.0
.text 486200 486200 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627098 627098 0 0.0
(read/write) 208288 208288 0 0.0
.bss 201648 201648 0 0.0
.data 1520 1520 0 0.0
.rodata 106370 106370 0 0.0
.text 518604 518604 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564931 564931 0 0.0
.app_xip_area 454805 454805 0 0.0
.bss 64968 64968 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 548555 548555 0 0.0
.app_xip_area 433685 433685 0 0.0
.bss 69672 69672 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566259 566259 0 0.0
.app_xip_area 457629 457629 0 0.0
.bss 63512 63512 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 563011 563011 0 0.0
.app_xip_area 451109 451109 0 0.0
.bss 66672 66672 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 930248 930248 0 0.0
.bss 197904 197904 0 0.0
.data 1372 1372 0 0.0
.text 730952 730952 0 0.0
BRD4187C (read/write) 1108092 1108092 0 0.0
.bss 195156 195156 0 0.0
.data 3384 3384 0 0.0
.text 909532 909532 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121616 1121616 0 0.0
.bss 188184 188184 0 0.0
.data 2800 2800 0 0.0
.text 930612 930612 0 0.0
window-app BRD4187C (read/write) 1147864 1147856 -8 -0.0
.bss 167148 167148 0 0.0
.data 3292 3292 0 0.0
.text 977404 977396 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1199728 1199728 0 0.0
(read/write) 1744704 1744704 0 0.0
.dram0.bss 73392 73392 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 248192 248192 0 0.0
.flash.text 1199728 1199728 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1241103 1241103 0 0.0
(read/write) 529656 529656 0 0.0
.dram0.bss 80256 80256 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 278348 278348 0 0.0
.flash.text 1234939 1234939 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 610640 610640 0 0.0
(read/write) 81316 81316 0 0.0
.bss 69096 69096 0 0.0
.data 2236 2236 0 0.0
.text 610104 610104 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 696308 696308 0 0.0
.bss 67752 67752 0 0.0
.data 2788 2788 0 0.0
.text 582296 582296 0 0.0
light k32w0+release (read only) 599088 599088 0 0.0
(read/write) 79332 79332 0 0.0
.bss 67160 67160 0 0.0
.data 2188 2188 0 0.0
.text 598552 598552 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787328 787328 0 0.0
.bss 77428 77428 0 0.0
.data 2000 2000 0 0.0
.text 664448 664448 0 0.0
lock k32w0+release (read only) 580280 580280 0 0.0
(read/write) 78740 78740 0 0.0
.bss 66592 66592 0 0.0
.data 2164 2164 0 0.0
.text 579744 579744 0 0.0
linux air-purifier-app debug (read only) 2578549 2578549 0 0.0
(read/write) 127736 127736 0 0.0
.bss 46272 46272 0 0.0
.data 2176 2176 0 0.0
.data.rel.ro 73352 73352 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 181800 181800 0 0.0
.text 2220389 2220389 0 0.0
all-clusters-app debug (read only) 5792929 5792929 0 0.0
(read/write) 472160 472160 0 0.0
.bss 132928 132928 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 327416 327416 0 0.0
.dynamic 624 624 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 1336 1336 0 0.0
.rodata 343236 343236 0 0.0
.text 5023379 5023379 0 0.0
all-clusters-minimal-app debug (read only) 5136065 5136065 0 0.0
(read/write) 235392 235392 0 0.0
.bss 127360 127360 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 96616 96616 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 285749 285749 0 0.0
.text 4616851 4616851 0 0.0
bridge-app debug (read only) 4552641 4552641 0 0.0
(read/write) 216592 216592 0 0.0
.bss 117952 117952 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85792 85792 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 227349 227349 0 0.0
.text 4105667 4105667 0 0.0
chip-tool debug (read only) 12159153 12159153 0 0.0
(read/write) 519952 519952 0 0.0
.bss 94232 94232 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 413376 413376 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 442073 442073 0 0.0
.text 11007347 11007347 0 0.0
chip-tool-ipv6only arm64 (read only) 11685504 11685504 0 0.0
(read/write) 587936 587936 0 0.0
.bss 103288 103288 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 453056 453056 0 0.0
.dynamic 512 512 0 0.0
.got 20424 20424 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 349276 349276 0 0.0
.text 10444220 10444220 0 0.0
lighting-app debug+rpc+ui (read only) 5476497 5476497 0 0.0
(read/write) 225384 225384 0 0.0
.bss 118880 118880 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94208 94208 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 352148 352148 0 0.0
.text 4878627 4878627 0 0.0
lock-app debug (read only) 4623409 4623409 0 0.0
(read/write) 204176 204176 0 0.0
.bss 113312 113312 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80040 80040 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 254133 254133 0 0.0
.text 4158195 4158195 0 0.0
ota-provider-app debug (read only) 4261345 4261345 0 0.0
(read/write) 192784 192784 0 0.0
.bss 113216 113216 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 69408 69408 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206549 206549 0 0.0
.text 3862803 3862803 0 0.0
ota-requestor-app debug (read only) 4377289 4377289 0 0.0
(read/write) 197032 197032 0 0.0
.bss 114112 114112 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 72352 72352 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 212501 212501 0 0.0
.text 3968515 3968515 0 0.0
shell debug (read only) 2868177 2868193 16 0.0
(read/write) 154816 154816 0 0.0
.bss 62224 62224 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 85448 85448 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185824 185824 0 0.0
.text 2509970 2509986 16 0.0
thermostat-no-ble arm64 (read only) 4450184 4450184 0 0.0
(read/write) 245344 245344 0 0.0
.bss 121704 121704 0 0.0
.data 3344 3344 0 0.0
.data.rel.ro 103376 103376 0 0.0
.dynamic 512 512 0 0.0
.got 12192 12192 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158540 158540 0 0.0
.text 3947548 3947548 0 0.0
tv-app debug (read only) 5581025 5581041 16 0.0
(read/write) 350288 350288 0 0.0
.bss 243200 243200 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 93304 93304 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 284085 284085 0 0.0
.text 5057059 5057075 16 0.0
tv-casting-app debug (read only) 10025825 10025857 32 0.0
(read/write) 342872 342872 0 0.0
.bss 156000 156000 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 177064 177064 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 378536 378536 0 0.0
.text 9173891 9173923 32 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531024 2531024 0 0.0
.bss 220384 220384 0 0.0
.data 5208 5208 0 0.0
.text 1493708 1493708 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1096120 1096120 0 0.0
bss 129817 129817 0 0.0
rodata 111384 111384 0 0.0
text 807108 807108 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1216444 1216444 0 0.0
bss 121955 121955 0 0.0
rodata 141216 141216 0 0.0
text 802776 802776 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1045192 1045192 0 0.0
bss 129511 129511 0 0.0
rodata 99176 99176 0 0.0
text 768764 768764 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835368 835368 0 0.0
(read/write) 1792724 1792724 0 0.0
.bss 195332 195332 0 0.0
.data 2640 2640 0 0.0
.text 1586364 1586364 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837672 837672 0 0.0
(read/write) 1715284 1715284 0 0.0
.bss 193052 193052 0 0.0
.data 2616 2616 0 0.0
.text 1511228 1511228 0 0.0
light cy8ckit_062s2_43012 (read only) 844360 844360 0 0.0
(read/write) 1636276 1636276 0 0.0
.bss 186548 186548 0 0.0
.data 2432 2432 0 0.0
.text 1438908 1438908 0 0.0
lock cy8ckit_062s2_43012 (read only) 817240 817240 0 0.0
(read/write) 1665612 1665612 0 0.0
.bss 213644 213644 0 0.0
.data 2456 2456 0 0.0
.text 1441124 1441124 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124700 1124700 0 0.0
.bss 102376 102376 0 0.0
.data 808 808 0 0.0
.text 637080 637080 0 0.0
lock-app qpg6105+debug (read/write) 1088180 1088180 0 0.0
.bss 98560 98560 0 0.0
.data 852 852 0 0.0
.text 600556 600556 0 0.0
stm32 light STM32WB5MM-DK (read/write) 597437 597437 0 0.0
.bss 128280 128280 0 0.0
.data 660 660 0 0.0
.rodata 78724 78724 0 0.0
.text 380048 380048 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825470 825470 0 0.0
bss 51012 51012 0 0.0
text 617468 617468 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1114452 1114452 0 0.0
bss 100768 100768 0 0.0
text 789154 789154 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1091764 1091764 0 0.0
bss 109904 109904 0 0.0
text 760210 760210 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935768 935768 0 0.0
bss 92976 92976 0 0.0
text 649606 649606 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 827370 827370 0 0.0
bss 51064 51064 0 0.0
text 619426 619426 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 985316 985316 0 0.0
bss 79104 79104 0 0.0
text 700146 700146 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1097724 1097724 0 0.0
bss 100056 100056 0 0.0
text 773794 773794 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 971248 971248 0 0.0
bss 97408 97408 0 0.0
text 653336 653336 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953568 953568 0 0.0
bss 92552 92552 0 0.0
text 667510 667510 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884632 884632 0 0.0
bss 69128 69128 0 0.0
text 625970 625970 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825276 825276 0 0.0
bss 57372 57372 0 0.0
text 592894 592894 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705772 705804 32 0.0
bss 73640 73640 0 0.0
text 462164 462196 32 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 829114 829114 0 0.0
bss 51192 51192 0 0.0
text 622196 622196 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883913 883913 0 0.0
bss 60848 60848 0 0.0
text 636016 636016 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 851592 851592 0 0.0
bss 57660 57660 0 0.0
text 613190 613190 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844332 844332 0 0.0
bss 57972 57972 0 0.0
text 605808 605808 0 0.0

andy31415
andy31415 requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just increase the value and apply you ain't gonna need it for the define - I don't think this define is worth to have as a configurable compile-time define. Seems overly complex.

set static constexpr kMaxLineLength in the file and be done with it. Using a define with a kCamelCase name was wrong to begin with.

marius-preda and others added 2 commits January 31, 2024 10:10
@marius-preda @andrei-menzopol
[shell] Fixed parsing of long otcli commands
de86e2e 
The otcli command buffer (128) was to small for some ot commands like otcli dataset set active <hex dataset>.
The 128 value was taken from an OT config a long time ago and since was increased to 384.
A new static constexpr was created with the value of 384 to be used instead of the define.

Signed-off-by: Marius Preda <[email protected]>
@andrei-menzopol
[shell] Add backspace character in ReadLine
74133aa 
Signed-off-by: Andrei Menzopol <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

PR #31768: Size comparison from 219c3f0 to 74133aa

Increases (4 builds for linux, telink)
platform target config section 219c3f0 74133aa change % change
linux shell debug (read only) 2860729 2860761 32 0.0
.text 2502114 2502146 32 0.0
tv-app debug (read only) 5575545 5575561 16 0.0
.text 5051523 5051539 16 0.0
tv-casting-app debug (read only) 10022961 10022993 32 0.0
.text 9170707 9170739 32 0.0
telink shell tlsr9518adk80d (read/write) 705748 705780 32 0.0
text 462140 462172 32 0.0
Decreases (1 build for efr32)
platform target config section 219c3f0 74133aa change % change
efr32 window-app BRD4187C (read/write) 1146544 1146536 -8 -0.0
.text 976084 976076 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 219c3f0 74133aa change % change
bl602 lighting-app bl602 (read/write) 1429398 1429398 0 0.0
.bss 85320 85320 0 0.0
.data 9488 9488 0 0.0
.rodata 157344 157344 0 0.0
.text 1096600 1096600 0 0.0
bl602+mfd (read/write) 1444046 1444046 0 0.0
.bss 85480 85480 0 0.0
.data 9456 9456 0 0.0
.rodata 156304 156304 0 0.0
.text 1112158 1112158 0 0.0
bl602+rpc (read/write) 1477038 1477038 0 0.0
.bss 93352 93352 0 0.0
.data 9856 9856 0 0.0
.rodata 164920 164920 0 0.0
.text 1128242 1128242 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1194195 1194195 0 0.0
.bss 11121 11121 0 0.0
.data 3664 3664 0 0.0
.rodata 106732 106732 0 0.0
.text 965858 965858 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1205271 1205271 0 0.0
.bss 11297 11297 0 0.0
.data 3648 3648 0 0.0
.rodata 105672 105672 0 0.0
.text 977868 977868 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1285927 1285927 0 0.0
.bss 19589 19589 0 0.0
.data 4216 4216 0 0.0
.rodata 122104 122104 0 0.0
.text 1040802 1040802 0 0.0
bl706-eth (read/write) 1012601 1012601 0 0.0
.bss 23680 23680 0 0.0
.data 3240 3240 0 0.0
.rodata 100052 100052 0 0.0
.text 757676 757676 0 0.0
bl706-wifi (read/write) 1245818 1245818 0 0.0
.bss 10565 10565 0 0.0
.data 3672 3672 0 0.0
.rodata 121032 121032 0 0.0
.text 988160 988160 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1163784 1163784 0 0.0
.bss 16316 16316 0 0.0
.data 5032 5032 0 0.0
.rodata 100736 100736 0 0.0
.text 958964 958964 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1175184 1175184 0 0.0
.bss 16492 16492 0 0.0
.data 5008 5008 0 0.0
.rodata 99676 99676 0 0.0
.text 971286 971286 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780484 780484 0 0.0
(read/write) 168856 168856 0 0.0
.bss 90876 90876 0 0.0
.data 3552 3552 0 0.0
.rodata 90316 90316 0 0.0
.text 689904 689904 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799212 799212 0 0.0
(read/write) 179116 179116 0 0.0
.bss 101076 101076 0 0.0
.data 3580 3580 0 0.0
.rodata 84724 84724 0 0.0
.text 714220 714220 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787716 787716 0 0.0
(read/write) 173572 173572 0 0.0
.bss 95532 95532 0 0.0
.data 3580 3580 0 0.0
.rodata 111436 111436 0 0.0
.text 676012 676012 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738348 738348 0 0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86036 86036 0 0.0
.text 652048 652048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 723980 723980 0 0.0
(read/write) 168040 168040 0 0.0
.bss 89840 89840 0 0.0
.data 3536 3536 0 0.0
.rodata 81884 81884 0 0.0
.text 641832 641832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 572034 572034 0 0.0
(read/write) 207872 207872 0 0.0
.bss 201156 201156 0 0.0
.data 1592 1592 0 0.0
.rodata 84554 84554 0 0.0
.text 485360 485360 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627282 627282 0 0.0
(read/write) 208304 208304 0 0.0
.bss 201664 201664 0 0.0
.data 1520 1520 0 0.0
.rodata 106946 106946 0 0.0
.text 518212 518212 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 563979 563979 0 0.0
.app_xip_area 453853 453853 0 0.0
.bss 64968 64968 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 548827 548827 0 0.0
.app_xip_area 433941 433941 0 0.0
.bss 69688 69688 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565651 565651 0 0.0
.app_xip_area 457021 457021 0 0.0
.bss 63512 63512 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562387 562387 0 0.0
.app_xip_area 450485 450485 0 0.0
.bss 66672 66672 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 928128 928128 0 0.0
.bss 197904 197904 0 0.0
.data 1372 1372 0 0.0
.text 728832 728832 0 0.0
BRD4187C (read/write) 1107068 1107068 0 0.0
.bss 195156 195156 0 0.0
.data 3384 3384 0 0.0
.text 908508 908508 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121744 1121744 0 0.0
.bss 188208 188208 0 0.0
.data 2800 2800 0 0.0
.text 930716 930716 0 0.0
window-app BRD4187C (read/write) 1146544 1146536 -8 -0.0
.bss 167148 167148 0 0.0
.data 3292 3292 0 0.0
.text 976084 976076 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1197312 1197312 0 0.0
(read/write) 1744736 1744736 0 0.0
.dram0.bss 73392 73392 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 248224 248224 0 0.0
.flash.text 1197312 1197312 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1239423 1239423 0 0.0
(read/write) 529688 529688 0 0.0
.dram0.bss 80256 80256 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 278380 278380 0 0.0
.flash.text 1233259 1233259 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 610040 610040 0 0.0
(read/write) 81324 81324 0 0.0
.bss 69104 69104 0 0.0
.data 2236 2236 0 0.0
.text 609504 609504 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 695724 695724 0 0.0
.bss 67752 67752 0 0.0
.data 2788 2788 0 0.0
.text 581712 581712 0 0.0
light k32w0+release (read only) 598496 598496 0 0.0
(read/write) 79332 79332 0 0.0
.bss 67160 67160 0 0.0
.data 2188 2188 0 0.0
.text 597960 597960 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 786656 786656 0 0.0
.bss 77428 77428 0 0.0
.data 2000 2000 0 0.0
.text 663776 663776 0 0.0
lock k32w0+release (read only) 580816 580816 0 0.0
(read/write) 78772 78772 0 0.0
.bss 66624 66624 0 0.0
.data 2164 2164 0 0.0
.text 580280 580280 0 0.0
linux air-purifier-app debug (read only) 2576197 2576197 0 0.0
(read/write) 127832 127832 0 0.0
.bss 46272 46272 0 0.0
.data 2176 2176 0 0.0
.data.rel.ro 73464 73464 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 181768 181768 0 0.0
.text 2217877 2217877 0 0.0
all-clusters-app debug (read only) 5783929 5783929 0 0.0
(read/write) 472264 472264 0 0.0
.bss 132928 132928 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 327528 327528 0 0.0
.dynamic 624 624 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 343460 343460 0 0.0
.text 5013939 5013939 0 0.0
all-clusters-minimal-app debug (read only) 5134569 5134569 0 0.0
(read/write) 235656 235656 0 0.0
.bss 127456 127456 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 96792 96792 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 286773 286773 0 0.0
.text 4613971 4613971 0 0.0
bridge-app debug (read only) 4550329 4550329 0 0.0
(read/write) 216728 216728 0 0.0
.bss 117952 117952 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85904 85904 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 227573 227573 0 0.0
.text 4102915 4102915 0 0.0
chip-tool debug (read only) 12161681 12161681 0 0.0
(read/write) 520048 520048 0 0.0
.bss 94232 94232 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 413488 413488 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 442297 442297 0 0.0
.text 11009459 11009459 0 0.0
chip-tool-ipv6only arm64 (read only) 11683728 11683728 0 0.0
(read/write) 589688 589688 0 0.0
.bss 103304 103304 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 453168 453168 0 0.0
.dynamic 512 512 0 0.0
.got 20432 20432 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 349548 349548 0 0.0
.text 10441916 10441916 0 0.0
lighting-app debug+rpc+ui (read only) 5471417 5471417 0 0.0
(read/write) 225552 225552 0 0.0
.bss 118912 118912 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94320 94320 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 352340 352340 0 0.0
.text 4873139 4873139 0 0.0
lock-app debug (read only) 4625401 4625401 0 0.0
(read/write) 204440 204440 0 0.0
.bss 113376 113376 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80216 80216 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 254709 254709 0 0.0
.text 4159251 4159251 0 0.0
ota-provider-app debug (read only) 4258737 4258737 0 0.0
(read/write) 192912 192912 0 0.0
.bss 113216 113216 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 69520 69520 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206517 206517 0 0.0
.text 3860035 3860035 0 0.0
ota-requestor-app debug (read only) 4374137 4374137 0 0.0
(read/write) 197160 197160 0 0.0
.bss 114112 114112 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 72464 72464 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 212469 212469 0 0.0
.text 3965203 3965203 0 0.0
shell debug (read only) 2860729 2860761 32 0.0
(read/write) 154920 154920 0 0.0
.bss 62224 62224 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 85560 85560 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 186016 186016 0 0.0
.text 2502114 2502146 32 0.0
thermostat-no-ble arm64 (read only) 4445656 4445656 0 0.0
(read/write) 245824 245824 0 0.0
.bss 121720 121720 0 0.0
.data 3344 3344 0 0.0
.data.rel.ro 103464 103464 0 0.0
.dynamic 512 512 0 0.0
.got 12200 12200 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158652 158652 0 0.0
.text 3942668 3942668 0 0.0
tv-app debug (read only) 5575545 5575561 16 0.0
(read/write) 350456 350456 0 0.0
.bss 243232 243232 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 93432 93432 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 283925 283925 0 0.0
.text 5051523 5051539 16 0.0
tv-casting-app debug (read only) 10022961 10022993 32 0.0
(read/write) 343032 343032 0 0.0
.bss 156032 156032 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 177192 177192 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 378664 378664 0 0.0
.text 9170707 9170739 32 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531240 2531240 0 0.0
.bss 220400 220400 0 0.0
.data 5208 5208 0 0.0
.text 1493924 1493924 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1094552 1094552 0 0.0
bss 129817 129817 0 0.0
rodata 111416 111416 0 0.0
text 805496 805496 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1214684 1214684 0 0.0
bss 121955 121955 0 0.0
rodata 141248 141248 0 0.0
text 800980 800980 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1044680 1044680 0 0.0
bss 129531 129531 0 0.0
rodata 99256 99256 0 0.0
text 768172 768172 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835368 835368 0 0.0
(read/write) 1789036 1789036 0 0.0
.bss 195332 195332 0 0.0
.data 2640 2640 0 0.0
.text 1582676 1582676 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837656 837656 0 0.0
(read/write) 1713524 1713524 0 0.0
.bss 193068 193068 0 0.0
.data 2616 2616 0 0.0
.text 1509452 1509452 0 0.0
light cy8ckit_062s2_43012 (read only) 844360 844360 0 0.0
(read/write) 1633948 1633948 0 0.0
.bss 186548 186548 0 0.0
.data 2432 2432 0 0.0
.text 1436580 1436580 0 0.0
lock cy8ckit_062s2_43012 (read only) 817224 817224 0 0.0
(read/write) 1665580 1665580 0 0.0
.bss 213660 213660 0 0.0
.data 2456 2456 0 0.0
.text 1441076 1441076 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124060 1124060 0 0.0
.bss 102376 102376 0 0.0
.data 808 808 0 0.0
.text 636440 636440 0 0.0
lock-app qpg6105+debug (read/write) 1088516 1088516 0 0.0
.bss 98592 98592 0 0.0
.data 852 852 0 0.0
.text 600892 600892 0 0.0
stm32 light STM32WB5MM-DK (read/write) 596493 596493 0 0.0
.bss 128280 128280 0 0.0
.data 660 660 0 0.0
.rodata 78756 78756 0 0.0
.text 379072 379072 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824910 824910 0 0.0
bss 51028 51028 0 0.0
text 616792 616792 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1112332 1112332 0 0.0
bss 100768 100768 0 0.0
text 787008 787008 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1090944 1090944 0 0.0
bss 109928 109928 0 0.0
text 759234 759234 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935160 935160 0 0.0
bss 92976 92976 0 0.0
text 648966 648966 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 826506 826506 0 0.0
bss 51080 51080 0 0.0
text 618454 618454 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 984436 984436 0 0.0
bss 79120 79120 0 0.0
text 699160 699160 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1096420 1096420 0 0.0
bss 100056 100056 0 0.0
text 772454 772454 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 971524 971524 0 0.0
bss 97440 97440 0 0.0
text 653382 653382 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952760 952760 0 0.0
bss 92552 92552 0 0.0
text 666676 666676 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884096 884096 0 0.0
bss 69144 69144 0 0.0
text 625328 625328 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 824716 824716 0 0.0
bss 57388 57388 0 0.0
text 592220 592220 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705748 705780 32 0.0
bss 73640 73640 0 0.0
text 462140 462172 32 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 828186 828186 0 0.0
bss 51208 51208 0 0.0
text 621154 621154 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883473 883473 0 0.0
bss 60864 60864 0 0.0
text 635464 635464 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850736 850736 0 0.0
bss 57676 57676 0 0.0
text 612220 612220 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 843492 843492 0 0.0
bss 57988 57988 0 0.0
text 604856 604856 0 0.0

@andrei-menzopol
Copy link
Contributor Author

Please just increase the value and apply you ain't gonna need it for the define - I don't think this define is worth to have as a configurable compile-time define. Seems overly complex.

set static constexpr kMaxLineLength in the file and be done with it. Using a define with a kCamelCase name was wrong to begin with.

Done, thank you

@mergify mergify bot merged commit c4b5df9 into project-chip:master Jan 31, 2024
57 checks passed
@andrei-menzopol andrei-menzopol deleted the fix-matter-cli branch February 1, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples lib review - approved shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrei-menzopol @andy31415 @arkq @marius-preda