-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Thread]Move the encoding of the thread diagnostics attributes to the app layer #31766
Merged
mergify
merged 7 commits into
project-chip:master
from
jmartinez-silabs:move_WriteThreadNetworkDiagnosticAttributeToTlv
Jan 30, 2024
Merged
[Thread]Move the encoding of the thread diagnostics attributes to the app layer #31766
mergify
merged 7 commits into
project-chip:master
from
jmartinez-silabs:move_WriteThreadNetworkDiagnosticAttributeToTlv
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
January 30, 2024 15:31
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 30, 2024 15:31
jmartinez-silabs
force-pushed
the
move_WriteThreadNetworkDiagnosticAttributeToTlv
branch
from
January 30, 2024 15:54
d01f76d
to
d9938ba
Compare
PR #31766: Size comparison from 48e7bae to d9938ba Increases above 0.2%:
Increases (10 builds for cc13x4_26x4, linux, nrfconnect)
Decreases (57 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31766: Size comparison from 48e7bae to 133e259 Increases above 0.2%:
Increases (21 builds for cc13x4_26x4, cyw30739, k32w, linux, nrfconnect, stm32)
Decreases (53 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
lpbeliveau-silabs
approved these changes
Jan 30, 2024
andy31415
reviewed
Jan 30, 2024
andy31415
approved these changes
Jan 30, 2024
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Show resolved
Hide resolved
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Show resolved
Hide resolved
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Show resolved
Hide resolved
src/app/clusters/thread-network-diagnostics-server/thread-network-diagnostics-provider.cpp
Show resolved
Hide resolved
Co-authored-by: mkardous-silabs <[email protected]>
PR #31766: Size comparison from 48e7bae to 087c5d6 Decreases (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #31766: Size comparison from 48e7bae to e2118c3 Increases above 0.2%:
Increases (15 builds for bl602, bl702, bl702l, cc13x4_26x4, linux)
Decreases (63 builds for bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
mkardous-silabs
approved these changes
Jan 30, 2024
rcasallas-silabs
approved these changes
Jan 30, 2024
jmartinez-silabs
deleted the
move_WriteThreadNetworkDiagnosticAttributeToTlv
branch
June 26, 2024 20:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
WriteThreadNetworkDiagnosticAttributeToTlv
functions to a single location for all thread devices.It also, more importantly, removes it from the device layer/platform.
It is compiled with the cluster server implementation when that cluster is enabled.
This is the first step to remove the app layer dependency in
src/platform/Openthread
.The next phase will be targeted to the network commissioning cluster dependency.