-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BooleanState cluster control to pigweed RPCs #31745
Merged
mergify
merged 5 commits into
project-chip:master
from
tcarmelveilleux:add-chef-event-rpc
Jan 29, 2024
Merged
Add BooleanState cluster control to pigweed RPCs #31745
mergify
merged 5 commits into
project-chip:master
from
tcarmelveilleux:add-chef-event-rpc
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new RPCs to set/read BooleanState cluster - Update nRF, ESP32 and Linux chef examples to include - Update some docs that were stale - Allow StatusUtils for RPC to deal with CHIP_ERROR Issue project-chip#25225 Fixes project-chip#31725
PR #31745: Size comparison from f63b505 to 393662c Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
January 29, 2024 14:50
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 29, 2024 14:50
PR #31745: Size comparison from f63b505 to a0b2c18 Decreases (1 build for efr32)
Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, stm32)
|
andy31415
reviewed
Jan 29, 2024
andy31415
approved these changes
Jan 29, 2024
PR #31745: Size comparison from f63b505 to 19f090f Increases above 0.2%:
Increases (4 builds for cc32xx, qpg)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #31745: Size comparison from f63b505 to 953375c Increases above 0.2%:
Increases (36 builds for cc32xx, cyw30739, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (27 builds for cc13x4_26x4, efr32, esp32, k32w, linux, psoc6, telink)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #25225
Fixes #31725