-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands #31700
Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands #31700
Conversation
bfc0b09
to
ce5676b
Compare
PR #31700: Size comparison from 7456670 to f8b3e07 Increases above 0.2%:
Increases (15 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
src/app/clusters/door-lock-server/door-lock-server-callback.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
PR #31700: Size comparison from 7456670 to dc0916d Increases (11 builds for bl602, bl702, bl702l, stm32)
Full report (11 builds for bl602, bl702, bl702l, stm32)
|
739ad1b
to
d3a6458
Compare
PR #31700: Size comparison from 75a3f66 to d3a6458 Increases above 0.2%:
Increases (15 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31700: Size comparison from 20c46c2 to 0f6bc26 Increases above 0.2%:
Increases (15 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #31700: Size comparison from 20c46c2 to 979362d Increases above 0.2%:
Increases (7 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
Decreases (17 builds for cc13x4_26x4, cc32xx, k32w, nrfconnect, qpg, stm32)
Full report (19 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
…f an attribute is nullable or not
PR #31700: Size comparison from bc8b34b to 37e0856 Increases above 0.2%:
Increases (15 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
f63c16a
to
a7f4513
Compare
PR #31700: Size comparison from d46f426 to a7f4513 Full report (11 builds for bl602, bl702, bl702l, stm32)
|
8eba123
to
2522594
Compare
PR #31700: Size comparison from 6fd32ba to 2522594 Increases above 0.2%:
Increases (15 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for efr32, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
…ReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) Merge in WMN_TOOLS/matter from cherry-pick/dl_aliro to RC_2.3.0-1.3 Squashed commit of the following: commit 471bcc1d95bc35bb13a7e02e481d81ec9e4f00d7 Author: Nivi Sarkar <[email protected]> Date: Tue Jan 30 16:37:46 2024 -0800 Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) * Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands Add a delegate for the door lock to provide the attribute data for the aliro attributes * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Addressed more review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Add an AttributeNullabilityType enum instead of boolean to indicate if an attribute is nullable or not * Restyled by clang-format * Make AttributeNullabilityType enum private --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
…ReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) Merge in WMN_TOOLS/matter from cherry-pick/dl_aliro to RC_2.3.0-1.3 Squashed commit of the following: commit 471bcc1d95bc35bb13a7e02e481d81ec9e4f00d7 Author: Nivi Sarkar <[email protected]> Date: Tue Jan 30 16:37:46 2024 -0800 Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands (project-chip#31700) * Add handling for SetAliroReaderConfig and ClearAliroReaderConfig commands Add a delegate for the door lock to provide the attribute data for the aliro attributes * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Addressed more review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Add an AttributeNullabilityType enum instead of boolean to indicate if an attribute is nullable or not * Restyled by clang-format * Make AttributeNullabilityType enum private --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Add a delegate for the door lock to provide the attribute data for the aliro attributes
Fixes: #31699