Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of optional struct-typed command arguments in chip-tool. #31658

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix handling of optional struct-typed command arguments in chip-tool. #31658

merged 1 commit into from
Jan 24, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

AddArgument documents that for "complex" (i.e. list and struct) arguments there is no automatic type-based handling of optionality and the "kOptional" flag needs to be passed in explicitly. But the generated code was not doing that.

ReneJosefsen
ReneJosefsen approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@ReneJosefsen ReneJosefsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why e.g. the OpenDuration in Valve Configuration and Control cluster is not getting marked here 🤔

AddArgument("OpenDuration", 0, UINT32_MAX, &mRequest.openDuration);

Maybe there is an issue in the XML for that cluster?

chrisdecenzo
chrisdecenzo approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@chrisdecenzo chrisdecenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will likely break the chip-tool command lines in some test cases and so we should give a heads up to folks like @Rajashreekalmane

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

PR #31658: Size comparison from 16409ca to 8a10fba

Decreases (1 build for efr32)
platform target config section 16409ca 8a10fba change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 930384 930376 -8 -0.0
.text 731084 731076 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 16409ca 8a10fba change % change
bl602 lighting-app bl602 (read/write) 1428218 1428218 0 0.0
.bss 85328 85328 0 0.0
.data 9488 9488 0 0.0
.rodata 157324 157324 0 0.0
.text 1095438 1095438 0 0.0
bl602+mfd (read/write) 1442890 1442890 0 0.0
.bss 85496 85496 0 0.0
.data 9456 9456 0 0.0
.rodata 156284 156284 0 0.0
.text 1111004 1111004 0 0.0
bl602+rpc (read/write) 1475970 1475970 0 0.0
.bss 93368 93368 0 0.0
.data 9864 9864 0 0.0
.rodata 164892 164892 0 0.0
.text 1127186 1127186 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1193075 1193075 0 0.0
.bss 11133 11133 0 0.0
.data 3664 3664 0 0.0
.rodata 106708 106708 0 0.0
.text 964768 964768 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1204155 1204155 0 0.0
.bss 11309 11309 0 0.0
.data 3648 3648 0 0.0
.rodata 105648 105648 0 0.0
.text 976778 976778 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1284695 1284695 0 0.0
.bss 19597 19597 0 0.0
.data 4224 4224 0 0.0
.rodata 122080 122080 0 0.0
.text 1039578 1039578 0 0.0
bl706-eth (read/write) 1011657 1011657 0 0.0
.bss 23692 23692 0 0.0
.data 3240 3240 0 0.0
.rodata 100028 100028 0 0.0
.text 756742 756742 0 0.0
bl706-wifi (read/write) 1244618 1244618 0 0.0
.bss 10577 10577 0 0.0
.data 3680 3680 0 0.0
.rodata 121008 121008 0 0.0
.text 986962 986962 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1162456 1162456 0 0.0
.bss 16328 16328 0 0.0
.data 5032 5032 0 0.0
.rodata 100712 100712 0 0.0
.text 957646 957646 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1173852 1173852 0 0.0
.bss 16504 16504 0 0.0
.data 5008 5008 0 0.0
.rodata 99652 99652 0 0.0
.text 969968 969968 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 781360 781360 0 0.0
(read/write) 168864 168864 0 0.0
.bss 90884 90884 0 0.0
.data 3552 3552 0 0.0
.rodata 90312 90312 0 0.0
.text 690784 690784 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798792 798792 0 0.0
(read/write) 179108 179108 0 0.0
.bss 101068 101068 0 0.0
.data 3580 3580 0 0.0
.rodata 84640 84640 0 0.0
.text 713884 713884 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787304 787304 0 0.0
(read/write) 173564 173564 0 0.0
.bss 95524 95524 0 0.0
.data 3580 3580 0 0.0
.rodata 111376 111376 0 0.0
.text 675660 675660 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738624 738624 0 0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86032 86032 0 0.0
.text 652328 652328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724248 724248 0 0.0
(read/write) 168048 168048 0 0.0
.bss 89848 89848 0 0.0
.data 3536 3536 0 0.0
.rodata 81872 81872 0 0.0
.text 642112 642112 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 572954 572954 0 0.0
(read/write) 207896 207896 0 0.0
.bss 201180 201180 0 0.0
.data 1592 1592 0 0.0
.rodata 84522 84522 0 0.0
.text 486308 486308 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627218 627218 0 0.0
(read/write) 208296 208296 0 0.0
.bss 201656 201656 0 0.0
.data 1520 1520 0 0.0
.rodata 106386 106386 0 0.0
.text 518712 518712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564279 564279 0 0.0
.app_xip_area 454201 454201 0 0.0
.bss 64920 64920 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 547927 547927 0 0.0
.app_xip_area 433105 433105 0 0.0
.bss 69624 69624 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566103 566103 0 0.0
.app_xip_area 457481 457481 0 0.0
.bss 63504 63504 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562399 562399 0 0.0
.app_xip_area 450545 450545 0 0.0
.bss 66624 66624 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 930384 930376 -8 -0.0
.bss 197904 197904 0 0.0
.data 1372 1372 0 0.0
.text 731084 731076 -8 -0.0
BRD4187C (read/write) 1108176 1108176 0 0.0
.bss 195156 195156 0 0.0
.data 3384 3384 0 0.0
.text 909616 909616 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121724 1121724 0 0.0
.bss 188192 188192 0 0.0
.data 2800 2800 0 0.0
.text 930712 930712 0 0.0
window-app BRD4187C (read/write) 1147960 1147960 0 0.0
.bss 167148 167148 0 0.0
.data 3292 3292 0 0.0
.text 977500 977500 0 0.0
esp32 all-clusters-app c3devkit (read only) 1199930 1199930 0 0.0
(read/write) 1744736 1744736 0 0.0
.dram0.bss 73392 73392 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 248224 248224 0 0.0
.flash.text 1199930 1199930 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1242007 1242007 0 0.0
(read/write) 529704 529704 0 0.0
.dram0.bss 80264 80264 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 278388 278388 0 0.0
.flash.text 1235843 1235843 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 610520 610520 0 0.0
(read/write) 81332 81332 0 0.0
.bss 69112 69112 0 0.0
.data 2236 2236 0 0.0
.text 609984 609984 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 696220 696220 0 0.0
.bss 67768 67768 0 0.0
.data 2788 2788 0 0.0
.text 582192 582192 0 0.0
light k32w0+release (read only) 598896 598896 0 0.0
(read/write) 79340 79340 0 0.0
.bss 67168 67168 0 0.0
.data 2188 2188 0 0.0
.text 598360 598360 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787200 787200 0 0.0
.bss 77436 77436 0 0.0
.data 2000 2000 0 0.0
.text 664312 664312 0 0.0
lock k32w0+release (read only) 580152 580152 0 0.0
(read/write) 78756 78756 0 0.0
.bss 66608 66608 0 0.0
.data 2164 2164 0 0.0
.text 579616 579616 0 0.0
linux air-purifier-app debug (read only) 2576541 2576541 0 0.0
(read/write) 127704 127704 0 0.0
.bss 46336 46336 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 73304 73304 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 181480 181480 0 0.0
.text 2218821 2218821 0 0.0
all-clusters-app debug (read only) 5788633 5788633 0 0.0
(read/write) 469520 469520 0 0.0
.bss 132944 132944 0 0.0
.data 4480 4480 0 0.0
.data.rel.ro 324744 324744 0 0.0
.dynamic 624 624 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 1336 1336 0 0.0
.rodata 341884 341884 0 0.0
.text 5022691 5022691 0 0.0
all-clusters-minimal-app debug (read only) 5134113 5134113 0 0.0
(read/write) 235248 235248 0 0.0
.bss 127280 127280 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 96520 96520 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 285485 285485 0 0.0
.text 4615283 4615283 0 0.0
bridge-app debug (read only) 4550825 4550825 0 0.0
(read/write) 216584 216584 0 0.0
.bss 117976 117976 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85760 85760 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 227221 227221 0 0.0
.text 4104099 4104099 0 0.0
chip-tool debug (read only) 12108553 12108553 0 0.0
(read/write) 516912 516912 0 0.0
.bss 94264 94264 0 0.0
.data 5058 5058 0 0.0
.data.rel.ro 410336 410336 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 439993 439993 0 0.0
.text 10962019 10962019 0 0.0
chip-tool-ipv6only arm64 (read only) 11641328 11641328 0 0.0
(read/write) 587056 587056 0 0.0
.bss 103288 103288 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 449880 449880 0 0.0
.dynamic 512 512 0 0.0
.got 20400 20400 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 347420 347420 0 0.0
.text 10405292 10405292 0 0.0
lighting-app debug+rpc+ui (read only) 5469817 5469817 0 0.0
(read/write) 225384 225384 0 0.0
.bss 118944 118944 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94144 94144 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 350932 350932 0 0.0
.text 4873283 4873283 0 0.0
lock-app debug (read only) 4621305 4621305 0 0.0
(read/write) 204112 204112 0 0.0
.bss 113312 113312 0 0.0
.data 4096 4096 0 0.0
.data.rel.ro 79992 79992 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 253845 253845 0 0.0
.text 4156499 4156499 0 0.0
ota-provider-app debug (read only) 4259449 4259449 0 0.0
(read/write) 192688 192688 0 0.0
.bss 113248 113248 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206325 206325 0 0.0
.text 3861251 3861251 0 0.0
ota-requestor-app debug (read only) 4375433 4375433 0 0.0
(read/write) 196968 196968 0 0.0
.bss 114144 114144 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 212181 212181 0 0.0
.text 3967075 3967075 0 0.0
shell debug (read only) 2868257 2868257 0 0.0
(read/write) 154840 154840 0 0.0
.bss 62248 62248 0 0.0
.data 1344 1344 0 0.0
.data.rel.ro 85480 85480 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185664 185664 0 0.0
.text 2510210 2510210 0 0.0
thermostat-no-ble arm64 (read only) 4448056 4448056 0 0.0
(read/write) 247448 247448 0 0.0
.bss 121672 121672 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 103272 103272 0 0.0
.dynamic 512 512 0 0.0
.got 12160 12160 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158348 158348 0 0.0
.text 3945900 3945900 0 0.0
tv-app debug (read only) 5583337 5583337 0 0.0
(read/write) 350384 350384 0 0.0
.bss 243296 243296 0 0.0
.data 6464 6464 0 0.0
.data.rel.ro 93336 93336 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 284309 284309 0 0.0
.text 5059123 5059123 0 0.0
tv-casting-app debug (read only) 9977945 9977945 0 0.0
(read/write) 342520 342520 0 0.0
.bss 156032 156032 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 176672 176672 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 377096 377096 0 0.0
.text 9128483 9128483 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531192 2531192 0 0.0
.bss 220392 220392 0 0.0
.data 5208 5208 0 0.0
.text 1493876 1493876 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1095884 1095884 0 0.0
bss 129801 129801 0 0.0
rodata 111372 111372 0 0.0
text 806880 806880 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1216180 1216180 0 0.0
bss 121939 121939 0 0.0
rodata 141176 141176 0 0.0
text 802576 802576 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1045284 1045284 0 0.0
bss 129527 129527 0 0.0
rodata 99204 99204 0 0.0
text 768828 768828 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835352 835352 0 0.0
(read/write) 1792900 1792900 0 0.0
.bss 195348 195348 0 0.0
.data 2640 2640 0 0.0
.text 1586524 1586524 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837656 837656 0 0.0
(read/write) 1715420 1715420 0 0.0
.bss 193068 193068 0 0.0
.data 2616 2616 0 0.0
.text 1511348 1511348 0 0.0
light cy8ckit_062s2_43012 (read only) 844352 844352 0 0.0
(read/write) 1636412 1636412 0 0.0
.bss 186556 186556 0 0.0
.data 2432 2432 0 0.0
.text 1439036 1439036 0 0.0
lock cy8ckit_062s2_43012 (read only) 817232 817232 0 0.0
(read/write) 1665716 1665716 0 0.0
.bss 213652 213652 0 0.0
.data 2456 2456 0 0.0
.text 1441220 1441220 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1122624 1122624 0 0.0
.bss 102344 102344 0 0.0
.data 808 808 0 0.0
.text 635004 635004 0 0.0
lock-app qpg6105+debug (read/write) 1086152 1086152 0 0.0
.bss 98528 98528 0 0.0
.data 852 852 0 0.0
.text 598528 598528 0 0.0
stm32 light STM32WB5MM-DK (read/write) 597517 597517 0 0.0
.bss 128280 128280 0 0.0
.data 660 660 0 0.0
.rodata 78756 78756 0 0.0
.text 380096 380096 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825622 825622 0 0.0
bss 51020 51020 0 0.0
text 617574 617574 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1114644 1114644 0 0.0
bss 100784 100784 0 0.0
text 789276 789276 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1091884 1091884 0 0.0
bss 109920 109920 0 0.0
text 760282 760282 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935876 935876 0 0.0
bss 92988 92988 0 0.0
text 649670 649670 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 827514 827514 0 0.0
bss 51072 51072 0 0.0
text 619532 619532 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 985472 985472 0 0.0
bss 79116 79116 0 0.0
text 700262 700262 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1097892 1097892 0 0.0
bss 100064 100064 0 0.0
text 773918 773918 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 971392 971392 0 0.0
bss 97416 97416 0 0.0
text 653438 653438 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953708 953708 0 0.0
bss 92564 92564 0 0.0
text 667610 667610 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884768 884768 0 0.0
bss 69136 69136 0 0.0
text 626072 626072 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825420 825420 0 0.0
bss 57380 57380 0 0.0
text 592996 592996 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705772 705772 0 0.0
bss 73640 73640 0 0.0
text 462164 462164 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 829266 829266 0 0.0
bss 51200 51200 0 0.0
text 622302 622302 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884049 884049 0 0.0
bss 60856 60856 0 0.0
text 636114 636114 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 851736 851736 0 0.0
bss 57668 57668 0 0.0
text 613292 613292 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844480 844480 0 0.0
bss 57984 57984 0 0.0
text 605910 605910 0 0.0

@bzbarsky-apple
Fix handling of optional struct-typed command arguments in chip-tool.
fbf4f43 
AddArgument documents that for "complex" (i.e. list and struct) arguments there
is no automatic type-based handling of optionality and the "kOptional" flag
needs to be passed in explicitly.  But the generated code was not doing that.
@bzbarsky-apple bzbarsky-apple force-pushed the fix-chip-tool-optional-struct-command-args branch from 8a10fba to fbf4f43 Compare January 24, 2024 17:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

PR #31658: Size comparison from 4aa833d to fbf4f43

Decreases (1 build for efr32)
platform target config section 4aa833d fbf4f43 change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 930384 930376 -8 -0.0
.text 731084 731076 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 4aa833d fbf4f43 change % change
bl602 lighting-app bl602 (read/write) 1428218 1428218 0 0.0
.bss 85328 85328 0 0.0
.data 9488 9488 0 0.0
.rodata 157324 157324 0 0.0
.text 1095438 1095438 0 0.0
bl602+mfd (read/write) 1442890 1442890 0 0.0
.bss 85496 85496 0 0.0
.data 9456 9456 0 0.0
.rodata 156284 156284 0 0.0
.text 1111004 1111004 0 0.0
bl602+rpc (read/write) 1475970 1475970 0 0.0
.bss 93368 93368 0 0.0
.data 9864 9864 0 0.0
.rodata 164892 164892 0 0.0
.text 1127186 1127186 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1193147 1193147 0 0.0
.bss 11133 11133 0 0.0
.data 3664 3664 0 0.0
.rodata 106708 106708 0 0.0
.text 964840 964840 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1204227 1204227 0 0.0
.bss 11309 11309 0 0.0
.data 3648 3648 0 0.0
.rodata 105648 105648 0 0.0
.text 976850 976850 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1284767 1284767 0 0.0
.bss 19597 19597 0 0.0
.data 4224 4224 0 0.0
.rodata 122080 122080 0 0.0
.text 1039650 1039650 0 0.0
bl706-eth (read/write) 1011657 1011657 0 0.0
.bss 23692 23692 0 0.0
.data 3240 3240 0 0.0
.rodata 100028 100028 0 0.0
.text 756742 756742 0 0.0
bl706-wifi (read/write) 1244618 1244618 0 0.0
.bss 10577 10577 0 0.0
.data 3680 3680 0 0.0
.rodata 121008 121008 0 0.0
.text 986962 986962 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1162528 1162528 0 0.0
.bss 16328 16328 0 0.0
.data 5032 5032 0 0.0
.rodata 100712 100712 0 0.0
.text 957718 957718 0 0.0
bl702l+mfd (read/write) 1174436 1174436 0 0.0
.bss 16504 16504 0 0.0
.data 5008 5008 0 0.0
.rodata 99652 99652 0 0.0
.text 970040 970040 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 781408 781408 0 0.0
(read/write) 168864 168864 0 0.0
.bss 90884 90884 0 0.0
.data 3552 3552 0 0.0
.rodata 90312 90312 0 0.0
.text 690832 690832 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798840 798840 0 0.0
(read/write) 179108 179108 0 0.0
.bss 101068 101068 0 0.0
.data 3580 3580 0 0.0
.rodata 84640 84640 0 0.0
.text 713932 713932 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787352 787352 0 0.0
(read/write) 173564 173564 0 0.0
.bss 95524 95524 0 0.0
.data 3580 3580 0 0.0
.rodata 111376 111376 0 0.0
.text 675708 675708 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738672 738672 0 0.0
(read/write) 167836 167836 0 0.0
.bss 89624 89624 0 0.0
.data 3540 3540 0 0.0
.rodata 86032 86032 0 0.0
.text 652376 652376 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724296 724296 0 0.0
(read/write) 168048 168048 0 0.0
.bss 89848 89848 0 0.0
.data 3536 3536 0 0.0
.rodata 81872 81872 0 0.0
.text 642160 642160 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 572954 572954 0 0.0
(read/write) 207896 207896 0 0.0
.bss 201180 201180 0 0.0
.data 1592 1592 0 0.0
.rodata 84522 84522 0 0.0
.text 486308 486308 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627218 627218 0 0.0
(read/write) 208296 208296 0 0.0
.bss 201656 201656 0 0.0
.data 1520 1520 0 0.0
.rodata 106386 106386 0 0.0
.text 518712 518712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564335 564335 0 0.0
.app_xip_area 454257 454257 0 0.0
.bss 64920 64920 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 547983 547983 0 0.0
.app_xip_area 433161 433161 0 0.0
.bss 69624 69624 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566151 566151 0 0.0
.app_xip_area 457529 457529 0 0.0
.bss 63504 63504 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562447 562447 0 0.0
.app_xip_area 450593 450593 0 0.0
.bss 66624 66624 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 930384 930376 -8 -0.0
.bss 197904 197904 0 0.0
.data 1372 1372 0 0.0
.text 731084 731076 -8 -0.0
BRD4187C (read/write) 1108240 1108240 0 0.0
.bss 195156 195156 0 0.0
.data 3384 3384 0 0.0
.text 909680 909680 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121724 1121724 0 0.0
.bss 188192 188192 0 0.0
.data 2800 2800 0 0.0
.text 930712 930712 0 0.0
window-app BRD4187C (read/write) 1148024 1148024 0 0.0
.bss 167148 167148 0 0.0
.data 3292 3292 0 0.0
.text 977564 977564 0 0.0
esp32 all-clusters-app c3devkit (read only) 1199930 1199930 0 0.0
(read/write) 1744736 1744736 0 0.0
.dram0.bss 73392 73392 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 248224 248224 0 0.0
.flash.text 1199930 1199930 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1242007 1242007 0 0.0
(read/write) 529704 529704 0 0.0
.dram0.bss 80264 80264 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 278388 278388 0 0.0
.flash.text 1235843 1235843 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 610584 610584 0 0.0
(read/write) 81332 81332 0 0.0
.bss 69112 69112 0 0.0
.data 2236 2236 0 0.0
.text 610048 610048 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 696268 696268 0 0.0
.bss 67768 67768 0 0.0
.data 2788 2788 0 0.0
.text 582240 582240 0 0.0
light k32w0+release (read only) 598944 598944 0 0.0
(read/write) 79340 79340 0 0.0
.bss 67168 67168 0 0.0
.data 2188 2188 0 0.0
.text 598408 598408 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787256 787256 0 0.0
.bss 77436 77436 0 0.0
.data 2000 2000 0 0.0
.text 664368 664368 0 0.0
lock k32w0+release (read only) 580200 580200 0 0.0
(read/write) 78756 78756 0 0.0
.bss 66608 66608 0 0.0
.data 2164 2164 0 0.0
.text 579664 579664 0 0.0
linux air-purifier-app debug (read only) 2576541 2576541 0 0.0
(read/write) 127704 127704 0 0.0
.bss 46336 46336 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 73304 73304 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 181480 181480 0 0.0
.text 2218821 2218821 0 0.0
all-clusters-app debug (read only) 5788633 5788633 0 0.0
(read/write) 469520 469520 0 0.0
.bss 132944 132944 0 0.0
.data 4480 4480 0 0.0
.data.rel.ro 324744 324744 0 0.0
.dynamic 624 624 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 1336 1336 0 0.0
.rodata 341884 341884 0 0.0
.text 5022691 5022691 0 0.0
all-clusters-minimal-app debug (read only) 5134113 5134113 0 0.0
(read/write) 235248 235248 0 0.0
.bss 127280 127280 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 96520 96520 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 285485 285485 0 0.0
.text 4615283 4615283 0 0.0
bridge-app debug (read only) 4550825 4550825 0 0.0
(read/write) 216584 216584 0 0.0
.bss 117976 117976 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85760 85760 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 227221 227221 0 0.0
.text 4104099 4104099 0 0.0
chip-tool debug (read only) 12108553 12108553 0 0.0
(read/write) 516912 516912 0 0.0
.bss 94264 94264 0 0.0
.data 5058 5058 0 0.0
.data.rel.ro 410336 410336 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 439993 439993 0 0.0
.text 10962019 10962019 0 0.0
chip-tool-ipv6only arm64 (read only) 11641328 11641328 0 0.0
(read/write) 587056 587056 0 0.0
.bss 103288 103288 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 449880 449880 0 0.0
.dynamic 512 512 0 0.0
.got 20400 20400 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 347420 347420 0 0.0
.text 10405292 10405292 0 0.0
lighting-app debug+rpc+ui (read only) 5469817 5469817 0 0.0
(read/write) 225384 225384 0 0.0
.bss 118944 118944 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94144 94144 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 350932 350932 0 0.0
.text 4873283 4873283 0 0.0
lock-app debug (read only) 4621305 4621305 0 0.0
(read/write) 204112 204112 0 0.0
.bss 113312 113312 0 0.0
.data 4096 4096 0 0.0
.data.rel.ro 79992 79992 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 253845 253845 0 0.0
.text 4156499 4156499 0 0.0
ota-provider-app debug (read only) 4259449 4259449 0 0.0
(read/write) 192688 192688 0 0.0
.bss 113248 113248 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206325 206325 0 0.0
.text 3861251 3861251 0 0.0
ota-requestor-app debug (read only) 4375433 4375433 0 0.0
(read/write) 196968 196968 0 0.0
.bss 114144 114144 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 212181 212181 0 0.0
.text 3967075 3967075 0 0.0
shell debug (read only) 2868257 2868257 0 0.0
(read/write) 154840 154840 0 0.0
.bss 62248 62248 0 0.0
.data 1344 1344 0 0.0
.data.rel.ro 85480 85480 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185664 185664 0 0.0
.text 2510210 2510210 0 0.0
thermostat-no-ble arm64 (read only) 4448056 4448056 0 0.0
(read/write) 247448 247448 0 0.0
.bss 121672 121672 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 103272 103272 0 0.0
.dynamic 512 512 0 0.0
.got 12160 12160 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158348 158348 0 0.0
.text 3945900 3945900 0 0.0
tv-app debug (read only) 5583337 5583337 0 0.0
(read/write) 350384 350384 0 0.0
.bss 243296 243296 0 0.0
.data 6464 6464 0 0.0
.data.rel.ro 93336 93336 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 284309 284309 0 0.0
.text 5059123 5059123 0 0.0
tv-casting-app debug (read only) 9977945 9977945 0 0.0
(read/write) 342520 342520 0 0.0
.bss 156032 156032 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 176672 176672 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 377096 377096 0 0.0
.text 9128483 9128483 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531192 2531192 0 0.0
.bss 220392 220392 0 0.0
.data 5208 5208 0 0.0
.text 1493876 1493876 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1095932 1095932 0 0.0
bss 129801 129801 0 0.0
rodata 111372 111372 0 0.0
text 806932 806932 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1216180 1216180 0 0.0
bss 121939 121939 0 0.0
rodata 141176 141176 0 0.0
text 802576 802576 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1045332 1045332 0 0.0
bss 129527 129527 0 0.0
rodata 99204 99204 0 0.0
text 768880 768880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835352 835352 0 0.0
(read/write) 1792900 1792900 0 0.0
.bss 195348 195348 0 0.0
.data 2640 2640 0 0.0
.text 1586524 1586524 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837656 837656 0 0.0
(read/write) 1715420 1715420 0 0.0
.bss 193068 193068 0 0.0
.data 2616 2616 0 0.0
.text 1511348 1511348 0 0.0
light cy8ckit_062s2_43012 (read only) 844352 844352 0 0.0
(read/write) 1636412 1636412 0 0.0
.bss 186556 186556 0 0.0
.data 2432 2432 0 0.0
.text 1439036 1439036 0 0.0
lock cy8ckit_062s2_43012 (read only) 817232 817232 0 0.0
(read/write) 1665716 1665716 0 0.0
.bss 213652 213652 0 0.0
.data 2456 2456 0 0.0
.text 1441220 1441220 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1122680 1122680 0 0.0
.bss 102344 102344 0 0.0
.data 808 808 0 0.0
.text 635060 635060 0 0.0
lock-app qpg6105+debug (read/write) 1086200 1086200 0 0.0
.bss 98528 98528 0 0.0
.data 852 852 0 0.0
.text 598576 598576 0 0.0
stm32 light STM32WB5MM-DK (read/write) 597565 597565 0 0.0
.bss 128280 128280 0 0.0
.data 660 660 0 0.0
.rodata 78756 78756 0 0.0
.text 380144 380144 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825678 825678 0 0.0
bss 51020 51020 0 0.0
text 617636 617636 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1114708 1114708 0 0.0
bss 100784 100784 0 0.0
text 789342 789342 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1091948 1091948 0 0.0
bss 109920 109920 0 0.0
text 760348 760348 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935940 935940 0 0.0
bss 92988 92988 0 0.0
text 649736 649736 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 827578 827578 0 0.0
bss 51072 51072 0 0.0
text 619594 619594 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 985536 985536 0 0.0
bss 79116 79116 0 0.0
text 700328 700328 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1097956 1097956 0 0.0
bss 100064 100064 0 0.0
text 773984 773984 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 971456 971456 0 0.0
bss 97416 97416 0 0.0
text 653504 653504 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953772 953772 0 0.0
bss 92564 92564 0 0.0
text 667676 667676 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884840 884840 0 0.0
bss 69136 69136 0 0.0
text 626138 626138 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825484 825484 0 0.0
bss 57380 57380 0 0.0
text 593062 593062 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705772 705772 0 0.0
bss 73640 73640 0 0.0
text 462164 462164 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 829322 829322 0 0.0
bss 51200 51200 0 0.0
text 622364 622364 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884113 884113 0 0.0
bss 60856 60856 0 0.0
text 636180 636180 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 851800 851800 0 0.0
bss 57668 57668 0 0.0
text 613358 613358 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844544 844544 0 0.0
bss 57984 57984 0 0.0
text 605976 605976 0 0.0

@mergify mergify bot merged commit 42c44d5 into project-chip:master Jan 24, 2024
57 checks passed
@bzbarsky-apple bzbarsky-apple deleted the fix-chip-tool-optional-struct-command-args branch January 26, 2024 05:20
@bzbarsky-apple
Copy link
Contributor Author

bzbarsky-apple commented Jan 27, 2024 •
edited
Loading

I'm wondering why e.g. the OpenDuration in Valve Configuration and Control cluster is not getting marked here 🤔

It doesn't need to, because in that case it's using &mRequest.openDuration as the location of the data, which is a pointer to an Optional, so the AddArgument machinery can correctly deduce it's optional without any manual hinting.

It's only struct-typed command fields that use a different type for the AddArgument and hence need the manual bit.

@ReneJosefsen
Copy link
Contributor

Okay, I see. Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneJosefsen ReneJosefsen ReneJosefsen approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@andy31415 andy31415 Awaiting requested review from andy31415

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@tehampson tehampson Awaiting requested review from tehampson

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bzbarsky-apple @ReneJosefsen @andy31415 @tehampson @yunhanw-google @woody-apple @chrisdecenzo