-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages Cluster XML #31656
Messages Cluster XML #31656
Conversation
4680782
to
8a94015
Compare
PR #31656: Size comparison from 09324e7 to 8a94015 Increases above 0.2%:
Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
optional char_string<32> label = 1; | ||
} | ||
|
||
struct MessageStruct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this struct is fabric-scoped in the specification. Is there a specification issue to turn this in non-fabric scoped due to issues including in command or what is the plan here?
Otherwise this must be flagged as such (and we need a fabric_idx as field 254)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was removed in #31675 ... we should probably make efforts to detect re-additions.
This is continuation of PR #30254
It's all about defining Messages cluster XML and creating boilerplate code using ZAP.