-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor app/Build.gn to enable depending on individual components #31632
Refactor app/Build.gn to enable depending on individual components #31632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I wonder if there is any negative impact on pulling those sources out of the large app Static lib
… of the ICDManager
1094ad0
to
e569dd9
Compare
PR #31632: Size comparison from 57898b9 to e569dd9 Increases above 0.2%:
Increases (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg, stm32)
Decreases (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, qpg, stm32, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31632: Size comparison from 57898b9 to 9903ab0 Increases above 0.2%:
Increases (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg, stm32)
Decreases (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, qpg, stm32, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #31632: Size comparison from 57898b9 to 80c7259 Increases (21 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, qpg, stm32)
Decreases (23 builds for bl602, bl702, bl702l, cc13x4_26x4, k32w, mbed, nrfconnect, qpg, stm32)
Full report (29 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
PR #31632: Size comparison from 57898b9 to ed6a917 Increases above 0.2%:
Increases (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg, stm32)
Decreases (60 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, stm32, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Description
For the
src/app/Build.gn
, every source file was in the same static library which made it impossible to depend on individual components.The ICDManager is built with apps but needs to depend on the InteractionModelEngine which it couldn't do under the previous structure. See #31563
PR splits the source files into several blocks to enable depending on individuals components.
Tests
PR doesn't change any behavior; Using CI to validate everything can still build