-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Microwave Oven] Fix build error for Microwave Oven APP #31619
Conversation
PR #31619: Size comparison from 9c93583 to 1a7234a Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the codesize and memory results once those are available (we are tracking that for this example app, right?), but at first glance this is adding more code (but maybe not?) and an extra member for not particular benefit....
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Show resolved
Hide resolved
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Outdated
Show resolved
Hide resolved
PR #31619: Size comparison from 7f5e208 to a1fdfe3 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Is the microwave oven app currently compiled in the CI? It seems like this should have been caught automatically. If it's not there, can it be added? |
I'm working on this... |
PR #31619: Size comparison from e5f5d67 to 1a4ca6e Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
src/app/clusters/microwave-oven-control-server/microwave-oven-control-server.cpp
Outdated
Show resolved
Hide resolved
PR #31619: Size comparison from 1582d8c to 471fd35 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Fixes: #31525
Description:
Add static_cast for unsigned value to avoid complie error(ASR plaform).