Move emAfLoadAttributeDefaults to private inside attribute-storage.cpp #31427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the API surface for ember attribute storage: - remove unused ability to "load defaults without loading persistence" - make the full loadDefautls + cluster private for now as it is not used Looking to reduce the API surface of ember attribute storage to consider making it pluggable/modular (to allow for better unit testing support).
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #31427: Size comparison from 695d0bf to 4604c1a Decreases (5 builds for cc32xx, mbed, qpg)
Full report (5 builds for cc32xx, mbed, qpg)
|
This comment was marked as outdated.
This comment was marked as outdated.
andy31415
commented
Jan 15, 2024
|
PR #31427: Size comparison from 695d0bf to 8f3671a Decreases (8 builds for cc32xx, mbed, nrfconnect, qpg)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
cecille
approved these changes
Jan 15, 2024
|
PR #31427: Size comparison from 695d0bf to 45e920a Increases (2 builds for cc32xx)
Decreases (2 builds for cc32xx)
Full report (2 builds for cc32xx)
|
|
PR #31427: Size comparison from 695d0bf to 9785328 Increases (15 builds for cc13x4_26x4, cc32xx, efr32, linux, psoc6)
Decreases (57 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the API surface for ember attribute storage:
Looking to reduce the API surface of ember attribute storage to consider making it pluggable/modular (to allow for better unit testing support).