Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chef] Fix variable may be used without initialization #31413

Merged

Conversation

erwinpan1
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 15, 2024

PR #31413: Size comparison from 4676d27 to f0ea6fa

Decreases (1 build for efr32)
platform target config section 4676d27 f0ea6fa change % change
efr32 window-app BRD4187C (read/write) 1138792 1138784 -8 -0.0
.text 968556 968548 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 4676d27 f0ea6fa change % change
bl602 lighting-app bl602 (read/write) 1420086 1420086 0 0.0
.bss 85184 85184 0 0.0
.data 9488 9488 0 0.0
.rodata 157048 157048 0 0.0
.text 1087726 1087726 0 0.0
bl602+mfd (read/write) 1434558 1434558 0 0.0
.bss 85352 85352 0 0.0
.data 9456 9456 0 0.0
.rodata 156008 156008 0 0.0
.text 1103094 1103094 0 0.0
bl602+rpc (read/write) 1467862 1467862 0 0.0
.bss 93216 93216 0 0.0
.data 9856 9856 0 0.0
.rodata 164664 164664 0 0.0
.text 1119470 1119470 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1185131 1185131 0 0.0
.bss 11133 11133 0 0.0
.data 3656 3656 0 0.0
.rodata 106420 106420 0 0.0
.text 957390 957390 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1196263 1196263 0 0.0
.bss 11309 11309 0 0.0
.data 3640 3640 0 0.0
.rodata 105360 105360 0 0.0
.text 969454 969454 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1276807 1276807 0 0.0
.bss 19597 19597 0 0.0
.data 4216 4216 0 0.0
.rodata 121840 121840 0 0.0
.text 1032196 1032196 0 0.0
bl706-eth (read/write) 1004249 1004249 0 0.0
.bss 23692 23692 0 0.0
.data 3232 3232 0 0.0
.rodata 99752 99752 0 0.0
.text 749796 749796 0 0.0
bl706-wifi (read/write) 1235138 1235138 0 0.0
.bss 10577 10577 0 0.0
.data 3672 3672 0 0.0
.rodata 120732 120732 0 0.0
.text 977928 977928 0 0.0
bl702l lighting-app bl702l (read/write) 1155284 1155284 0 0.0
.bss 16328 16328 0 0.0
.data 5024 5024 0 0.0
.rodata 100424 100424 0 0.0
.text 950516 950516 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1165968 1165968 0 0.0
.bss 16504 16504 0 0.0
.data 5000 5000 0 0.0
.rodata 99364 99364 0 0.0
.text 962636 962636 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 778248 778248 0 0.0
(read/write) 168380 168380 0 0.0
.bss 90452 90452 0 0.0
.data 3524 3524 0 0.0
.rodata 88896 88896 0 0.0
.text 689088 689088 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 794264 794264 0 0.0
(read/write) 178608 178608 0 0.0
.bss 100628 100628 0 0.0
.data 3552 3552 0 0.0
.rodata 83112 83112 0 0.0
.text 710884 710884 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 782568 782568 0 0.0
(read/write) 173064 173064 0 0.0
.bss 95084 95084 0 0.0
.data 3552 3552 0 0.0
.rodata 109760 109760 0 0.0
.text 672540 672540 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 735192 735192 0 0.0
(read/write) 167384 167384 0 0.0
.bss 89232 89232 0 0.0
.data 3512 3512 0 0.0
.rodata 84488 84488 0 0.0
.text 650440 650440 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 720704 720704 0 0.0
(read/write) 167564 167564 0 0.0
.bss 89416 89416 0 0.0
.data 3508 3508 0 0.0
.rodata 80328 80328 0 0.0
.text 640112 640112 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 568106 568106 0 0.0
(read/write) 207744 207744 0 0.0
.bss 201028 201028 0 0.0
.data 1592 1592 0 0.0
.rodata 84034 84034 0 0.0
.text 481948 481948 0 0.0
lock CC3235SF_LAUNCHXL (read only) 621458 621458 0 0.0
(read/write) 208144 208144 0 0.0
.bss 201504 201504 0 0.0
.data 1520 1520 0 0.0
.rodata 105898 105898 0 0.0
.text 513436 513436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 562271 562271 0 0.0
.app_xip_area 452425 452425 0 0.0
.bss 64688 64688 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 544527 544527 0 0.0
.app_xip_area 429945 429945 0 0.0
.bss 69384 69384 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 563287 563287 0 0.0
.app_xip_area 454897 454897 0 0.0
.bss 63272 63272 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558831 558831 0 0.0
.app_xip_area 447209 447209 0 0.0
.bss 66392 66392 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1042376 1042376 0 0.0
.bss 192656 192656 0 0.0
.data 2776 2776 0 0.0
.text 846924 846924 0 0.0
BRD4187C (read/write) 1105456 1105456 0 0.0
.bss 194932 194932 0 0.0
.data 3384 3384 0 0.0
.text 907120 907120 0 0.0
lock-app BRD4161A+wf200 (read/write) 1118300 1118300 0 0.0
.bss 188040 188040 0 0.0
.data 2800 2800 0 0.0
.text 927440 927440 0 0.0
window-app BRD4187C (read/write) 1138792 1138784 -8 -0.0
.bss 166924 166924 0 0.0
.data 3292 3292 0 0.0
.text 968556 968548 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1153886 1153886 0 0.0
(read/write) 1669488 1669488 0 0.0
.dram0.bss 71656 71656 0 0.0
.dram0.data 13588 13588 0 0.0
.flash.rodata 240240 240240 0 0.0
.flash.text 1153886 1153886 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1200131 1200131 0 0.0
(read/write) 520108 520108 0 0.0
.dram0.bss 78520 78520 0 0.0
.dram0.data 35132 35132 0 0.0
.flash.rodata 270536 270536 0 0.0
.flash.text 1193967 1193967 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 606840 606840 0 0.0
(read/write) 81172 81172 0 0.0
.bss 68952 68952 0 0.0
.data 2236 2236 0 0.0
.text 606304 606304 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 692116 692116 0 0.0
.bss 67608 67608 0 0.0
.data 2788 2788 0 0.0
.text 578248 578248 0 0.0
light k32w0+release (read only) 596184 596184 0 0.0
(read/write) 79188 79188 0 0.0
.bss 67016 67016 0 0.0
.data 2188 2188 0 0.0
.text 595648 595648 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 783928 783928 0 0.0
.bss 77284 77284 0 0.0
.data 2000 2000 0 0.0
.text 661192 661192 0 0.0
lock k32w0+release (read only) 577656 577656 0 0.0
(read/write) 78644 78644 0 0.0
.bss 66496 66496 0 0.0
.data 2164 2164 0 0.0
.text 577120 577120 0 0.0
linux air-purifier-app debug (read only) 2535309 2535309 0 0.0
(read/write) 127192 127192 0 0.0
.bss 46272 46272 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 72856 72856 0 0.0
.dynamic 608 608 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 179688 179688 0 0.0
.text 2180341 2180341 0 0.0
all-clusters-app debug (read only) 5435593 5435593 0 0.0
(read/write) 458208 458208 0 0.0
.bss 131216 131216 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 315352 315352 0 0.0
.dynamic 624 624 0 0.0
.got 5336 5336 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 314012 314012 0 0.0
.text 4709395 4709395 0 0.0
all-clusters-minimal-app debug (read only) 4961265 4961265 0 0.0
(read/write) 234640 234640 0 0.0
.bss 127216 127216 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 95976 95976 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 271949 271949 0 0.0
.text 4457027 4457027 0 0.0
bridge-app debug (read only) 4426473 4426473 0 0.0
(read/write) 215976 215976 0 0.0
.bss 117816 117816 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85312 85312 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 219509 219509 0 0.0
.text 3988419 3988419 0 0.0
chip-tool debug (read only) 11782833 11782833 0 0.0
(read/write) 506264 506264 0 0.0
.bss 94200 94200 0 0.0
.data 5058 5058 0 0.0
.data.rel.ro 399792 399792 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 429657 429657 0 0.0
.text 10663363 10663363 0 0.0
chip-tool-ipv6only arm64 (read only) 11357216 11357216 0 0.0
(read/write) 576232 576232 0 0.0
.bss 103256 103256 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 439024 439024 0 0.0
.dynamic 512 512 0 0.0
.got 20040 20040 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 340332 340332 0 0.0
.text 10146652 10146652 0 0.0
lighting-app debug+rpc+ui (read only) 5311121 5311121 0 0.0
(read/write) 224936 224936 0 0.0
.bss 118848 118848 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 93728 93728 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 340276 340276 0 0.0
.text 4726131 4726131 0 0.0
lock-app debug (read only) 4511721 4511721 0 0.0
(read/write) 203600 203600 0 0.0
.bss 113248 113248 0 0.0
.data 4096 4096 0 0.0
.data.rel.ro 79544 79544 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 247445 247445 0 0.0
.text 4054275 4054275 0 0.0
ota-provider-app debug (read only) 4175953 4175953 0 0.0
(read/write) 192680 192680 0 0.0
.bss 113248 113248 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 69312 69312 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 201781 201781 0 0.0
.text 3782323 3782323 0 0.0
ota-requestor-app debug (read only) 4266833 4266833 0 0.0
(read/write) 196960 196960 0 0.0
.bss 114144 114144 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 72288 72288 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 205589 205589 0 0.0
.text 3865091 3865091 0 0.0
shell debug (read only) 2802969 2802969 0 0.0
(read/write) 152704 152704 0 0.0
.bss 61832 61832 0 0.0
.data 1344 1344 0 0.0
.data.rel.ro 83784 83784 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 182016 182016 0 0.0
.text 2449746 2449746 0 0.0
thermostat-no-ble arm64 (read only) 4355544 4355544 0 0.0
(read/write) 245728 245728 0 0.0
.bss 121624 121624 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 102776 102776 0 0.0
.dynamic 512 512 0 0.0
.got 12088 12088 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 155916 155916 0 0.0
.text 3857084 3857084 0 0.0
tv-app debug (read only) 5412993 5412993 0 0.0
(read/write) 349128 349128 0 0.0
.bss 243136 243136 0 0.0
.data 6464 6464 0 0.0
.data.rel.ro 92248 92248 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 273493 273493 0 0.0
.text 4901875 4901875 0 0.0
tv-casting-app debug (read only) 9654665 9654665 0 0.0
(read/write) 338080 338080 0 0.0
.bss 155936 155936 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 172384 172384 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 365800 365800 0 0.0
.text 8827171 8827171 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2527112 2527112 0 0.0
.bss 220240 220240 0 0.0
.data 5208 5208 0 0.0
.text 1489796 1489796 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1075376 1075376 0 0.0
bss 129403 129403 0 0.0
rodata 106752 106752 0 0.0
text 791520 791520 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1200292 1200292 0 0.0
bss 121613 121613 0 0.0
rodata 139600 139600 0 0.0
text 788600 788600 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1041448 1041448 0 0.0
bss 129300 129300 0 0.0
rodata 98888 98888 0 0.0
text 765448 765448 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835696 835696 0 0.0
(read/write) 1761028 1761028 0 0.0
.bss 195020 195020 0 0.0
.data 2624 2624 0 0.0
.text 1554996 1554996 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837816 837816 0 0.0
(read/write) 1707524 1707524 0 0.0
.bss 192908 192908 0 0.0
.data 2616 2616 0 0.0
.text 1503612 1503612 0 0.0
light cy8ckit_062s2_43012 (read only) 844504 844504 0 0.0
(read/write) 1632444 1632444 0 0.0
.bss 186404 186404 0 0.0
.data 2432 2432 0 0.0
.text 1435220 1435220 0 0.0
lock cy8ckit_062s2_43012 (read only) 817384 817384 0 0.0
(read/write) 1659348 1659348 0 0.0
.bss 213500 213500 0 0.0
.data 2456 2456 0 0.0
.text 1435004 1435004 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1117960 1117960 0 0.0
.bss 101224 101224 0 0.0
.data 808 808 0 0.0
.text 630340 630340 0 0.0
lock-app qpg6105+debug (read/write) 1081936 1081936 0 0.0
.bss 97520 97520 0 0.0
.data 852 852 0 0.0
.text 594312 594312 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822594 822594 0 0.0
bss 50916 50916 0 0.0
text 614800 614800 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1090060 1090060 0 0.0
bss 100384 100384 0 0.0
text 769954 769954 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1085496 1085496 0 0.0
bss 109696 109696 0 0.0
text 754632 754632 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935944 935944 0 0.0
bss 93664 93664 0 0.0
text 647880 647880 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822830 822830 0 0.0
bss 50960 50960 0 0.0
text 615170 615170 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 980468 980468 0 0.0
bss 79004 79004 0 0.0
text 695692 695692 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1094524 1094524 0 0.0
bss 99840 99840 0 0.0
text 771006 771006 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 966552 966552 0 0.0
bss 97304 97304 0 0.0
text 648938 648938 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949880 949880 0 0.0
bss 92348 92348 0 0.0
text 664248 664248 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 881732 881732 0 0.0
bss 69032 69032 0 0.0
text 623286 623286 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 822384 822384 0 0.0
bss 57276 57276 0 0.0
text 590210 590210 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705632 705632 0 0.0
bss 73568 73568 0 0.0
text 462136 462136 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824558 824558 0 0.0
bss 51096 51096 0 0.0
text 617914 617914 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879609 879609 0 0.0
bss 60744 60744 0 0.0
text 632106 632106 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 846748 846748 0 0.0
bss 57564 57564 0 0.0
text 608676 608676 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 840948 840948 0 0.0
bss 57880 57880 0 0.0
text 602630 602630 0 0.0

@mergify mergify bot merged commit a0cc0af into project-chip:master Jan 15, 2024
57 checks passed
jamesharrow pushed a commit to jamesharrow/connectedhomeip that referenced this pull request Jan 15, 2024
…31413)

* Fix variable may be used without initialization

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>
@erwinpan1 erwinpan1 deleted the fix_chef_airpurifier_compilation_warning branch January 16, 2024 02:10
mergify bot pushed a commit that referenced this pull request Jan 18, 2024
… removed 2 attributes (#31406)

* Fix #30665 (EVSE)
- Changed to use amperage_mA, energy_mWh
- removed max on epoch_s
- removed access for operate
- removed side for events

* Fix #30665 updates to try to get further with ZAP and autogen, but still fails with some parts of regen_all

* Added ember-compatibility-functions.cpp which was missing.

* Made all types all lowercase to resolve regen_all issues.

* Fixed lint issue (trailing whitespace).

* Added Device Energy Management server.cpp, added to all-clusters-app.zap and regen_all

* Restyled by whitespace

* Restyled by clang-format

* Fixes based on similar conversations on EVSE review. Made Forecast and PowerAdjustmentCapability Nullable attributes. Added feature support.

* Added delegate class to all-clusters-app

* Changed ChipLogProgress to Error. Better handling of EnumerateCommands

* Aligned EVSE XML to same state as PR#30857 (includes SessionID being Nullable etc and in Fault Event).

* Updated Device Energy Management XML to use power_mw, energy_mwh per spec definition.

* Updated controller-clusters.zap

* regen_all.py

* Restyled by whitespace

* Regen_all after merging in changes for XML

* Fixed types to be signed=true

* Fixed 31032 - revert removal of side="server".

* regen_all.py

* Added Device Energy Management cluster back into all-clusters.zap and regen_all after merging from master.

* Compiles but doesn't work. Needs stub to instantiate class

* Fixed EnumerateCommands to allow optional ModifyForecastRequest and RequestConstraintBasedForecast commands

* Fixed InvokeCommand issues to allow optional commands.

* Improved HandleModifyForecastRequest and HandleRequestConstraintBasedForecast in sdk

* Updates to add DeviceEnergyManagement to all-clusters.

* Compiles and links

* Sync file in energy-management-app

* Updated DEM to support SetPowerAdjustmentCapability and SetForecast methods.

* Updated based on review comments. Changed Epoch to be Matter 2000 based epochs.

* Turned on commands in DEM. Added DEM cluster server to energy-management-app.

* Added more comments to Delegate to describe expected behaviour.

* Updated BUILD.gn to remove duplicated files from all-clusters-common and energy-management-common

* Aim to fix compile issues on other platforms due to logging of %d

* Restyled by gn

* Updated build files to remove duplicate copies from all-clusters-common to energy-management-common

* Fixed ESP32 include path

* Added DEM into energy-management-app - refactored main.cpp.

* Added DEM into EVSEManufacturerImpl.h

* Fix - avoid using global namespace in header file

* Restyled by gn

* Updated CMakeLists.txt to remove duplicate energy-management files.

* Added device-energy-management-server to ESP32 all-clusters CMakeLists.txt

* Removed return at end of void function.

* Added include to all-clusters-minimal in ESP32

* Removed __FUNCTION__ from logs

* Removed stray %s

* Added FeatureMap handling in sdk (not in ember)

* Removed extra chip::

* Used CHIP_ERROR_FORMAT, err.Format() mechanism

* Refactored StartTimeAdjust based on review comments.

* Removed unnecessary Write Attributes function

* Beginnings of Session handling

* Added beginnings of EVConnected,EVNotDetected,EnergyTransferStarted,EnergyTransferStopped handling. State machine is not finished. Callback to read Energy Meter added

* Added framework for EVSE Test Event triggers

* Added EnergyEvseTestEventTrigger delegates

* Restyled by whitespace

* Restyled by gn

* Added :energy-evse-test-event-trigger to public_deps to see if it resolves build errors

* Restyled by gn

* Fixed Darwin compile error - do not use else after return

* Refactored code so that the EvseManufacturer instance could be retrieved for Test Event triggers

* Started adding TC_EEVSE_2_2.py

* Updated TC_EEVSE_2_2.py to support test events. Still needs to handle reading of Logged Events and verifying they are correct.

* Refactored Handling of TestEvents to allow clear, and better error handling.

* Refactored state handling by decomposing into state machine events where similar functions are performed based on state transition. Fixed TC chargingEnabledUntil cast to int. Note gets to step 6e

* Fixed step 6e caused by not setting the cable limit / maxHardwareCurrentLimit in test events

* Added comment to clarify purpose and definition of test eventtrigger field values.

* Fixed several bugs in test script

* Made SetChargingEnabledUntil take a nullable type.

* Removed Reference to step 5c, and moved reading of SessionID to step 4b.
More TC_EEVSE_2_2 bug fixes. Added event checking. Still fails at step 14.
Does not have enable timeout timer implemented

* Fixed issue with not detecting 2nd plug in event, and session ID not incrementing. Now test case passes all the way.

* Restyled by isort

* Made some attributes persisted per spec.

* Added attributes to zcl.json to mark them as implemented in attributeAccessInterfaceAttributes

* Ran regen_all.py after changing zcl.json

* Fixed incorrect type - not picked up by all compilers.

* Re-ran bootstrap, and then regen-all - to pick up more zap generated fixes

* Added provisional handling for Faults

* Added new test event triggers to help test Fault and Diagnostics

* Added TC_EEVSE_2_4

* Fix lint issue - unused datetime modules.

* Committed suggested change to comment

* Added TC_EEVSE_2_5.py to support DiagnosticsCommand testing. Also changed the SupplyState reverting to Disabled once diagnostics is complete to match the spec.

* Created a helper EEVSE base class to avoid repetition in the different test cases.

* Restyled by isort

* Fixed Lint issues

* Revamped TC_EEVSE_2_5 to match spec behaviour (cannot start diagnostics unless Disabled). Also removed hard-coded endpoint ids in Utils

* Implemented timer to disable the EVSE automatically.

* Added documentation to cover concern about long-lived bytespan in enableKey

* Fixed Lint and build issues on other platforms

* Restyled by isort

* Implemented some of the feedback on PR

* Refactored HwSetState to use nested switch statements to be clear that all enums are caught.

* Fixed error messages

* Test scripts: Removed hardcoded endpoint 1 (use --endpoint 1 in args), allowed the enableKey to be passed in using --hex-arg enableKey:000102030405060708090a0b0c0d0e0f

* Made enum class for callbacks and improved documentation comments based on feedback.

* Fixed another python lint issue.

* Updated README.md with help on how to build for test event triggers, using chip-repl and python testing.

* Tweaks to README.md to avoid Myst syntax highlighting issues.

* Improved error logging around GetEpochTS()

* Made main use std::unique_ptr instead of using new/delete per PR comments. Also moved GetEVSEManufacturer declaration to header file.

* Fixing MISSPELL issues in README.md

* Small change missed in main.cpp missed in unique_ptr change.

* Changed all-clusters app stubs to use unique_ptr style instead of new/delete.

* Removed unhelpful comment

* Restyled by whitespace

* Fixes #31061 Updated DEVICE_TYPE to 0x050C now this has been allocated

* Fixes #31061 Updated DEVICE_TYPE to 0x050C now this has been allocated

* Updated energy-evse-cluster.xml to use latest EnergyEVSE.adoc which removes numberOfWeeklyTargets, numberOfDailyTargets, and adds new ChargingTargetScheduleStruct in Get/Set/Clear Target commands

* Removed min/max for Randomisation window due to ZAP bug that doesn't allow more than 2 bytes.

* Added missing new Java files

* Changed DayOfWeekforSequence -> DayOfWeekForSequence in XML. Regen-all

* Python testing: Add helper functions for marking steps as skipped in the TH (#31373)

* Add two new helper functions for marking steps skipped

* python testing: Add helper functions for skipped steps

* Do not use gen_config.h directly. (#31401)

* Do not use gen_config.h directly.

Apparently the right file is config.h, which includes the gen file.

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>

* Bump third_party/ot-br-posix/repo from `657e775` to `58822dc` (#31420)

Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `657e775` to `58822dc`.
- [Release notes](https://github.com/openthread/ot-br-posix/releases)
- [Commits](openthread/ot-br-posix@657e775...58822dc)

---
updated-dependencies:
- dependency-name: third_party/ot-br-posix/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump third_party/imgui/repo from `240ab58` to `6228c2e` (#31418)

Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `240ab58` to `6228c2e`.
- [Release notes](https://github.com/ocornut/imgui/releases)
- [Commits](ocornut/imgui@240ab58...6228c2e)

---
updated-dependencies:
- dependency-name: third_party/imgui/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump third_party/pigweed/repo from `cbbc73d` to `9640cde` (#31414)

Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `cbbc73d` to `9640cde`.
- [Commits](google/pigweed@cbbc73d...9640cde)

---
updated-dependencies:
- dependency-name: third_party/pigweed/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [Chef] Fix variable may be used without initialization (#31413)

* Fix variable may be used without initialization

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>

* Bump third_party/nanopb/repo from `cf26d28` to `423c03b` (#31421)

Bumps [third_party/nanopb/repo](https://github.com/nanopb/nanopb) from `cf26d28` to `423c03b`.
- [Commits](nanopb/nanopb@cf26d28...423c03b)

---
updated-dependencies:
- dependency-name: third_party/nanopb/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Test_TC_DGWIFI_2_1 WiFiVersion enum8 maxValue should be 6 (#31364)

* WiFiVersion enum8 maxValue should be 6

Matter Spec 1.2 Section 11.14.5.2. WiFiVersionEnum Type
ranges from 0 (802.11a) to 6 (802.11ah)

* Update command.h darwin zap-genersated WiFiVersion

* Handle energy type naming in data model xml handlers (#31344)

* Correct case names for enerty types in data model handlers.

* Add unit test

* restyle

* [nrfconnect] Switch unit tests to PSA crypto (#31408)

* [nrfconnect] Switch unit tests to PSA crypto

Switch nRF Connect unit tests to PSA crypto backend since
legacy mbedTLS is already tested on many platforms.

Additionally, clean the configuration of nRF Connect test
runner by removing some redundant configurations and better
grouping the items.

* Restyled by gn

---------

Co-authored-by: Restyled.io <[email protected]>

* Bump third_party/libwebsockets/repo from `f18fc23` to `49bfef2` (#31417)

Bumps [third_party/libwebsockets/repo](https://github.com/warmcat/libwebsockets) from `f18fc23` to `49bfef2`.
- [Commits](warmcat/libwebsockets@f18fc23...49bfef2)

---
updated-dependencies:
- dependency-name: third_party/libwebsockets/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add initial valve cluster implementation (#30562)

* added first version of valve configuration and control cluster

* added first version of boolean sensor configuration cluster XML and
 updated event descriptions for valve config and control cluster

* fixed wrong attribute name

Co-authored-by: Boris Zbarsky <[email protected]>

* fixed typo

Co-authored-by: Boris Zbarsky <[email protected]>

* removed StartUpLevel attribute and added optional OpenDuration command args

* use allocated cluster ID

* added code generating bits

* added new device types

* restyle

* added BooleanSensorConfiguration and ValveConfigurationAndControl clusters
 to all-clusters-app

* - fixed wrong attribute name caused by copy paste
- min/max is not allowed for attributes with size larger than 2 bytes

* regenerate all

* added initial implementation for the new clusters

* apply provisional property to new clusters

* fixed typo

Co-authored-by: Boris Zbarsky <[email protected]>

* removed empty implementation, removed clusters from all-clusters-app

* added a skeleton implementation

* fixed typo

Co-authored-by: Boris Zbarsky <[email protected]>

* fixed typos and regen all

* fixes based on PR comments

* added descriptor cluster to valve device type

* updated zap and idl files to fixed typo in command name

* close to final implementation, needs careful going through

* activate alarms if enabled, added API for sensor fault event, clean-up

* WIP

* Implemented open command

* finalize initial implementation

* added all-clusters-app example for valve device

* added null checking

* added attribute changed callback and fixed some bugs after testing

* did a regen and fixed rebase issue

* restyle

* added missed generated code by previous commits

* attempt to fix failing CI

* restyle

* add a missed zap gen output

* removed redundant return

* update valve configuration and control cluster according to latest spec

* remove boolean sensor config cluster implementation and into a separate PR

* DefaultOpenDuration is writable and updated device type name to Water Valve

* updated code to latest spec

* changed RemainingDuration to be handled by AttributeAccessInterface

* WIP RemainingDuration

* moved domain to be the first element

* update to the latest spec changes, removed attribute changed callback,
 handle remainingduration in AAI

* added LevelStep attribute in all-clusters-app

* removed unused code

* set default null values in ZAP

* Added transition handling in Delegate

* Reworked AutoTimeClose handling in SetValveLevel

* Changed include

* added mechanism to signal UTCTime change in timesync cluster

---------

Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: fessehat <[email protected]>
Co-authored-by: René Josefsen <[email protected]>
Co-authored-by: René Josefsen <[email protected]>

* Bump third_party/mbedtls/repo from `ffb18d2` to `56fd26c` (#31422)

Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `ffb18d2` to `56fd26c`.
- [Release notes](https://github.com/ARMmbed/mbedtls/releases)
- [Commits](Mbed-TLS/mbedtls@ffb18d2...56fd26c)

---
updated-dependencies:
- dependency-name: third_party/mbedtls/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [K32W0] SDK 2.6.13 additional changes (#31382)

* [K32W] Fix a corner case when switching the TLV processors

After the current block is processed, if the block size is 0, it means
that the processed data was a multiple of received BDX block size (e.g.
8 blocks of 1024 bytes were transferred). After state for selecting next
processor is reset, a request for fetching next data must be sent.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W] Make Validate public

Change access modifier of Validate to public, to be used by K32W0
for factory data validation after factory data OTA.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] Add CRC validation during factory data OTA

After factory data is copied into internal flash, call Validate to ensure
the CRC of factory data matches the CRC in the header. If the check fails,
then OTA is aborted and factory data is restored to previous version.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] Add additional check for provider pointer

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] Change root node revision to 2

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W] Expose SearchForId in factory data provider public API

Removed additional checks on tags with the assumption that factory data is
strictly checked at manufacturing time.
Applications can now use the public API to search the factory data section
for an id, e.g. in the case of custom factory data provider, where the app
has additional factory data information besides the default one.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] Refactor custom factory data provider

The example now leverages the actual factory data provider API to
search the factory data section for some custom ids.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W] Add platform support for Product Appearance

Implement GetProductFinish and GetProductPrimaryColor defined in DeviceInstanceInfoProvider.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W] Remove maxLengths array

This array was used to store the maximum length of factory data fields.
It's no longer used, with the assumption that the factory data is strictly
checked in manufacturing.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] Remove usage of maxLength array

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] remove unused code in LowPowerHook.cpp file

* [K32W0] use Encoding::HexToBytes to parse the ota encryption key

* [K32W0] remove extra PWR_DisallowDeviceToSleep() which will cause unsleep after commissioning

* [K32W] Revert removal of disallow to sleep and enclose it in specific tag

Only call disallow to sleep when the platform is K32W1.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] Update reference app readme files

This is a minor improvement to the building instructions.
It aims to clarify the usage of west SDK or package SDK.

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W0] Fix ICD parameters

Name of the ICD parameters were updated according with the latest stack updates.

Signed-off-by: Andrei Menzopol <[email protected]>

* Restyled by clang-format

* Restyled by gn

* Restyled by prettier-markdown

* [K32W0] Fix gn check error

Signed-off-by: marius-alex-tache <[email protected]>

* Restyled by gn

* [K32W1] Fix gn check errors

Signed-off-by: marius-alex-tache <[email protected]>

* Restyled by gn

* [K32W1] Fix another gn error

Signed-off-by: marius-alex-tache <[email protected]>

* Restyled by gn

* [K32W] Send a report before resetting the device during OTA

State-transition event from Downloading to Applying was not successfully sent
to a subscriber during OTA because the device would reset before actually sending
the ReportData message.

Added an explicit call to handle server shutting down, which will sync send all events.

Signed-off-by: marius-alex-tache <[email protected]>

* Restyled by clang-format

* [K32W0] Remove deprecated dependency

Signed-off-by: marius-alex-tache <[email protected]>

* [K32W1] Remove deprecated dependency

Signed-off-by: marius-alex-tache <[email protected]>

* Restyled by gn

---------

Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
Co-authored-by: Damien Vagner <[email protected]>
Co-authored-by: tanyue518 <[email protected]>
Co-authored-by: Ethan Tan <[email protected]>
Co-authored-by: Andrei Menzopol <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

* For CFFI in chip-repl, remove variadic arguments (#31159)

* Updated energy-evse-cluster.xml to use latest EnergyEVSE.adoc which removes numberOfWeeklyTargets, numberOfDailyTargets, and adds new ChargingTargetScheduleStruct in Get/Set/Clear Target commands

* Removed optional=true in xml for DayOfWeekForSequence & ChargingTargets in ChargingTargetScheduleStruct

* Small correction to description in test case.

* Updated energy-evse-cluster.xml to use latest EnergyEVSE.adoc which removes numberOfWeeklyTargets, numberOfDailyTargets, and adds new ChargingTargetScheduleStruct in Get/Set/Clear Target commands

* Removed min/max for Randomisation window due to ZAP bug that doesn't allow more than 2 bytes.

* Added missing new Java files

* Changed DayOfWeekforSequence -> DayOfWeekForSequence in XML. Regen-all

* Updated energy-evse-cluster.xml to use latest EnergyEVSE.adoc which removes numberOfWeeklyTargets, numberOfDailyTargets, and adds new ChargingTargetScheduleStruct in Get/Set/Clear Target commands

* Removed optional=true in xml for DayOfWeekForSequence & ChargingTargets in ChargingTargetScheduleStruct

* Update examples/energy-management-app/energy-management-common/include/EnergyEvseDelegateImpl.h

Co-authored-by: Boris Zbarsky <[email protected]>

* Touched file to retrigger restyled job

* Removed whitespace which was added to trigger restyled to rerun

* Removed potentially unsafe code before merging into PR #30957

* Renamed variable and replaced auto with type so it is clearer to reader.

* Restyled by clang-format

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: C Freeman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Erwin Pan <[email protected]>
Co-authored-by: simonhmorris1 <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Damian Królik <[email protected]>
Co-authored-by: fesseha-eve <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: fessehat <[email protected]>
Co-authored-by: René Josefsen <[email protected]>
Co-authored-by: René Josefsen <[email protected]>
Co-authored-by: Marius Tache <[email protected]>
Co-authored-by: Damien Vagner <[email protected]>
Co-authored-by: tanyue518 <[email protected]>
Co-authored-by: Ethan Tan <[email protected]>
Co-authored-by: Andrei Menzopol <[email protected]>
Co-authored-by: Terence Hampson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants