-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Operating Mode #31376
Merged
yunhanw-google
merged 7 commits into
project-chip:master
from
lpbeliveau-silabs:feature/icd_operating_mode
Jan 12, 2024
Merged
[ICD] Operating Mode #31376
yunhanw-google
merged 7 commits into
project-chip:master
from
lpbeliveau-silabs:feature/icd_operating_mode
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
January 11, 2024 21:49
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 11, 2024 21:49
PR #31376: Size comparison from 11d4c3a to 17a4f0f Increases (17 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/icd-management-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/icd-management-cluster.xml
Outdated
Show resolved
Hide resolved
PR #31376: Size comparison from 11d4c3a to ecf9c58 Full report (11 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect)
|
lpbeliveau-silabs
force-pushed
the
feature/icd_operating_mode
branch
from
January 12, 2024 17:18
ecf9c58
to
6dc1335
Compare
PR #31376: Size comparison from 643b840 to 6dc1335 Increases (18 builds for efr32, k32w, linux, qpg, telink)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/icd_operating_mode
branch
from
January 12, 2024 19:56
2fd75be
to
2981a56
Compare
jmartinez-silabs
approved these changes
Jan 12, 2024
PR #31376: Size comparison from 74f0e06 to 2981a56 Increases above 0.2%:
Increases (18 builds for efr32, k32w, linux, qpg, telink)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Operating Mode attribute to the xml and in the server code