-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for diagnostic logs server cluster with BDX support #31198
Merged
woody-apple
merged 12 commits into
project-chip:master
from
vivien-apple:DiagnosticLogs_UpdateServerImplementation
Jan 22, 2024
Merged
Add support for diagnostic logs server cluster with BDX support #31198
woody-apple
merged 12 commits into
project-chip:master
from
vivien-apple:DiagnosticLogs_UpdateServerImplementation
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tools
examples
scripts
darwin
lib
controller
app
tests
core
protocols
labels
Dec 28, 2023
vivien-apple
changed the title
Add support for diagnostic logs server cluster and add the log provider delegate to all-clusters-app
Add support for diagnostic logs server cluster with BDX support
Dec 28, 2023
vivien-apple
force-pushed
the
DiagnosticLogs_UpdateServerImplementation
branch
from
December 28, 2023 13:15
8b0eef6
to
6e660d7
Compare
PR #31198: Size comparison from 4855f58 to 6e660d7 Increases (3 builds for cc32xx, mbed)
Full report (3 builds for cc32xx, mbed)
|
vivien-apple
force-pushed
the
DiagnosticLogs_UpdateServerImplementation
branch
from
December 28, 2023 13:28
6e660d7
to
5751f71
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248 and
hicklin
December 28, 2023 13:29
This was referenced Jan 18, 2024
Open
vivien-apple
force-pushed
the
DiagnosticLogs_UpdateServerImplementation
branch
2 times, most recently
from
January 18, 2024 18:55
a38ddfb
to
fa72313
Compare
examples/chip-tool/commands/common/BDXDiagnosticLogsServerDelegate.cpp
Outdated
Show resolved
Hide resolved
vivien-apple
force-pushed
the
DiagnosticLogs_UpdateServerImplementation
branch
2 times, most recently
from
January 19, 2024 17:13
14c375f
to
57ab3d7
Compare
bzbarsky-apple
approved these changes
Jan 19, 2024
vivien-apple
force-pushed
the
DiagnosticLogs_UpdateServerImplementation
branch
from
January 19, 2024 18:13
57ab3d7
to
93c15f5
Compare
vivien-apple
force-pushed
the
DiagnosticLogs_UpdateServerImplementation
branch
from
January 19, 2024 21:11
93c15f5
to
780606e
Compare
PR #31198: Size comparison from 0f31a82 to 780606e Increases above 0.2%:
Increases (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for efr32, linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…teractive mode to make sure it does not crash when using BDX
…ecoder/bdx/Decoder.cpp
Make sure to reset the exchange context in the TransferFacilitator to make it possible to reuse it for a new exchange
vivien-apple
force-pushed
the
DiagnosticLogs_UpdateServerImplementation
branch
from
January 22, 2024 08:37
780606e
to
d28d338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SDK does not implement the diagnostic logs server properly.
This PR is made of multiple commits that can be grouped like the following:
Some fixes to get the YAML tests to not crash with BDX
Some code to log BDX messages using the tracing implementation so it looks consistent with the other logs
examples/common/tracing/decoder/bdx/Decoder.cpp
A basic (without BDX) server side implementation of the Diagnostic logs cluster with some YAML tests
A BDX server side implementation of the Diagnostic logs cluster with some YAML tests and a chip-tool implementation
A Matter.framework wrapper with a darwin-franework-tool implementation
Fixes: #29829
This PR is an alternate version of #29976 and replace it if it lands. If needed and if that makes it easier this PR can be spliced into multiple PRs more or less based on the groups presented previously.