-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce that P256Keypair is not copyable #31118
Conversation
PR #31118: Size comparison from 13fd61d to a55c241 Decreases (8 builds for cc32xx, mbed, nrfconnect, qpg)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
PR #31118: Size comparison from 13fd61d to 4992780 Decreases (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
4992780
to
611937f
Compare
PR #31118: Size comparison from 13fd61d to 611937f Increases (2 builds for linux)
Decreases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, assuming @tcarmelveilleux is ok with it.
P256PublicKey IS copyable (and actually copied in practice), so prevent sliced copies by making it final. Also use = default instead of empty constructor / destructor bodies.
611937f
to
0fbe89a
Compare
Darwin changes landed separately in #31141 |
PR #31118: Size comparison from b7e3bc0 to 0fbe89a Increases (2 builds for linux)
Decreases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Enforce that
P256Keypair
is not copyable.P256PublicKey
IS copyable (and actually copied in practice), so preventsliced copies by making it final. Also use
= default
instead of empty constructor / destructor bodies.