Make wholesale replacement of lwIP more straightforward #31025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of everyone directly adjusting the definintions in src/lwip, which only works in-tree, clean up the dependencies so that overriding lwip_root works cleanly (ie, without introducing dependencies on $chip_root/src/lwip). See docs in third_party/lwip/BUILD.gn
mspang
force-pushed
the
for-chip/lwip_target
branch
from
dfe4fe7 to
e7cd41b
Compare
|
PR #31025: Size comparison from 1f3bcbc to e7cd41b Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
If multiple libraries compile src/lwip/freertos/sys_arch.c, this causes problems from having the same .o file name. Use different library names to make sure this does not happen.
|
PR #31025: Size comparison from 1f3bcbc to 3c815b8 Increases (1 build for linux)
Decreases (1 build for linux)
Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #31025: Size comparison from 1f3bcbc to 24d58f3 Increases (2 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
woody-apple
approved these changes
Dec 15, 2023
tcarmelveilleux
approved these changes
Dec 17, 2023
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
…#31025) * Make wholesale replacement of lwIP more straightforward Instead of everyone directly adjusting the definintions in src/lwip, which only works in-tree, clean up the dependencies so that overriding lwip_root works cleanly (ie, without introducing dependencies on $chip_root/src/lwip). See docs in third_party/lwip/BUILD.gn * Fix use of vendored lwip from EFR32 builds * Fix potential .o file naming conflicts If multiple libraries compile src/lwip/freertos/sys_arch.c, this causes problems from having the same .o file name. Use different library names to make sure this does not happen. * Fixups for genio-lighting-app build * Clarify ways to set lwip_root * Restyled by gn --------- Co-authored-by: Restyled.io <[email protected]>
tobiasgraf
pushed a commit
to boschglobal/connectedhomeip
that referenced
this pull request
Feb 28, 2024
…#31025) * Make wholesale replacement of lwIP more straightforward Instead of everyone directly adjusting the definintions in src/lwip, which only works in-tree, clean up the dependencies so that overriding lwip_root works cleanly (ie, without introducing dependencies on $chip_root/src/lwip). See docs in third_party/lwip/BUILD.gn * Fix use of vendored lwip from EFR32 builds * Fix potential .o file naming conflicts If multiple libraries compile src/lwip/freertos/sys_arch.c, this causes problems from having the same .o file name. Use different library names to make sure this does not happen. * Fixups for genio-lighting-app build * Clarify ways to set lwip_root * Restyled by gn --------- Co-authored-by: Restyled.io <[email protected]> (cherry picked from commit b58488e)
Matter-mt793x
pushed a commit
to Matter-mt793x/connectedhomeip
that referenced
this pull request
Apr 30, 2024
…#31025) * Make wholesale replacement of lwIP more straightforward Instead of everyone directly adjusting the definintions in src/lwip, which only works in-tree, clean up the dependencies so that overriding lwip_root works cleanly (ie, without introducing dependencies on $chip_root/src/lwip). See docs in third_party/lwip/BUILD.gn * Fix use of vendored lwip from EFR32 builds * Fix potential .o file naming conflicts If multiple libraries compile src/lwip/freertos/sys_arch.c, this causes problems from having the same .o file name. Use different library names to make sure this does not happen. * Fixups for genio-lighting-app build * Clarify ways to set lwip_root * Restyled by gn --------- Co-authored-by: Restyled.io <[email protected]>
Matter-mt793x
added a commit
to Matter-mt793x/connectedhomeip
that referenced
this pull request
Apr 30, 2024
1. Due to commit project-chip#31025 adjust the pathes of src/lwip. include the correct pathes to build system. 2. Since GCC has been upgraded to v13.2, fixed some compatibility issues on Genio platform settings.
Matter-mt793x
pushed a commit
to Matter-mt793x/connectedhomeip
that referenced
this pull request
Apr 30, 2024
…#31025) * Make wholesale replacement of lwIP more straightforward Instead of everyone directly adjusting the definintions in src/lwip, which only works in-tree, clean up the dependencies so that overriding lwip_root works cleanly (ie, without introducing dependencies on $chip_root/src/lwip). See docs in third_party/lwip/BUILD.gn * Fix use of vendored lwip from EFR32 builds * Fix potential .o file naming conflicts If multiple libraries compile src/lwip/freertos/sys_arch.c, this causes problems from having the same .o file name. Use different library names to make sure this does not happen. * Fixups for genio-lighting-app build * Clarify ways to set lwip_root * Restyled by gn --------- Co-authored-by: Restyled.io <[email protected]>
Matter-mt793x
added a commit
to Matter-mt793x/connectedhomeip
that referenced
this pull request
Apr 30, 2024
1. Due to commit project-chip#31025 adjust the pathes of src/lwip. include the correct pathes to build system. 2. Since GCC has been upgraded to v13.2, fixed some compatibility issues on Genio platform settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of everyone directly adjusting the definintions in src/lwip, which only works in-tree, clean up the dependencies so that overriding lwip_root works cleanly (ie, without introducing dependencies on $chip_root/src/lwip).
See docs in third_party/lwip/BUILD.gn