-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TimeSnapshotResponse command types/names to match spec updates #31018
Merged
mergify
merged 2 commits into
project-chip:master
from
tcarmelveilleux:fix-time-snapshot-xml
Dec 14, 2023
Merged
Fix TimeSnapshotResponse command types/names to match spec updates #31018
mergify
merged 2 commits into
project-chip:master
from
tcarmelveilleux:fix-time-snapshot-xml
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
December 14, 2023 19:34
pullapprove
bot
requested review from
tecimovic,
yufengwangca,
tobiasgraf,
yunhanw-google,
tehampson,
tima-q,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
December 14, 2023 19:34
tcarmelveilleux
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Dec 14, 2023
mkardous-silabs
approved these changes
Dec 14, 2023
tcarmelveilleux
force-pushed
the
fix-time-snapshot-xml
branch
from
December 14, 2023 19:37
ccba15f
to
d2139ba
Compare
andy31415
approved these changes
Dec 14, 2023
PR #31018: Size comparison from d8a8a8a to d2139ba Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
TCR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip-protocol-compatibility
since the wire format changes were done prior to any usage (new 1.3 feature) and were caused by the process of implementation finding issues.Issue #30990
Issue #30096