-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Support commissioning with code on network only #31000
Merged
mergify
merged 2 commits into
project-chip:master
from
agners:python-support-commission-with-code-on-network-only
Dec 14, 2023
Merged
[Python] Support commissioning with code on network only #31000
mergify
merged 2 commits into
project-chip:master
from
agners:python-support-commission-with-code-on-network-only
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional parameter to support commissioning on network only. This is useful when a manual pairing code is given and we know the device is on the network already.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
December 14, 2023 00:28
pullapprove
bot
requested review from
rcasallas-silabs,
wiba-nordic,
robszewczyk,
woody-apple,
saurabhst,
younghak-hwang,
selissia,
yufengwangca,
sharadb-amazon,
yunhanw-google,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon and
vivien-apple
December 14, 2023 00:28
PR #31000: Size comparison from 48891d5 to 36240c0 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Dec 14, 2023
PR #31000: Size comparison from 48891d5 to e88702b Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional parameter to support commissioning on network only. This is useful when a manual pairing code is given and we know the device is on the network already.