-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller] merge ReadCommissioningInfo2 into ReadCommissioningInfo #30978
Merged
yunhanw-google
merged 7 commits into
project-chip:master
from
erjiaqing:controller/merge-read-commissioning-info-stages
Dec 14, 2023
Merged
[controller] merge ReadCommissioningInfo2 into ReadCommissioningInfo #30978
yunhanw-google
merged 7 commits into
project-chip:master
from
erjiaqing:controller/merge-read-commissioning-info-stages
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs and
mspang
December 13, 2023 13:41
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
December 13, 2023 13:41
erjiaqing
force-pushed
the
controller/merge-read-commissioning-info-stages
branch
from
December 13, 2023 13:46
886fc5e
to
0765d32
Compare
PR #30978: Size comparison from d389403 to 0765d32 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 13, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
yunhanw-google
force-pushed
the
controller/merge-read-commissioning-info-stages
branch
from
December 13, 2023 20:33
6a23307
to
d65e55b
Compare
yunhanw-google
approved these changes
Dec 13, 2023
PR #30978: Size comparison from b6e465a to d65e55b Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30978: Size comparison from b6e465a to 9af75bf Increases above 0.2%:
Increases (5 builds for linux, telink)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We want to read
UserActiveModeTriggerInstruction
andUserActiveModeTriggerHint
during commissioning, however, currently, the ReadCommissioningInfo is already reading 9 attributes (upper bound required by the spec).Having another OnReadCommissioningInfo is not elegant for me. As it seems to be OK that the mAttributeCache can live longer than a single read transactions, I made it report the commissioning info from two read transactions together.
Changes to
ParseCommissioningInfo*()
is expected to be trivial. This can be observed from git diff.Old lifespan:
New lifespan: