-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rvc example to handel new pause compatible states #30963
Merged
mergify
merged 13 commits into
project-chip:master
from
dysonltd:update_rvc_example_to_handel_new_pause_compatible_states
Dec 18, 2023
Merged
Update rvc example to handel new pause compatible states #30963
mergify
merged 13 commits into
project-chip:master
from
dysonltd:update_rvc_example_to_handel_new_pause_compatible_states
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue and Resume commands for the new pause and resume compatible states.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
December 12, 2023 17:10
PR #30963: Size comparison from 696f56a to 88a1006 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
plauric
approved these changes
Dec 12, 2023
andy31415
reviewed
Dec 12, 2023
andy31415
reviewed
Dec 12, 2023
…new_pause_compatible_states
PR #30963: Size comparison from d389403 to c3ee166 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ands handle methods. Renamed variable for clarity. Removed unnecessary temp hold of pause state.
…s' of github.com:dysonltd/connectedhomeip into update_rvc_example_to_handel_new_pause_compatible_states
PR #30963: Size comparison from d389403 to 1ec907c Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Dec 13, 2023
andy31415
reviewed
Dec 13, 2023
andy31415
reviewed
Dec 13, 2023
andy31415
reviewed
Dec 13, 2023
andy31415
reviewed
Dec 13, 2023
…state that we will resume to as we cannot know the state that the device will resume to when the pause command is handled.
PR #30963: Size comparison from d389403 to 3d8a267 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30963: Size comparison from 02683ee to 9902a09 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Dec 14, 2023
PR #30963: Size comparison from 7cbac91 to a43106a Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
…p#30963) * Updated the RVC example app to appropriatly handel the RvcOpState Pasue and Resume commands for the new pause and resume compatible states. * Updated the RVC example app's state machine diagram. * Restyled by clang-format * Added some clarifying comments to the RvcDevice pause and resume commands handle methods. Renamed variable for clarity. Removed unnecessary temp hold of pause state. * Restyled by clang-format * Changed the naming to note the state that was paused rather than the state that we will resume to as we cannot know the state that the device will resume to when the pause command is handled. * Clarified comments following reviews. * Modified the resume callback logic to be more concise. * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: chrismapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30796.
Updates the RVC example app to handle the RvcOperationalState's Pause and Resume commands for the new pause and resume-compatible states.
Updates the RVC example app's state machine diagram.