-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ZAP generation check do a clean of java folders first #30956
Merged
andy31415
merged 3 commits into
project-chip:master
from
andy31415:java_clean_zap_check
Dec 12, 2023
Merged
Make ZAP generation check do a clean of java folders first #30956
andy31415
merged 3 commits into
project-chip:master
from
andy31415:java_clean_zap_check
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30956: Size comparison from 9d08b73 to da84d5b Full report (5 builds for cc32xx, mbed, qpg)
|
PR #30956: Size comparison from 9d08b73 to 3ac4f26 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Dec 12, 2023
fessehaeve
approved these changes
Dec 12, 2023
tcarmelveilleux
approved these changes
Dec 12, 2023
Thanks! |
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 12, 2023
…hip#30956) * Clean java before zap check * Remove obsolete file * One more file removed --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because java splits files per struct/cluster, if we ever rename or remove things, we may end up with obsolete
files in this folder.
Ensure a fresh regen on checks, so anything obsolete is forced to be removed.