-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update valve configuration and control cluster XML according to latest spec #30955
Update valve configuration and control cluster XML according to latest spec #30955
Conversation
PR #30955: Size comparison from cce6c24 to ae68cd1 Increases (42 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (3 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…config-control-cluster-xml
PR #30955: Size comparison from d389403 to d4a48ee Increases (42 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (3 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/valve-configuration-and-control-cluster.xml
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/valve-configuration-and-control-cluster.xml
Show resolved
Hide resolved
…config-control-cluster-xml
PR #30955: Size comparison from 02683ee to 3f9664f Increases (42 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (3 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified against a new scrape of the spec, have the following diff:
< cluster ValveConfigurationAndControl = 129 {
provisional cluster ValveConfigurationAndControl = 129 {
5a6,9
enum StatusCodeEnum : enum8 {
kFailureDueToFault = 2;
}
17c21
< bitmap ValveFaultBitmap : bitmap8 {
bitmap ValveFaultBitmap : bitmap16 {
Here, all the differences are on the scraper side - the scrape of the ValveFaultBitmap is incorrect - bitmap16 is correct here and in the spec, scrape doesn't include the status or provisional. TL;DR, new XML appears to match spec, it's good.
src/app/zap-templates/zcl/data-model/chip/valve-configuration-and-control-cluster.xml
Show resolved
Hide resolved
…config-control-cluster-xml
PR #30955: Size comparison from 75113fc to 5efa6c7 Increases (41 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (2 builds for linux)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…config-control-cluster-xml
PR #30955: Size comparison from e49c56d to 23e4b3b Increases (42 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (3 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30955: Size comparison from e49c56d to 1d5ee7e Increases (42 builds for cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (3 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
keeps XML up to date with spec fixes #30897