-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ICDClientStorage #30931
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/improve_icd_client_storage
Dec 15, 2023
Merged
Improve ICDClientStorage #30931
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/improve_icd_client_storage
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
December 11, 2023 19:00
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
December 11, 2023 19:00
PR #30931: Size comparison from f08a90e to df3021d Full report (5 builds for cc32xx, mbed, qpg)
|
yunhanw-google
force-pushed
the
feature/improve_icd_client_storage
branch
from
December 11, 2023 19:24
df3021d
to
d86a32f
Compare
PR #30931: Size comparison from f08a90e to d86a32f Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@yunhanw-google in the comments you link to the PR itself with Fixes, is that intended? |
mkardous-silabs
approved these changes
Dec 12, 2023
thanks, updated. |
yunhanw-google
force-pushed
the
feature/improve_icd_client_storage
branch
from
December 13, 2023 15:45
d86a32f
to
d82971f
Compare
PR #30931: Size comparison from a9ad2c4 to d82971f Increases (1 build for linux)
Decreases (2 builds for linux)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/improve_icd_client_storage
branch
from
December 13, 2023 20:27
d82971f
to
6361cb8
Compare
PR #30931: Size comparison from b6e465a to 6361cb8 Increases (1 build for linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Dec 15, 2023
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
thivya-amazon
pushed a commit
to thivya-amazon/connectedhomeip
that referenced
this pull request
Dec 18, 2023
yunhanw-google
added a commit
that referenced
this pull request
Jan 10, 2024
* ICDHandler initialization * ICDHandler initialization * Restyled by gn * Update src/app/icd/ICDHandler.cpp Co-authored-by: Jean-Francois Penven <[email protected]> * ICDHandler initialization * ICDHandler initialization * ICDHandler initialization * Restyled by gn * ICDHandler initialization * ICDHandler initialization * Restyled by gn * ICDHandler initialization * Restyled by gn * ICDHandler initialization * ICDHandler initialization * ICDHandler initialization * ICDHandler initialization * ICDHandler initialization * Moved counter validation to DefaultICDClientStorage. * Renamed ICDHandler to CheckInHandler * Included CheckInDelegate in BUILD.gn * Restyled by gn * Added DefaultCheckInDelegate * Restyled by whitespace * Restyled by gn * Modified error codes * Updated variables * Added condition for VerifyOrReturnError * Resolve conflicts with master branch * Added CheckInHandler init in chiptool * Restyled by clang-format * Restyled by gn * Added include file * Modified the access operator * Added ICD client deps for tv-casting-app * Restyled by gn * Added unit test case for ProcessCheckInPayload * Updated doxygen comments * Addressed review comments * Addressed review comments * Addressed review comments. * Moved checkin counter validation to CheckInHandler. * Removed TestDefaultICDClientStorage from iotsdk. * Restyled by gn * add CheckInExchangeDispatch to accept unsecure check-in message * Restyled by clang-format * Removed DefaultICDClientInfoPersistentStorage.cpp. * Addressed a few review comments. * Modified a macro to make sure it is taken as a 64-bit interger. * Restyled by clang-format * Removed redundant error code CHIP_ERROR_DUPLICATE_MESSAGE * Restyled by clang-format * Modified the datatype for checkInCounter to CounterType from auto. * Added code to refresh key. * ICDHandler initialization * ICDHandler initialization * Resolve conflicts with master branch * Added CheckInHandler init in chiptool * Moved checkin counter validation to CheckInHandler. * [icd] integrate ICD management command into CHIP tool (#30863) * [icd] integrate ICD management command into CHIP tool * Delete entry on failure * Fix build * ICDHandler initialization * Added CheckInHandler init in chiptool * Fixing merge conflicts * Added OnRefreshKey callback * Restyled by gn * Modified APPDATA_LENGTh macro to inline consexpr variable. * Modified CheckInDelegate and CheckInHandler to static members in chiptool. * Return CHIP_NO_ERROR for failures in processing checkin message. * Addressed review comments * Fixed a spelling error * Moved variable definition * Reenable TestDefaultClientStorage for open iot. * Restyled by gn * Modified code to use updated API * Removed obsolete comments * Added comments * Addressed review comments * Improve ICDClientStorage (#30931) * Added const qualifier to payload * Return CHIP_NO_ERROR for duplicate check in message and log error. * Return CHIP_NO_ERROR on duplicate checkin messages * Added OnRefreshKeyRetrieve and addressed review comments * Update src/lib/core/CHIPError.h Co-authored-by: mkardous-silabs <[email protected]> * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Added a temporary suppression of error for including <unordered_map> * Added a comment to suppress Lint error * Addressed review comments * Addressed review comments * Addressed review comments. * Removed code pertaining to key refresh. Will be a separate PR. * Added a link to an issue --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Jean-Francois Penven <[email protected]> Co-authored-by: yunhanw <[email protected]> Co-authored-by: Song GUO <[email protected]> Co-authored-by: mkardous-silabs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Move IterateICDClientInfo from ICDClientStorage to DefaultICDClientStorage
--Move DeleteAllEntries from ICDClientStorage to DefaultICDClientStorage
--Remove unused GetEntry because the justification,
[ we wanna retrieve the UserActiveModeTriggerHint and instruction from persistent storage", is not valid now.
--Update RemoveKey doxygen.
fixes: #30721
fixes: #30720
address comments from https://github.com/project-chip/connectedhomeip/pull/30808/files