Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Add Hmac Key handle to ICDCheckInSender to support PSA backend #30926

Merged
merged 17 commits into from
Dec 14, 2023
Merged

[ICD] Add Hmac Key handle to ICDCheckInSender to support PSA backend #30926

merged 17 commits into from
Dec 14, 2023

Conversation

mkardous-silabs
Copy link
Contributor

@mkardous-silabs mkardous-silabs commented Dec 11, 2023 •
edited
Loading

Description

PR adds the Hmac128KeyHandle to the Check-In message process to support PSA backend that does not allow the same key handle to be used for AES-CCM operations and HMAC operations.

  • Add HmacKeyHandle to Check-In message process
  • PR adds the ActiveModeThreshold value to the ICD Check-In message
  • Fixes the ICD_ENFORCE_SIT_SLOW_POLL_LIMIT configuration flag (was broken with the introduction of the ICDConfigurationData class)
  • FIxes a build issue for the Silabs Lit ICD app when matter shell is enabled

parly fixes #30926
fixes #30886

Notes to reviewers

The test don't validate the generation and parsing in depth. A follow up PR will be done to add more extensive test cases.
Follow up is necessary because the second implementation needs to be updated first.

Tests

  • Updated Tests to validate Check-In message
  • CI to validate regression
  • Manual tests to validate the ICD_ENFORCE_SIT_SLOW_POLL_LIMIT configuration

@github-actions github-actions bot added app icd Intermittently Connected Devices protocols labels Dec 11, 2023
@github-actions GitHub Actions
Copy link

PR #30926: Size comparison from a9ad2c4 to 0f2ad18

Increases (1 build for qpg)
platform target config section a9ad2c4 0f2ad18 change % change
qpg lock-app qpg6105+debug (read/write) 1080500 1080676 176 0.0
.bss 97352 97512 160 0.2
.text 592880 593056 176 0.0
Full report (3 builds for mbed, qpg)
platform target config section a9ad2c4 0f2ad18 change % change
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526040 2526040 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488724 1488724 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116748 1116748 0 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 629124 629124 0 0.0
lock-app qpg6105+debug (read/write) 1080500 1080676 176 0.0
.bss 97352 97512 160 0.2
.data 784 784 0 0.0
.text 592880 593056 176 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

PR #30926: Size comparison from a9ad2c4 to 7ed2623

Increases above 0.2%:

platform target config section a9ad2c4 7ed2623 change % change
linux shell debug .bss 62152 62312 160 0.3
telink air-quality-sensor-app tlsr9528a_retention bss 54904 55064 160 0.3
contact-sensor-app tlsr9528a_retention bss 54948 55108 160 0.3
light-switch-app-ota-shell-factory-data tlsr9528a bss 78932 79092 160 0.2
pump-app tlsr9528a bss 68924 69084 160 0.2
pump-controller-app tlsr9518adk80d bss 57160 57320 160 0.3
smoke_co_alarm-app tlsr9528a_retention bss 55084 55244 160 0.3
temperature-measurement-app-mars-ota tlsr9518adk80d bss 60636 60796 160 0.3
thermostat tlsr9518adk80d bss 57456 57616 160 0.3
window-covering tlsr9518adk80d bss 57808 57968 160 0.3
Increases (28 builds for efr32, k32w, linux, qpg, telink)
platform target config section a9ad2c4 7ed2623 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114448 1114776 328 0.0
.bss 188656 188816 160 0.1
.text 923060 923228 168 0.0
k32w contact k32w0+release (read only) 605000 605176 176 0.0
(read/write) 81736 81896 160 0.2
.bss 69584 69744 160 0.2
.text 604464 604640 176 0.0
lock k32w0+release (read only) 576104 576280 176 0.0
(read/write) 79216 79376 160 0.2
.bss 67136 67296 160 0.2
.text 575568 575744 176 0.0
linux air-purifier-app debug (read only) 2525661 2525821 160 0.0
.text 2171029 2171189 160 0.0
all-clusters-app debug (read only) 5380825 5380985 160 0.0
.text 4663587 4663747 160 0.0
all-clusters-minimal-app debug (read only) 4952889 4953049 160 0.0
.text 4447619 4447779 160 0.0
bridge-app debug (read only) 4416617 4416777 160 0.0
.text 3978931 3979091 160 0.0
chip-tool debug (read only) 11684537 11684697 160 0.0
.text 10570115 10570275 160 0.0
chip-tool-ipv6only arm64 (read only) 11412176 11412192 16 0.0
.text 10199320 10199336 16 0.0
lighting-app debug+rpc+ui (read only) 5302305 5302481 176 0.0
.text 4717219 4717395 176 0.0
lock-app debug (read only) 4501681 4501841 160 0.0
.text 4044659 4044819 160 0.0
ota-provider-app debug (read only) 4165809 4165985 176 0.0
.text 3772675 3772851 176 0.0
ota-requestor-app debug (read only) 4255313 4255473 160 0.0
.text 3853939 3854099 160 0.0
shell debug (read only) 2787865 2788025 160 0.0
(read/write) 151592 151752 160 0.1
.bss 62152 62312 160 0.3
.text 2435170 2435330 160 0.0
thermostat-no-ble arm64 (read only) 4405296 4405312 16 0.0
.text 3902648 3902664 16 0.0
tv-app debug (read only) 5384297 5384457 160 0.0
(read/write) 348896 349056 160 0.0
.bss 244384 244544 160 0.1
.text 4873635 4873795 160 0.0
tv-casting-app debug (read only) 9563961 9564121 160 0.0
(read/write) 338168 338328 160 0.0
.bss 156192 156352 160 0.1
.text 8737491 8737651 160 0.0
qpg lock-app qpg6105+debug (read/write) 1080500 1080676 176 0.0
.bss 97352 97512 160 0.2
.text 592880 593056 176 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 820830 821174 344 0.0
bss 54904 55064 160 0.3
text 613512 613692 180 0.0
contact-sensor-app tlsr9528a_retention (read/write) 821066 821410 344 0.0
bss 54948 55108 160 0.3
text 613882 614062 180 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 978216 978552 336 0.0
bss 78932 79092 160 0.2
text 694030 694212 182 0.0
lock-app-dfu tlsr9528a (read/write) 964348 964692 344 0.0
bss 97196 97356 160 0.2
text 647584 647766 182 0.0
pump-app tlsr9528a (read/write) 879864 880208 344 0.0
bss 68924 69084 160 0.2
text 621890 622072 182 0.0
pump-controller-app tlsr9518adk80d (read/write) 820476 820812 336 0.0
bss 57160 57320 160 0.3
text 588766 588948 182 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 822802 823138 336 0.0
bss 55084 55244 160 0.3
text 616626 616806 180 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 877569 877905 336 0.0
bss 60636 60796 160 0.3
text 630506 630688 182 0.0
thermostat tlsr9518adk80d (read/write) 844848 845192 344 0.0
bss 57456 57616 160 0.3
text 607232 607414 182 0.0
window-covering tlsr9518adk80d (read/write) 839124 839460 336 0.0
bss 57808 57968 160 0.3
text 601266 601448 182 0.0
Decreases (2 builds for linux)
platform target config section a9ad2c4 7ed2623 change % change
linux chip-tool-ipv6only arm64 (read/write) 570416 570400 -16 -0.0
thermostat-no-ble arm64 (read/write) 245192 245176 -16 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section a9ad2c4 7ed2623 change % change
bl602 lighting-app bl602 (read/write) 1417862 1417862 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156892 156892 0 0.0
.text 1085746 1085746 0 0.0
bl602+mfd (read/write) 1432590 1432590 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155852 155852 0 0.0
.text 1101370 1101370 0 0.0
bl602+rpc (read/write) 1465646 1465646 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164516 164516 0 0.0
.text 1117490 1117490 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1182871 1182871 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106268 106268 0 0.0
.text 955448 955448 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1194003 1194003 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105208 105208 0 0.0
.text 967512 967512 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274887 1274887 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121688 121688 0 0.0
.text 1030510 1030510 0 0.0
bl706-eth (read/write) 1002497 1002497 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99600 99600 0 0.0
.text 748344 748344 0 0.0
bl706-wifi (read/write) 1240630 1240630 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120580 120580 0 0.0
.text 975636 975636 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1152580 1152580 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100272 100272 0 0.0
.text 948574 948574 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1164032 1164032 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99212 99212 0 0.0
.text 960950 960950 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771768 771768 0 0.0
(read/write) 168100 168100 0 0.0
.bss 90436 90436 0 0.0
.data 3460 3460 0 0.0
.rodata 89520 89520 0 0.0
.text 681980 681980 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787824 787824 0 0.0
(read/write) 178328 178328 0 0.0
.bss 100612 100612 0 0.0
.data 3488 3488 0 0.0
.rodata 83768 83768 0 0.0
.text 703792 703792 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776072 776072 0 0.0
(read/write) 172784 172784 0 0.0
.bss 95068 95068 0 0.0
.data 3488 3488 0 0.0
.rodata 110376 110376 0 0.0
.text 665432 665432 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728688 728688 0 0.0
(read/write) 167096 167096 0 0.0
.bss 89208 89208 0 0.0
.data 3448 3448 0 0.0
.rodata 85096 85096 0 0.0
.text 643324 643324 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714224 714224 0 0.0
(read/write) 167276 167276 0 0.0
.bss 89392 89392 0 0.0
.data 3444 3444 0 0.0
.rodata 80928 80928 0 0.0
.text 633028 633028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566962 566962 0 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83922 83922 0 0.0
.text 480916 480916 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620298 620298 0 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105786 105786 0 0.0
.text 512388 512388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561351 561351 0 0.0
.app_xip_area 451609 451609 0 0.0
.bss 64656 64656 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543567 543567 0 0.0
.app_xip_area 429089 429089 0 0.0
.bss 69352 69352 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562335 562335 0 0.0
.app_xip_area 454049 454049 0 0.0
.bss 63272 63272 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557799 557799 0 0.0
.app_xip_area 446289 446289 0 0.0
.bss 66392 66392 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016988 1016988 0 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841680 841680 0 0.0
BRD4187C (read/write) 1100988 1100988 0 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901468 901468 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114448 1114776 328 0.0
.bss 188656 188816 160 0.1
.data 2712 2712 0 0.0
.text 923060 923228 168 0.0
window-app BRD4187C (read/write) 1135712 1135712 0 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964288 964288 0 0.0
esp32 all-clusters-app c3devkit (read only) 1137748 1137748 0 0.0
(read/write) 1671092 1671092 0 0.0
.dram0.bss 72864 72864 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241376 241376 0 0.0
.flash.text 1137748 1137748 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1182659 1182659 0 0.0
(read/write) 520292 520292 0 0.0
.dram0.bss 79512 79512 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272412 272412 0 0.0
.flash.text 1177275 1177275 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605000 605176 176 0.0
(read/write) 81736 81896 160 0.2
.bss 69584 69744 160 0.2
.data 2168 2168 0 0.0
.text 604464 604640 176 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690704 690704 0 0.0
.bss 67600 67600 0 0.0
.data 2716 2716 0 0.0
.text 576912 576912 0 0.0
light k32w0+release (read only) 594944 594944 0 0.0
(read/write) 79112 79112 0 0.0
.bss 67008 67008 0 0.0
.data 2120 2120 0 0.0
.text 594408 594408 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782516 782516 0 0.0
.bss 77276 77276 0 0.0
.data 1928 1928 0 0.0
.text 659856 659856 0 0.0
lock k32w0+release (read only) 576104 576280 176 0.0
(read/write) 79216 79376 160 0.2
.bss 67136 67296 160 0.2
.data 2096 2096 0 0.0
.text 575568 575744 176 0.0
linux air-purifier-app debug (read only) 2525661 2525821 160 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72776 72776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179272 179272 0 0.0
.text 2171029 2171189 160 0.0
all-clusters-app debug (read only) 5380825 5380985 160 0.0
(read/write) 453672 453672 0 0.0
.bss 131600 131600 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 311000 311000 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1232 1232 0 0.0
.rodata 309916 309916 0 0.0
.text 4663587 4663747 160 0.0
all-clusters-minimal-app debug (read only) 4952889 4953049 160 0.0
(read/write) 234656 234656 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95912 95912 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272845 272845 0 0.0
.text 4447619 4447779 160 0.0
bridge-app debug (read only) 4416617 4416777 160 0.0
(read/write) 215896 215896 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85232 85232 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219157 219157 0 0.0
.text 3978931 3979091 160 0.0
chip-tool debug (read only) 11684537 11684697 160 0.0
(read/write) 504048 504048 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 397616 397616 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 424489 424489 0 0.0
.text 10570115 10570275 160 0.0
chip-tool-ipv6only arm64 (read only) 11412176 11412192 16 0.0
(read/write) 570416 570400 -16 -0.0
.bss 103448 103448 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 436448 436448 0 0.0
.dynamic 512 512 0 0.0
.got 19816 19816 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 344872 344872 0 0.0
.text 10199320 10199336 16 0.0
lighting-app debug+rpc+ui (read only) 5302305 5302481 176 0.0
(read/write) 224968 224968 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93632 93632 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340340 340340 0 0.0
.text 4717219 4717395 176 0.0
lock-app debug (read only) 4501681 4501841 160 0.0
(read/write) 203616 203616 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4044659 4044819 160 0.0
ota-provider-app debug (read only) 4165809 4165985 176 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69248 69248 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3772675 3772851 176 0.0
ota-requestor-app debug (read only) 4255313 4255473 160 0.0
(read/write) 196976 196976 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72240 72240 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205141 205141 0 0.0
.text 3853939 3854099 160 0.0
shell debug (read only) 2787865 2788025 160 0.0
(read/write) 151592 151752 160 0.1
.bss 62152 62312 160 0.3
.data 768 768 0 0.0
.data.rel.ro 82864 82864 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 181792 181792 0 0.0
.text 2435170 2435330 160 0.0
thermostat-no-ble arm64 (read only) 4405296 4405312 16 0.0
(read/write) 245192 245176 -16 -0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3902648 3902664 16 0.0
tv-app debug (read only) 5384297 5384457 160 0.0
(read/write) 348896 349056 160 0.0
.bss 244384 244544 160 0.1
.data 4992 4992 0 0.0
.data.rel.ro 92216 92216 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272853 272853 0 0.0
.text 4873635 4873795 160 0.0
tv-casting-app debug (read only) 9563961 9564121 160 0.0
(read/write) 338168 338328 160 0.0
.bss 156192 156352 160 0.1
.data 2464 2464 0 0.0
.data.rel.ro 172664 172664 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 362760 362760 0 0.0
.text 8737491 8737651 160 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526040 2526040 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488724 1488724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1062456 1062456 0 0.0
bss 129375 129375 0 0.0
rodata 104392 104392 0 0.0
text 781104 781104 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1189032 1189032 0 0.0
bss 121585 121585 0 0.0
rodata 138460 138460 0 0.0
text 778648 778648 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046728 1046728 0 0.0
bss 129348 129348 0 0.0
rodata 99432 99432 0 0.0
text 770320 770320 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835880 835880 0 0.0
(read/write) 1743436 1743436 0 0.0
.bss 194988 194988 0 0.0
.data 2472 2472 0 0.0
.text 1537588 1537588 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705924 1705924 0 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502108 1502108 0 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630884 1630884 0 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433756 1433756 0 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657796 1657796 0 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433548 1433548 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116748 1116748 0 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 629124 629124 0 0.0
lock-app qpg6105+debug (read/write) 1080500 1080676 176 0.0
.bss 97352 97512 160 0.2
.data 784 784 0 0.0
.text 592880 593056 176 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820830 821174 344 0.0
bss 54904 55064 160 0.3
text 613512 613692 180 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1080344 1080344 0 0.0
bss 100388 100388 0 0.0
text 762378 762378 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083928 1083928 0 0.0
bss 109764 109764 0 0.0
text 753428 753428 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934568 934568 0 0.0
bss 94272 94272 0 0.0
text 646848 646848 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821066 821410 344 0.0
bss 54948 55108 160 0.3
text 613882 614062 180 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 978216 978552 336 0.0
bss 78932 79092 160 0.2
text 694030 694212 182 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092916 1092916 0 0.0
bss 99836 99836 0 0.0
text 769740 769740 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 964348 964692 344 0.0
bss 97196 97356 160 0.2
text 647584 647766 182 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948244 948244 0 0.0
bss 92380 92380 0 0.0
text 662956 662956 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 879864 880208 344 0.0
bss 68924 69084 160 0.2
text 621890 622072 182 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 820476 820812 336 0.0
bss 57160 57320 160 0.3
text 588766 588948 182 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705584 705584 0 0.0
bss 73588 73588 0 0.0
text 462084 462084 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822802 823138 336 0.0
bss 55084 55244 160 0.3
text 616626 616806 180 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877569 877905 336 0.0
bss 60636 60796 160 0.3
text 630506 630688 182 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844848 845192 344 0.0
bss 57456 57616 160 0.3
text 607232 607414 182 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839124 839460 336 0.0
bss 57808 57968 160 0.3
text 601266 601448 182 0.0

tcarmelveilleux
tcarmelveilleux approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conditional on fixes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

PR #30926: Size comparison from a9ad2c4 to 9610c5b

Increases above 0.2%:

platform target config section a9ad2c4 9610c5b change % change
linux chip-tool-ipv6only arm64 (read/write) 570416 573096 2680 0.5
shell debug .bss 62152 62312 160 0.3
tv-casting-app debug .init_array 1136 1144 8 0.7
telink air-quality-sensor-app tlsr9528a_retention bss 54904 55064 160 0.3
contact-sensor-app tlsr9528a_retention bss 54948 55108 160 0.3
light-switch-app-ota-shell-factory-data tlsr9528a bss 78932 79092 160 0.2
pump-app tlsr9528a bss 68924 69084 160 0.2
pump-controller-app tlsr9518adk80d bss 57160 57320 160 0.3
smoke_co_alarm-app tlsr9528a_retention bss 55084 55244 160 0.3
temperature-measurement-app-mars-ota tlsr9518adk80d bss 60636 60796 160 0.3
thermostat tlsr9518adk80d bss 57456 57616 160 0.3
window-covering tlsr9518adk80d bss 57808 57968 160 0.3
Increases (28 builds for efr32, k32w, linux, qpg, telink)
platform target config section a9ad2c4 9610c5b change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114448 1114856 408 0.0
.bss 188656 188816 160 0.1
.text 923060 923308 248 0.0
k32w contact k32w0+release (read only) 605000 605240 240 0.0
(read/write) 81736 81896 160 0.2
.bss 69584 69744 160 0.2
.text 604464 604704 240 0.0
lock k32w0+release (read only) 576104 576344 240 0.0
(read/write) 79216 79376 160 0.2
.bss 67136 67296 160 0.2
.text 575568 575808 240 0.0
linux air-purifier-app debug (read only) 2525661 2525981 320 0.0
.rodata 179272 179336 64 0.0
.text 2171029 2171285 256 0.0
all-clusters-app debug (read only) 5380825 5380985 160 0.0
.text 4663587 4663747 160 0.0
all-clusters-minimal-app debug (read only) 4952889 4953049 160 0.0
.text 4447619 4447779 160 0.0
bridge-app debug (read only) 4416617 4416777 160 0.0
.text 3978931 3979091 160 0.0
chip-tool debug (read only) 11684537 11686249 1712 0.0
.rodata 424489 424585 96 0.0
.text 10570115 10571731 1616 0.0
chip-tool-ipv6only arm64 (read only) 11412176 11413552 1376 0.0
(read/write) 570416 573096 2680 0.5
.data.rel.ro 436448 436472 24 0.0
.rodata 344872 344952 80 0.0
.text 10199320 10200600 1280 0.0
lighting-app debug+rpc+ui (read only) 5302305 5302609 304 0.0
.rodata 340340 340372 32 0.0
.text 4717219 4717491 272 0.0
lock-app debug (read only) 4501681 4501841 160 0.0
.text 4044659 4044819 160 0.0
ota-provider-app debug (read only) 4165809 4165985 176 0.0
.text 3772675 3772851 176 0.0
ota-requestor-app debug (read only) 4255313 4255473 160 0.0
.text 3853939 3854099 160 0.0
shell debug (read only) 2787865 2788025 160 0.0
(read/write) 151592 151752 160 0.1
.bss 62152 62312 160 0.3
.text 2435170 2435330 160 0.0
thermostat-no-ble arm64 (read only) 4405296 4405312 16 0.0
.text 3902648 3902664 16 0.0
tv-app debug (read only) 5384297 5386073 1776 0.0
(read/write) 348896 349056 160 0.0
.bss 244384 244544 160 0.1
.rodata 272853 272981 128 0.0
.text 4873635 4875283 1648 0.0
tv-casting-app debug (read only) 9563961 9565505 1544 0.0
(read/write) 338168 338336 168 0.0
.bss 156192 156352 160 0.1
.init_array 1136 1144 8 0.7
.rodata 362760 362824 64 0.0
.text 8737491 8738947 1456 0.0
qpg lock-app qpg6105+debug (read/write) 1080500 1080740 240 0.0
.bss 97352 97512 160 0.2
.text 592880 593120 240 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 820830 821262 432 0.1
bss 54904 55064 160 0.3
text 613512 613782 270 0.0
contact-sensor-app tlsr9528a_retention (read/write) 821066 821498 432 0.1
bss 54948 55108 160 0.3
text 613882 614152 270 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 978216 978648 432 0.0
bss 78932 79092 160 0.2
text 694030 694302 272 0.0
lock-app-dfu tlsr9528a (read/write) 964348 965216 868 0.1
bss 97196 97356 160 0.2
text 647584 647918 334 0.1
pump-app tlsr9528a (read/write) 879864 880296 432 0.0
bss 68924 69084 160 0.2
text 621890 622162 272 0.0
pump-controller-app tlsr9518adk80d (read/write) 820476 820908 432 0.1
bss 57160 57320 160 0.3
text 588766 589038 272 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 822802 823226 424 0.1
bss 55084 55244 160 0.3
text 616626 616896 270 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 877569 878001 432 0.0
bss 60636 60796 160 0.3
text 630506 630778 272 0.0
thermostat tlsr9518adk80d (read/write) 844848 845280 432 0.1
bss 57456 57616 160 0.3
text 607232 607504 272 0.0
window-covering tlsr9518adk80d (read/write) 839124 839556 432 0.1
bss 57808 57968 160 0.3
text 601266 601538 272 0.0
Decreases (1 build for linux)
platform target config section a9ad2c4 9610c5b change % change
linux thermostat-no-ble arm64 (read/write) 245192 245176 -16 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section a9ad2c4 9610c5b change % change
bl602 lighting-app bl602 (read/write) 1417862 1417862 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156892 156892 0 0.0
.text 1085746 1085746 0 0.0
bl602+mfd (read/write) 1432590 1432590 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155852 155852 0 0.0
.text 1101370 1101370 0 0.0
bl602+rpc (read/write) 1465646 1465646 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164516 164516 0 0.0
.text 1117490 1117490 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1182871 1182871 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106268 106268 0 0.0
.text 955448 955448 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1194003 1194003 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105208 105208 0 0.0
.text 967512 967512 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274887 1274887 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121688 121688 0 0.0
.text 1030510 1030510 0 0.0
bl706-eth (read/write) 1002497 1002497 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99600 99600 0 0.0
.text 748344 748344 0 0.0
bl706-wifi (read/write) 1240630 1240630 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120580 120580 0 0.0
.text 975636 975636 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1152580 1152580 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100272 100272 0 0.0
.text 948574 948574 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1164032 1164032 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99212 99212 0 0.0
.text 960950 960950 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771768 771768 0 0.0
(read/write) 168100 168100 0 0.0
.bss 90436 90436 0 0.0
.data 3460 3460 0 0.0
.rodata 89520 89520 0 0.0
.text 681980 681980 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787824 787824 0 0.0
(read/write) 178328 178328 0 0.0
.bss 100612 100612 0 0.0
.data 3488 3488 0 0.0
.rodata 83768 83768 0 0.0
.text 703792 703792 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776072 776072 0 0.0
(read/write) 172784 172784 0 0.0
.bss 95068 95068 0 0.0
.data 3488 3488 0 0.0
.rodata 110376 110376 0 0.0
.text 665432 665432 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728688 728688 0 0.0
(read/write) 167096 167096 0 0.0
.bss 89208 89208 0 0.0
.data 3448 3448 0 0.0
.rodata 85096 85096 0 0.0
.text 643324 643324 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714224 714224 0 0.0
(read/write) 167276 167276 0 0.0
.bss 89392 89392 0 0.0
.data 3444 3444 0 0.0
.rodata 80928 80928 0 0.0
.text 633028 633028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566962 566962 0 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83922 83922 0 0.0
.text 480916 480916 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620298 620298 0 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105786 105786 0 0.0
.text 512388 512388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561351 561351 0 0.0
.app_xip_area 451609 451609 0 0.0
.bss 64656 64656 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543567 543567 0 0.0
.app_xip_area 429089 429089 0 0.0
.bss 69352 69352 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562335 562335 0 0.0
.app_xip_area 454049 454049 0 0.0
.bss 63272 63272 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557799 557799 0 0.0
.app_xip_area 446289 446289 0 0.0
.bss 66392 66392 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016988 1016988 0 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841680 841680 0 0.0
BRD4187C (read/write) 1100988 1100988 0 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901468 901468 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114448 1114856 408 0.0
.bss 188656 188816 160 0.1
.data 2712 2712 0 0.0
.text 923060 923308 248 0.0
window-app BRD4187C (read/write) 1135712 1135712 0 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964288 964288 0 0.0
esp32 all-clusters-app c3devkit (read only) 1137748 1137748 0 0.0
(read/write) 1671092 1671092 0 0.0
.dram0.bss 72864 72864 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241376 241376 0 0.0
.flash.text 1137748 1137748 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1182659 1182659 0 0.0
(read/write) 520292 520292 0 0.0
.dram0.bss 79512 79512 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272412 272412 0 0.0
.flash.text 1177275 1177275 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605000 605240 240 0.0
(read/write) 81736 81896 160 0.2
.bss 69584 69744 160 0.2
.data 2168 2168 0 0.0
.text 604464 604704 240 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690704 690704 0 0.0
.bss 67600 67600 0 0.0
.data 2716 2716 0 0.0
.text 576912 576912 0 0.0
light k32w0+release (read only) 594944 594944 0 0.0
(read/write) 79112 79112 0 0.0
.bss 67008 67008 0 0.0
.data 2120 2120 0 0.0
.text 594408 594408 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782516 782516 0 0.0
.bss 77276 77276 0 0.0
.data 1928 1928 0 0.0
.text 659856 659856 0 0.0
lock k32w0+release (read only) 576104 576344 240 0.0
(read/write) 79216 79376 160 0.2
.bss 67136 67296 160 0.2
.data 2096 2096 0 0.0
.text 575568 575808 240 0.0
linux air-purifier-app debug (read only) 2525661 2525981 320 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72776 72776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179272 179336 64 0.0
.text 2171029 2171285 256 0.0
all-clusters-app debug (read only) 5380825 5380985 160 0.0
(read/write) 453672 453672 0 0.0
.bss 131600 131600 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 311000 311000 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1232 1232 0 0.0
.rodata 309916 309916 0 0.0
.text 4663587 4663747 160 0.0
all-clusters-minimal-app debug (read only) 4952889 4953049 160 0.0
(read/write) 234656 234656 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95912 95912 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272845 272845 0 0.0
.text 4447619 4447779 160 0.0
bridge-app debug (read only) 4416617 4416777 160 0.0
(read/write) 215896 215896 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85232 85232 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219157 219157 0 0.0
.text 3978931 3979091 160 0.0
chip-tool debug (read only) 11684537 11686249 1712 0.0
(read/write) 504048 504048 0 0.0
.bss 94200 94200 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 397616 397616 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 424489 424585 96 0.0
.text 10570115 10571731 1616 0.0
chip-tool-ipv6only arm64 (read only) 11412176 11413552 1376 0.0
(read/write) 570416 573096 2680 0.5
.bss 103448 103448 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 436448 436472 24 0.0
.dynamic 512 512 0 0.0
.got 19816 19816 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 344872 344952 80 0.0
.text 10199320 10200600 1280 0.0
lighting-app debug+rpc+ui (read only) 5302305 5302609 304 0.0
(read/write) 224968 224968 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93632 93632 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340340 340372 32 0.0
.text 4717219 4717491 272 0.0
lock-app debug (read only) 4501681 4501841 160 0.0
(read/write) 203616 203616 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4044659 4044819 160 0.0
ota-provider-app debug (read only) 4165809 4165985 176 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69248 69248 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3772675 3772851 176 0.0
ota-requestor-app debug (read only) 4255313 4255473 160 0.0
(read/write) 196976 196976 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72240 72240 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205141 205141 0 0.0
.text 3853939 3854099 160 0.0
shell debug (read only) 2787865 2788025 160 0.0
(read/write) 151592 151752 160 0.1
.bss 62152 62312 160 0.3
.data 768 768 0 0.0
.data.rel.ro 82864 82864 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 181792 181792 0 0.0
.text 2435170 2435330 160 0.0
thermostat-no-ble arm64 (read only) 4405296 4405312 16 0.0
(read/write) 245192 245176 -16 -0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3902648 3902664 16 0.0
tv-app debug (read only) 5384297 5386073 1776 0.0
(read/write) 348896 349056 160 0.0
.bss 244384 244544 160 0.1
.data 4992 4992 0 0.0
.data.rel.ro 92216 92216 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272853 272981 128 0.0
.text 4873635 4875283 1648 0.0
tv-casting-app debug (read only) 9563961 9565505 1544 0.0
(read/write) 338168 338336 168 0.0
.bss 156192 156352 160 0.1
.data 2464 2464 0 0.0
.data.rel.ro 172664 172664 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1144 8 0.7
.rodata 362760 362824 64 0.0
.text 8737491 8738947 1456 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526040 2526040 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488724 1488724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1062456 1062456 0 0.0
bss 129375 129375 0 0.0
rodata 104392 104392 0 0.0
text 781104 781104 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1189032 1189032 0 0.0
bss 121585 121585 0 0.0
rodata 138460 138460 0 0.0
text 778648 778648 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046728 1046728 0 0.0
bss 129348 129348 0 0.0
rodata 99432 99432 0 0.0
text 770320 770320 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835880 835880 0 0.0
(read/write) 1743436 1743436 0 0.0
.bss 194988 194988 0 0.0
.data 2472 2472 0 0.0
.text 1537588 1537588 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705924 1705924 0 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502108 1502108 0 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630884 1630884 0 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433756 1433756 0 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657796 1657796 0 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433548 1433548 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116748 1116748 0 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 629124 629124 0 0.0
lock-app qpg6105+debug (read/write) 1080500 1080740 240 0.0
.bss 97352 97512 160 0.2
.data 784 784 0 0.0
.text 592880 593120 240 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820830 821262 432 0.1
bss 54904 55064 160 0.3
text 613512 613782 270 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1080344 1080344 0 0.0
bss 100388 100388 0 0.0
text 762378 762378 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083928 1083928 0 0.0
bss 109764 109764 0 0.0
text 753428 753428 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934568 934568 0 0.0
bss 94272 94272 0 0.0
text 646848 646848 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821066 821498 432 0.1
bss 54948 55108 160 0.3
text 613882 614152 270 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 978216 978648 432 0.0
bss 78932 79092 160 0.2
text 694030 694302 272 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092916 1092916 0 0.0
bss 99836 99836 0 0.0
text 769740 769740 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 964348 965216 868 0.1
bss 97196 97356 160 0.2
text 647584 647918 334 0.1
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948244 948244 0 0.0
bss 92380 92380 0 0.0
text 662956 662956 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 879864 880296 432 0.0
bss 68924 69084 160 0.2
text 621890 622162 272 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 820476 820908 432 0.1
bss 57160 57320 160 0.3
text 588766 589038 272 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705584 705584 0 0.0
bss 73588 73588 0 0.0
text 462084 462084 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822802 823226 424 0.1
bss 55084 55244 160 0.3
text 616626 616896 270 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877569 878001 432 0.0
bss 60636 60796 160 0.3
text 630506 630778 272 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844848 845280 432 0.1
bss 57456 57616 160 0.3
text 607232 607504 272 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839124 839556 432 0.1
bss 57808 57968 160 0.3
text 601266 601538 272 0.0

bzbarsky-apple
bzbarsky-apple reviewed Dec 14, 2023
View reviewed changes
src/protocols/secure_channel/CheckinMessage.cpp Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.cpp Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
src/protocols/secure_channel/CheckinMessage.h Outdated Show resolved Hide resolved
mkardous-silabs and others added 2 commits December 14, 2023 13:30
@mkardous-silabs @bzbarsky-apple
Apply suggestions from code review
707657e 
Co-authored-by: Boris Zbarsky <[email protected]>
@mkardous-silabs
Fix function comments
304328e 
rename min payload size
@mkardous-silabs @tcarmelveilleux
Update src/app/icd/ICDCheckInSender.cpp
5775fce 
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@mkardous-silabs mkardous-silabs enabled auto-merge (squash) December 14, 2023 21:27
@mkardous-silabs mkardous-silabs merged commit ff5b64d into project-chip:master Dec 14, 2023
57 checks passed
@mkardous-silabs mkardous-silabs deleted the fix/checkin_message branch December 14, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@lpbeliveau-silabs lpbeliveau-silabs lpbeliveau-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@thivya-amazon thivya-amazon Awaiting requested review from thivya-amazon

Assignees
No one assigned
Labels
app examples icd Intermittently Connected Devices protocols review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICD] Active Mode threshold is not added to the Check-In message
7 participants
@mkardous-silabs @tcarmelveilleux @yunhanw-google @bzbarsky-apple @thivya-amazon @lpbeliveau-silabs @restyled-commits