Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address post merge PR review comment in CommandSender #30923

Merged

Conversation

tehampson
Copy link
Contributor

Just a comment being updated

Copy link

github-actions bot commented Dec 11, 2023

PR #30923: Size comparison from 574dfd5 to ff59c9a

Decreases (1 build for efr32)
platform target config section 574dfd5 ff59c9a change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1114448 1114440 -8 -0.0
.text 923060 923052 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 574dfd5 ff59c9a change % change
bl602 lighting-app bl602 (read/write) 1417862 1417862 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156892 156892 0 0.0
.text 1085746 1085746 0 0.0
bl602+mfd (read/write) 1432590 1432590 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155852 155852 0 0.0
.text 1101370 1101370 0 0.0
bl602+rpc (read/write) 1465646 1465646 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164516 164516 0 0.0
.text 1117490 1117490 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1182871 1182871 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106268 106268 0 0.0
.text 955448 955448 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1194003 1194003 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105208 105208 0 0.0
.text 967512 967512 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274887 1274887 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121688 121688 0 0.0
.text 1030510 1030510 0 0.0
bl706-eth (read/write) 1002497 1002497 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99600 99600 0 0.0
.text 748344 748344 0 0.0
bl706-wifi (read/write) 1240630 1240630 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120580 120580 0 0.0
.text 975636 975636 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1152580 1152580 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100272 100272 0 0.0
.text 948574 948574 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1164032 1164032 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99212 99212 0 0.0
.text 960950 960950 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742516 742516 0 0.0
(read/write) 167132 167132 0 0.0
.bss 89548 89548 0 0.0
.data 3420 3420 0 0.0
.rodata 84648 84648 0 0.0
.text 657476 657476 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759844 759844 0 0.0
(read/write) 177360 177360 0 0.0
.bss 99724 99724 0 0.0
.data 3448 3448 0 0.0
.rodata 79728 79728 0 0.0
.text 679728 679728 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746820 746820 0 0.0
(read/write) 171816 171816 0 0.0
.bss 94180 94180 0 0.0
.data 3448 3448 0 0.0
.rodata 105504 105504 0 0.0
.text 640928 640928 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 700388 700388 0 0.0
(read/write) 166128 166128 0 0.0
.bss 88320 88320 0 0.0
.data 3408 3408 0 0.0
.rodata 80440 80440 0 0.0
.text 619556 619556 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685924 685924 0 0.0
(read/write) 166308 166308 0 0.0
.bss 88504 88504 0 0.0
.data 3404 3404 0 0.0
.rodata 76280 76280 0 0.0
.text 609252 609252 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566962 566962 0 0.0
(read/write) 207652 207652 0 0.0
.bss 201116 201116 0 0.0
.data 1412 1412 0 0.0
.rodata 83922 83922 0 0.0
.text 480916 480916 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620298 620298 0 0.0
(read/write) 208048 208048 0 0.0
.bss 201480 201480 0 0.0
.data 1448 1448 0 0.0
.rodata 105786 105786 0 0.0
.text 512388 512388 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 561351 561351 0 0.0
.app_xip_area 451609 451609 0 0.0
.bss 64656 64656 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 543567 543567 0 0.0
.app_xip_area 429089 429089 0 0.0
.bss 69352 69352 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 562335 562335 0 0.0
.app_xip_area 454049 454049 0 0.0
.bss 63272 63272 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 557799 557799 0 0.0
.app_xip_area 446289 446289 0 0.0
.bss 66392 66392 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1016988 1016988 0 0.0
.bss 172600 172600 0 0.0
.data 2688 2688 0 0.0
.text 841680 841680 0 0.0
BRD4187C (read/write) 1100988 1100988 0 0.0
.bss 196204 196204 0 0.0
.data 3296 3296 0 0.0
.text 901468 901468 0 0.0
lock-app BRD4161A+wf200 (read/write) 1114448 1114440 -8 -0.0
.bss 188656 188656 0 0.0
.data 2712 2712 0 0.0
.text 923060 923052 -8 -0.0
window-app BRD4187C (read/write) 1135712 1135712 0 0.0
.bss 168236 168236 0 0.0
.data 3168 3168 0 0.0
.text 964288 964288 0 0.0
esp32 all-clusters-app c3devkit (read only) 1136882 1136882 0 0.0
(read/write) 1670548 1670548 0 0.0
.dram0.bss 72536 72536 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241152 241152 0 0.0
.flash.text 1136882 1136882 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1181875 1181875 0 0.0
(read/write) 519744 519744 0 0.0
.dram0.bss 79192 79192 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272184 272184 0 0.0
.flash.text 1176491 1176491 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 605000 605000 0 0.0
(read/write) 81736 81736 0 0.0
.bss 69584 69584 0 0.0
.data 2168 2168 0 0.0
.text 604464 604464 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 690704 690704 0 0.0
.bss 67600 67600 0 0.0
.data 2716 2716 0 0.0
.text 576912 576912 0 0.0
light k32w0+release (read only) 594944 594944 0 0.0
(read/write) 79112 79112 0 0.0
.bss 67008 67008 0 0.0
.data 2120 2120 0 0.0
.text 594408 594408 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 782516 782516 0 0.0
.bss 77276 77276 0 0.0
.data 1928 1928 0 0.0
.text 659856 659856 0 0.0
lock k32w0+release (read only) 576104 576104 0 0.0
(read/write) 79216 79216 0 0.0
.bss 67136 67136 0 0.0
.data 2096 2096 0 0.0
.text 575568 575568 0 0.0
linux air-purifier-app debug (read only) 2525645 2525645 0 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72776 72776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179272 179272 0 0.0
.text 2171013 2171013 0 0.0
all-clusters-app debug (read only) 5369977 5369977 0 0.0
(read/write) 449600 449600 0 0.0
.bss 130064 130064 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 308472 308472 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 308476 308476 0 0.0
.text 4656483 4656483 0 0.0
all-clusters-minimal-app debug (read only) 4952841 4952841 0 0.0
(read/write) 234656 234656 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95912 95912 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272813 272813 0 0.0
.text 4447603 4447603 0 0.0
bridge-app debug (read only) 4416569 4416569 0 0.0
(read/write) 215896 215896 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85232 85232 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219125 219125 0 0.0
.text 3978915 3978915 0 0.0
chip-tool debug (read only) 11587297 11587297 0 0.0
(read/write) 500520 500520 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 394208 394208 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 418761 418761 0 0.0
.text 10483379 10483379 0 0.0
chip-tool-ipv6only arm64 (read only) 11322304 11322304 0 0.0
(read/write) 565984 565984 0 0.0
.bss 103352 103352 0 0.0
.data 4280 4280 0 0.0
.data.rel.ro 432952 432952 0 0.0
.dynamic 512 512 0 0.0
.got 19696 19696 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 341544 341544 0 0.0
.text 10118008 10118008 0 0.0
lighting-app debug+rpc+ui (read only) 5302305 5302305 0 0.0
(read/write) 224968 224968 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93632 93632 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340340 340340 0 0.0
.text 4717219 4717219 0 0.0
lock-app debug (read only) 4501665 4501665 0 0.0
(read/write) 203616 203616 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4044643 4044643 0 0.0
ota-provider-app debug (read only) 4165809 4165809 0 0.0
(read/write) 192696 192696 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69248 69248 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3772675 3772675 0 0.0
ota-requestor-app debug (read only) 4255265 4255265 0 0.0
(read/write) 196976 196976 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72240 72240 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205109 205109 0 0.0
.text 3853923 3853923 0 0.0
shell debug (read only) 2780577 2780577 0 0.0
(read/write) 149792 149792 0 0.0
.bss 60616 60616 0 0.0
.data 768 768 0 0.0
.data.rel.ro 82608 82608 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 181024 181024 0 0.0
.text 2428866 2428866 0 0.0
thermostat-no-ble arm64 (read only) 4405264 4405264 0 0.0
(read/write) 245208 245208 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102312 102312 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162316 162316 0 0.0
.text 3902632 3902632 0 0.0
tv-app debug (read only) 5384281 5384281 0 0.0
(read/write) 348896 348896 0 0.0
.bss 244384 244384 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 92216 92216 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272853 272853 0 0.0
.text 4873619 4873619 0 0.0
tv-casting-app debug (read only) 9498857 9498857 0 0.0
(read/write) 337336 337336 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 171832 171832 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 359976 359976 0 0.0
.text 8677187 8677187 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2526040 2526040 0 0.0
.bss 220216 220216 0 0.0
.data 5144 5144 0 0.0
.text 1488724 1488724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1061052 1061052 0 0.0
bss 129061 129061 0 0.0
rodata 104172 104172 0 0.0
text 780188 780188 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1187640 1187640 0 0.0
bss 121271 121271 0 0.0
rodata 138300 138300 0 0.0
text 777752 777752 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046728 1046728 0 0.0
bss 129348 129348 0 0.0
rodata 99432 99432 0 0.0
text 770320 770320 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836192 836192 0 0.0
(read/write) 1741668 1741668 0 0.0
.bss 194676 194676 0 0.0
.data 2472 2472 0 0.0
.text 1536132 1536132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837912 837912 0 0.0
(read/write) 1705924 1705924 0 0.0
.bss 192956 192956 0 0.0
.data 2472 2472 0 0.0
.text 1502108 1502108 0 0.0
light cy8ckit_062s2_43012 (read only) 844600 844600 0 0.0
(read/write) 1630884 1630884 0 0.0
.bss 186380 186380 0 0.0
.data 2360 2360 0 0.0
.text 1433756 1433756 0 0.0
lock cy8ckit_062s2_43012 (read only) 817480 817480 0 0.0
(read/write) 1657796 1657796 0 0.0
.bss 213476 213476 0 0.0
.data 2384 2384 0 0.0
.text 1433548 1433548 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1116748 1116748 0 0.0
.bss 101216 101216 0 0.0
.data 740 740 0 0.0
.text 629124 629124 0 0.0
lock-app qpg6105+debug (read/write) 1080500 1080500 0 0.0
.bss 97352 97352 0 0.0
.data 784 784 0 0.0
.text 592880 592880 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820830 820830 0 0.0
bss 54904 54904 0 0.0
text 613512 613512 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1078756 1078756 0 0.0
bss 100072 100072 0 0.0
text 761480 761480 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1083928 1083928 0 0.0
bss 109764 109764 0 0.0
text 753428 753428 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934568 934568 0 0.0
bss 94272 94272 0 0.0
text 646848 646848 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821066 821066 0 0.0
bss 54948 54948 0 0.0
text 613882 613882 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 978216 978216 0 0.0
bss 78932 78932 0 0.0
text 694030 694030 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092916 1092916 0 0.0
bss 99836 99836 0 0.0
text 769740 769740 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 964348 964348 0 0.0
bss 97196 97196 0 0.0
text 647584 647584 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948244 948244 0 0.0
bss 92380 92380 0 0.0
text 662956 662956 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 879864 879864 0 0.0
bss 68924 68924 0 0.0
text 621890 621890 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 820476 820476 0 0.0
bss 57160 57160 0 0.0
text 588766 588766 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705584 705584 0 0.0
bss 73588 73588 0 0.0
text 462084 462084 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822802 822802 0 0.0
bss 55084 55084 0 0.0
text 616626 616626 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877569 877569 0 0.0
bss 60636 60636 0 0.0
text 630506 630506 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 844848 844848 0 0.0
bss 57456 57456 0 0.0
text 607232 607232 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839124 839124 0 0.0
bss 57808 57808 0 0.0
text 601266 601266 0 0.0

@andy31415 andy31415 merged commit ee90b75 into project-chip:master Dec 11, 2023
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants