Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new IM Status NO_COMMAND_RESPONSE #30921

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Add new IM Status NO_COMMAND_RESPONSE #30921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f56817d
Add new IM Status NO_COMMAND_RESPONSE
tehampson Dec 11, 2023
0b86bf8
Address PR comments
tehampson Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/ERROR_CODES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,5 +255,6 @@ This file was **AUTOMATICALLY** generated by
| 1481 | 0x5C9 | `TIMED_REQUEST_MISMATCH` |
| 1482 | 0x5CA | `FAILSAFE_REQUIRED` |
| 1483 | 0x5CB | `INVALID_IN_STATE` |
| 1484 | 0x5CC | `NO_COMMAND_RESPONSE` |
| 1520 | 0x5F0 | `WRITE_IGNORED` |

1 change: 1 addition & 0 deletions src/app/util/af-enums.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,6 @@ enum EmberAfStatus : uint8_t
EMBER_ZCL_STATUS_TIMED_REQUEST_MISMATCH = 0xC9,
EMBER_ZCL_STATUS_FAILSAFE_REQUIRED = 0xCA,
EMBER_ZCL_STATUS_INVALID_IN_STATE = 0xCB,
EMBER_ZCL_STATUS_NO_COMMAND_RESPONSE = 0xCC,
EMBER_ZCL_STATUS_WRITE_IGNORED = 0xF0, // NOT SPEC COMPLIANT FOR TEST ONLY
};
2 changes: 2 additions & 0 deletions src/controller/python/chip/interaction_model/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ class Status(enum.IntEnum):
PathsExhausted = 0xc8
TimedRequestMismatch = 0xc9
FailsafeRequired = 0xca
InvalidInState = 0xcb
NoCommandResponse = 0xcc
tehampson marked this conversation as resolved.
Show resolved Hide resolved


class InteractionModelError(ChipStackException):
Expand Down
2 changes: 2 additions & 0 deletions src/lib/format/protocol_messages.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ client cluster IMProtocol = 0xFFFF0001 {
kPathsExhausted = 0xc8;
kTimedRequestMismatch = 0xc9;
kFailsafeRequired = 0xca;
kInvalidInState = 0xcb;
kNoCommandResponse = 0xcc;
tehampson marked this conversation as resolved.
Show resolved Hide resolved
kWriteIgnored = 0xF0;
}

Expand Down
1 change: 1 addition & 0 deletions src/protocols/interaction_model/StatusCodeList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,6 @@ CHIP_IM_STATUS_CODE(PathsExhausted , PATHS_EXHAUSTED , 0xc8)
CHIP_IM_STATUS_CODE(TimedRequestMismatch , TIMED_REQUEST_MISMATCH , 0xc9)
CHIP_IM_STATUS_CODE(FailsafeRequired , FAILSAFE_REQUIRED , 0xca)
CHIP_IM_STATUS_CODE(InvalidInState , INVALID_IN_STATE , 0xcb)
CHIP_IM_STATUS_CODE(NoCommandResponse , NO_COMMAND_RESPONSE , 0xcc)
CHIP_IM_STATUS_CODE(WriteIgnored , WRITE_IGNORED , 0xF0) // non-spec error code and use only internally
// clang-format on
Loading