-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark several clusters that are zigbee only as deprecated. #30871
Mark several clusters that are zigbee only as deprecated. #30871
Conversation
PR #30871: Size comparison from 4db8c38 to 1f64ebd Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we should consider start removing the provisional stuff from the 1.3 spec as well, such as PulseWidthModulation.
We should ... however the problem was that we released official APIs containing these. We are more careful now however in particular PWM is a problem. We need to somehow find how to deprecate/remove for real. @woody-apple for darwin API visibility. |
Thanks for taking this on. I was a bit surprised to see some of these clusters on the all-clusters app when I finally got around to run the PICS generator against that example app. |
We will still codegen to not break potential existing clients for now.
Generally it is unclear why anyone would use these (they are not real things because zigbee only), however the process of complete removal is probably a lot longer, hence the flagging for now.