Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WELL from empty/uninitialized error names #30737

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Nov 30, 2023

Problem

Error codes where imported from some other project (long time ago) and it seems that the name "WELL" does not mean anything in context of Matter errors.

Changes

Removed WELL from the error names.

Testing

CI will verify

Copy link

github-actions bot commented Nov 30, 2023

PR #30737: Size comparison from 03efab5 to 805b4ab

Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section 03efab5 805b4ab change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564986 564986 0 0.0
(read/write) 207512 207512 0 0.0
.bss 200972 200972 0 0.0
.data 1416 1416 0 0.0
.rodata 83858 83858 0 0.0
.text 479004 479004 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617994 617994 0 0.0
(read/write) 207908 207908 0 0.0
.bss 201336 201336 0 0.0
.data 1452 1452 0 0.0
.rodata 105730 105730 0 0.0
.text 510144 510144 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523944 2523944 0 0.0
.bss 220072 220072 0 0.0
.data 5144 5144 0 0.0
.text 1486628 1486628 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1057948 1057948 0 0.0
bss 128917 128917 0 0.0
rodata 104140 104140 0 0.0
text 777240 777240 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1184492 1184492 0 0.0
bss 121127 121127 0 0.0
rodata 138268 138268 0 0.0
text 774768 774768 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043084 1043084 0 0.0
bss 129204 129204 0 0.0
rodata 99316 99316 0 0.0
text 766912 766912 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1114316 1114316 0 0.0
.bss 101144 101144 0 0.0
.data 744 744 0 0.0
.text 626696 626696 0 0.0
lock-app qpg6105+debug (read/write) 1077444 1077444 0 0.0
.bss 97272 97272 0 0.0
.data 788 788 0 0.0
.text 589820 589820 0 0.0

Copy link

github-actions bot commented Nov 30, 2023

PR #30737: Size comparison from 03efab5 to 57d2cb8

Decreases (7 builds for linux)
platform target config section 03efab5 57d2cb8 change % change
linux all-clusters-app debug (read only) 5339481 5339449 -32 -0.0
.rodata 304380 304348 -32 -0.0
all-clusters-minimal-app debug (read only) 4933769 4933737 -32 -0.0
.rodata 270893 270861 -32 -0.0
chip-tool-ipv6only arm64 (read only) 10742328 10742312 -16 -0.0
.rodata 329600 329584 -16 -0.0
lock-app debug (read only) 4491777 4491745 -32 -0.0
.rodata 246549 246517 -32 -0.0
ota-provider-app debug (read only) 4155817 4155785 -32 -0.0
.rodata 200821 200789 -32 -0.0
thermostat-no-ble arm64 (read only) 4393056 4393040 -16 -0.0
.rodata 161980 161964 -16 -0.0
tv-casting-app debug (read only) 8854361 8854329 -32 -0.0
.rodata 350824 350792 -32 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 03efab5 57d2cb8 change % change
bl602 lighting-app bl602 (read/write) 1411414 1411414 0 0.0
.bss 85048 85048 0 0.0
.data 9376 9376 0 0.0
.rodata 156860 156860 0 0.0
.text 1079478 1079478 0 0.0
bl602+mfd (read/write) 1425854 1425854 0 0.0
.bss 85216 85216 0 0.0
.data 9344 9344 0 0.0
.rodata 155820 155820 0 0.0
.text 1094830 1094830 0 0.0
bl602+rpc (read/write) 1458934 1458934 0 0.0
.bss 93080 93080 0 0.0
.data 9744 9744 0 0.0
.rodata 164476 164476 0 0.0
.text 1110966 1110966 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1175847 1175847 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106232 106232 0 0.0
.text 948626 948626 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1186971 1186971 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105172 105172 0 0.0
.text 960690 960690 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1275915 1275915 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121648 121648 0 0.0
.text 1023688 1023688 0 0.0
bl706-eth (read/write) 995813 995813 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99572 99572 0 0.0
.text 741862 741862 0 0.0
bl706-wifi (read/write) 1231962 1231962 0 0.0
.bss 10641 10641 0 0.0
.data 3568 3568 0 0.0
.rodata 120544 120544 0 0.0
.text 967178 967178 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1145540 1145540 0 0.0
.bss 16392 16392 0 0.0
.data 4920 4920 0 0.0
.rodata 100236 100236 0 0.0
.text 941716 941716 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1157000 1157000 0 0.0
.bss 16568 16568 0 0.0
.data 4904 4904 0 0.0
.rodata 99176 99176 0 0.0
.text 954092 954092 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740147 740147 0 0.0
(read/write) 167056 167056 0 0.0
.bss 89468 89468 0 0.0
.data 3424 3424 0 0.0
.rodata 84607 84607 0 0.0
.text 655148 655148 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757659 757659 0 0.0
(read/write) 177300 177300 0 0.0
.bss 99652 99652 0 0.0
.data 3452 3452 0 0.0
.rodata 79695 79695 0 0.0
.text 677572 677572 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744595 744595 0 0.0
(read/write) 171748 171748 0 0.0
.bss 94100 94100 0 0.0
.data 3452 3452 0 0.0
.rodata 105455 105455 0 0.0
.text 638752 638752 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 698483 698483 0 0.0
(read/write) 166092 166092 0 0.0
.bss 88272 88272 0 0.0
.data 3412 3412 0 0.0
.rodata 80383 80383 0 0.0
.text 617708 617708 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 683955 683955 0 0.0
(read/write) 166232 166232 0 0.0
.bss 88424 88424 0 0.0
.data 3408 3408 0 0.0
.rodata 76215 76215 0 0.0
.text 607348 607348 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564986 564986 0 0.0
(read/write) 207512 207512 0 0.0
.bss 200972 200972 0 0.0
.data 1416 1416 0 0.0
.rodata 83858 83858 0 0.0
.text 479004 479004 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617994 617994 0 0.0
(read/write) 207908 207908 0 0.0
.bss 201336 201336 0 0.0
.data 1452 1452 0 0.0
.rodata 105730 105730 0 0.0
.text 510144 510144 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 558511 558511 0 0.0
.app_xip_area 448913 448913 0 0.0
.bss 64512 64512 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540903 540903 0 0.0
.app_xip_area 426569 426569 0 0.0
.bss 69208 69208 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559879 559879 0 0.0
.app_xip_area 451737 451737 0 0.0
.bss 63128 63128 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 555031 555031 0 0.0
.app_xip_area 443657 443657 0 0.0
.bss 66248 66248 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013344 1013344 0 0.0
.bss 172456 172456 0 0.0
.data 2692 2692 0 0.0
.text 838176 838176 0 0.0
BRD4187C (read/write) 1098224 1098224 0 0.0
.bss 196060 196060 0 0.0
.data 3300 3300 0 0.0
.text 898844 898844 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111208 1111208 0 0.0
.bss 188504 188504 0 0.0
.data 2716 2716 0 0.0
.text 919964 919964 0 0.0
window-app BRD4187C (read/write) 1132596 1132596 0 0.0
.bss 168092 168092 0 0.0
.data 3172 3172 0 0.0
.text 961312 961312 0 0.0
esp32 all-clusters-app c3devkit (read only) 1133990 1133990 0 0.0
(read/write) 1671116 1671116 0 0.0
.dram0.bss 72432 72432 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241816 241816 0 0.0
.flash.text 1133990 1133990 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1178447 1178447 0 0.0
(read/write) 520728 520728 0 0.0
.dram0.bss 79072 79072 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273272 273272 0 0.0
.flash.text 1173063 1173063 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 592764 592764 0 0.0
(read/write) 88076 88076 0 0.0
.bss 71320 71320 0 0.0
.data 2132 2132 0 0.0
.text 592228 592228 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688332 688332 0 0.0
.bss 67520 67520 0 0.0
.data 2720 2720 0 0.0
.text 574616 574616 0 0.0
light k32w0+release (read only) 592484 592484 0 0.0
(read/write) 87752 87752 0 0.0
.bss 71008 71008 0 0.0
.data 2120 2120 0 0.0
.text 591948 591948 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780184 780184 0 0.0
.bss 77196 77196 0 0.0
.data 1932 1932 0 0.0
.text 657600 657600 0 0.0
lock k32w0+release (read only) 564340 564340 0 0.0
(read/write) 85572 85572 0 0.0
.bss 68888 68888 0 0.0
.data 2060 2060 0 0.0
.text 563804 563804 0 0.0
linux air-purifier-app debug (read only) 2516877 2516877 0 0.0
(read/write) 127016 127016 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72616 72616 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 178728 178728 0 0.0
.text 2163125 2163125 0 0.0
all-clusters-app debug (read only) 5339481 5339449 -32 -0.0
(read/write) 435776 435776 0 0.0
.bss 130064 130064 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 294608 294608 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 304380 304348 -32 -0.0
.text 4641699 4641699 0 0.0
all-clusters-minimal-app debug (read only) 4933769 4933737 -32 -0.0
(read/write) 234464 234464 0 0.0
.bss 127856 127856 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95680 95680 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 270893 270861 -32 -0.0
.text 4430883 4430883 0 0.0
bridge-app debug (read only) 4406625 4406625 0 0.0
(read/write) 215736 215736 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85056 85056 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 218549 218549 0 0.0
.text 3969859 3969859 0 0.0
chip-tool debug (read only) 10909649 10909649 0 0.0
(read/write) 473768 473768 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 367480 367480 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 404169 404169 0 0.0
.text 9865011 9865011 0 0.0
chip-tool-ipv6only arm64 (read only) 10742328 10742312 -16 -0.0
(read/write) 539728 539728 0 0.0
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 405688 405688 0 0.0
.dynamic 512 512 0 0.0
.got 19040 19040 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 329600 329584 -16 -0.0
.text 9597208 9597208 0 0.0
lighting-app debug+rpc+ui (read only) 5290953 5290953 0 0.0
(read/write) 224808 224808 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93472 93472 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 339764 339764 0 0.0
.text 4706755 4706755 0 0.0
lock-app debug (read only) 4491777 4491745 -32 -0.0
(read/write) 203424 203424 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246549 246517 -32 -0.0
.text 4035571 4035571 0 0.0
ota-provider-app debug (read only) 4155817 4155785 -32 -0.0
(read/write) 192536 192536 0 0.0
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 69072 69072 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 200821 200789 -32 -0.0
.text 3763475 3763475 0 0.0
ota-requestor-app debug (read only) 4242041 4242041 0 0.0
(read/write) 196784 196784 0 0.0
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 72032 72032 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 204597 204597 0 0.0
.text 3841619 3841619 0 0.0
shell debug (read only) 2767769 2767769 0 0.0
(read/write) 149632 149632 0 0.0
.bss 60616 60616 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82440 82440 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180800 180800 0 0.0
.text 2416594 2416594 0 0.0
thermostat-no-ble arm64 (read only) 4393056 4393040 -16 -0.0
(read/write) 245176 245176 0 0.0
.bss 122232 122232 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102120 102120 0 0.0
.dynamic 512 512 0 0.0
.got 11928 11928 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161980 161964 -16 -0.0
.text 3891352 3891352 0 0.0
tv-app debug (read only) 5290553 5290553 0 0.0
(read/write) 345232 345232 0 0.0
.bss 242592 242592 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90344 90344 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 268373 268373 0 0.0
.text 4787443 4787443 0 0.0
tv-casting-app debug (read only) 8854361 8854329 -32 -0.0
(read/write) 325176 325176 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 159688 159688 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 350824 350792 -32 -0.0
.text 8072659 8072659 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523944 2523944 0 0.0
.bss 220072 220072 0 0.0
.data 5144 5144 0 0.0
.text 1486628 1486628 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1057948 1057948 0 0.0
bss 128917 128917 0 0.0
rodata 104140 104140 0 0.0
text 777240 777240 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1184492 1184492 0 0.0
bss 121127 121127 0 0.0
rodata 138268 138268 0 0.0
text 774768 774768 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043084 1043084 0 0.0
bss 129204 129204 0 0.0
rodata 99316 99316 0 0.0
text 766912 766912 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836336 836336 0 0.0
(read/write) 1738172 1738172 0 0.0
.bss 194532 194532 0 0.0
.data 2472 2472 0 0.0
.text 1532780 1532780 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838048 838048 0 0.0
(read/write) 1701916 1701916 0 0.0
.bss 192812 192812 0 0.0
.data 2480 2480 0 0.0
.text 1498236 1498236 0 0.0
light cy8ckit_062s2_43012 (read only) 844736 844736 0 0.0
(read/write) 1628004 1628004 0 0.0
.bss 186236 186236 0 0.0
.data 2368 2368 0 0.0
.text 1431012 1431012 0 0.0
lock cy8ckit_062s2_43012 (read only) 817616 817616 0 0.0
(read/write) 1655204 1655204 0 0.0
.bss 213332 213332 0 0.0
.data 2392 2392 0 0.0
.text 1431092 1431092 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1114316 1114316 0 0.0
.bss 101144 101144 0 0.0
.data 744 744 0 0.0
.text 626696 626696 0 0.0
lock-app qpg6105+debug (read/write) 1077444 1077444 0 0.0
.bss 97272 97272 0 0.0
.data 788 788 0 0.0
.text 589820 589820 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820662 820662 0 0.0
bss 55004 55004 0 0.0
text 612692 612692 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1075412 1075412 0 0.0
bss 99960 99960 0 0.0
text 758276 758276 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1080128 1080128 0 0.0
bss 109652 109652 0 0.0
text 749856 749856 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932404 932404 0 0.0
bss 94160 94160 0 0.0
text 644804 644804 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820774 820774 0 0.0
bss 55056 55056 0 0.0
text 612916 612916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 974892 974892 0 0.0
bss 78900 78900 0 0.0
text 690858 690858 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1090016 1090016 0 0.0
bss 99724 99724 0 0.0
text 766986 766986 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 961536 961536 0 0.0
bss 97164 97164 0 0.0
text 644922 644922 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945612 945612 0 0.0
bss 92268 92268 0 0.0
text 660466 660466 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 877136 877136 0 0.0
bss 68892 68892 0 0.0
text 619304 619304 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 817740 817740 0 0.0
bss 57128 57128 0 0.0
text 586180 586180 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705404 705404 0 0.0
bss 73588 73588 0 0.0
text 461922 461922 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822450 822450 0 0.0
bss 55184 55184 0 0.0
text 615612 615612 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874541 874541 0 0.0
bss 60604 60604 0 0.0
text 627620 627620 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 841888 841888 0 0.0
bss 57424 57424 0 0.0
text 604438 604438 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 836388 836388 0 0.0
bss 57776 57776 0 0.0
text 598666 598666 0 0.0

@mergify mergify bot merged commit 5269ad2 into project-chip:master Nov 30, 2023
60 checks passed
@arkq arkq deleted the uninitialized branch November 30, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants