-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Adding stub API to store data #30730
[Darwin] Adding stub API to store data #30730
Conversation
PR #30730: Size comparison from 1c93935 to 010f8ed Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30730: Size comparison from 1c93935 to 5103a56 Full report (3 builds for cc32xx, mbed)
|
5103a56
to
1fc1502
Compare
PR #30730: Size comparison from 03efab5 to 1fc1502 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30730: Size comparison from 03efab5 to 545a997 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30730: Size comparison from 03efab5 to 5e63aff Increases above 0.2%:
Increases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (5 builds for linux, psoc6)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #30730: Size comparison from 03efab5 to 17ad635 Increases above 0.2%:
Increases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for linux, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
dff23eb
to
3c4d8bb
Compare
PR #30730: Size comparison from 7cade8e to d1cba1f Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30730: Size comparison from 7cade8e to 100b469 Decreases (4 builds for bl602, bl702, bl702l, efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* List of all client data types supported | ||
* | ||
*/ | ||
- (NSArray *)supportedClientDataClasses MTR_NEWLY_AVAILABLE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should either document what the things in the NSArray are, or have it be NSArray<Whatever>
, no?
* List of all client data keys stored | ||
* | ||
*/ | ||
- (NSArray * _Nullable)clientDataKeys MTR_NEWLY_AVAILABLE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, this should either document what the things in the NSArray are, or have it be NSArray<Whatever>
, no?
Also, when does this return nil?
* List of all client data keys stored | ||
* | ||
*/ | ||
- (NSArray * _Nullable)clientDataKeysForEndpointID:(NSNumber *)endpointID MTR_NEWLY_AVAILABLE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
|
||
/** | ||
* | ||
* Set client metadata for a key. The value must conform to NSSecureCoding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#30730 (comment) does not seem to have been addresse?
* Adding client data stub * Restyled by clang-format * Fixing this * Update src/darwin/Framework/CHIP/MTRDevice.h Co-authored-by: Boris Zbarsky <[email protected]> * Resolving some review comments * Add API for all keys, and update storage header * adding docs and supportedClientDataClasses * Restyled by whitespace * Restyled by clang-format * Updating comment * Fixing this method --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Adding stub data for this client metadata. Needs to be hooked up to storage later.