-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Implement ICD Check-In Counter #30705
[ICD] Implement ICD Check-In Counter #30705
Conversation
1163b35
to
68f5ccb
Compare
PR #30705: Size comparison from ba504e3 to 68f5ccb Increases (11 builds for qpg, telink)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
68f5ccb
to
cae17b7
Compare
PR #30705: Size comparison from b379158 to cae17b7 Increases (12 builds for efr32, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30705: Size comparison from b379158 to 6daa484 Increases above 0.2%:
Increases (26 builds for efr32, linux, qpg, telink)
Decreases (21 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -134,6 +134,9 @@ class DefaultStorageKeyAllocator | |||
static StorageKeyName GroupDataCounter() { return StorageKeyName::FromConst("g/gdc"); } | |||
static StorageKeyName GroupControlCounter() { return StorageKeyName::FromConst("g/gcc"); } | |||
|
|||
// ICD Check-In Counter | |||
static StorageKeyName ICDCheckInCounter() { return StorageKeyName::FromConst("icd/cic"); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g/icd/cic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g was for group like group/GroupDataCounter --->g/gdc
So the g is not needed here and makes the key smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jepenven-silabs No, the "g/" there is for "global" and all keys must start with "g/" or "f/". This is an invariant that is: (1) depended on by SDK consumers and (2) documented in this file.
0799863
to
251ddd1
Compare
PR #30705: Size comparison from 03efab5 to 251ddd1 Increases (1 build for qpg)
Full report (5 builds for cc32xx, mbed, qpg)
|
251ddd1
to
afa474a
Compare
PR #30705: Size comparison from 03efab5 to afa474a Increases (12 builds for efr32, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30705: Size comparison from 03efab5 to 5534c9a Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fix #29184
Implement a simple persistent counter for the Check-In message. The same counter is used across all fabric by design.
Since the client side needs to check if the received counter is within range and the counter, once initialized, is never reset, not much logic is needed on the Server side.