-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform] Allow to disable GenericDeviceInstanceInfoProvider #30660
Merged
mergify
merged 1 commit into
project-chip:master
from
Damian-Nordic:generic-devinstinfo
Nov 28, 2023
Merged
[platform] Allow to disable GenericDeviceInstanceInfoProvider #30660
mergify
merged 1 commit into
project-chip:master
from
Damian-Nordic:generic-devinstinfo
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GN switch to disable instantiating and configuring GenericDeviceInstanceInfoProvider to save a bit of RAM and flash.
PR #30660: Size comparison from b915f93 to 5a61f4c Decreases (11 builds for nrfconnect)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 27, 2023
andy31415
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
chip_use_transitional_device_instance_info_provider
GN switch to disable instantiating and configuringGenericDeviceInstanceInfoProvider
to save a bit of RAM and flash. Set that switch to false on nrfconnect platform with factory data provider.