Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scenes] .zap .matter attributes RAM fix #30619

Merged

Conversation

lpbeliveau-silabs
Copy link
Contributor

Converted attributes wrongfully Identified as external or having callback in both .zap and .matter files.

Copy link

github-actions bot commented Nov 22, 2023

PR #30619: Size comparison from 1bb4be5 to bd221c5

Increases (4 builds for linux, nrfconnect, psoc6, telink)
platform target config section 1bb4be5 bd221c5 change % change
linux all-clusters-minimal-app debug (read only) 4929777 4929801 24 0.0
(read/write) 234376 234408 32 0.0
.bss 127824 127856 32 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1043448 1043456 8 0.0
bss 129210 129224 14 0.0
rodata 99616 99624 8 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1701164 1701180 16 0.0
.bss 192804 192812 8 0.0
.text 1497492 1497500 8 0.0
telink all-clusters-minimal-app tlsr9528a (read/write) 1080516 1080536 20 0.0
bss 109660 109672 12 0.0
Decreases (1 build for psoc6)
platform target config section 1bb4be5 bd221c5 change % change
psoc6 all-clusters-minimal cy8ckit_062s2_43012 (read only) 838056 838048 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 1bb4be5 bd221c5 change % change
bl602 lighting-app bl602 (read/write) 1410706 1410706 0 0.0
.bss 85048 85048 0 0.0
.data 9376 9376 0 0.0
.rodata 156780 156780 0 0.0
.text 1078846 1078846 0 0.0
bl602+mfd (read/write) 1425146 1425146 0 0.0
.bss 85216 85216 0 0.0
.data 9344 9344 0 0.0
.rodata 155740 155740 0 0.0
.text 1094198 1094198 0 0.0
bl602+rpc (read/write) 1458482 1458482 0 0.0
.bss 93080 93080 0 0.0
.data 9744 9744 0 0.0
.rodata 164396 164396 0 0.0
.text 1110590 1110590 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1176851 1176851 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106524 106524 0 0.0
.text 949318 949318 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1187975 1187975 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105464 105464 0 0.0
.text 961382 961382 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1276915 1276915 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121932 121932 0 0.0
.text 1024384 1024384 0 0.0
bl706-eth (read/write) 995601 995601 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99512 99512 0 0.0
.text 741708 741708 0 0.0
bl706-wifi (read/write) 1231514 1231514 0 0.0
.bss 10657 10657 0 0.0
.data 3568 3568 0 0.0
.rodata 120464 120464 0 0.0
.text 966790 966790 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1146568 1146568 0 0.0
.bss 16408 16408 0 0.0
.data 4920 4920 0 0.0
.rodata 100528 100528 0 0.0
.text 942416 942416 0 0.0
bl702l+mfd (read/write) 1158540 1158540 0 0.0
.bss 16584 16584 0 0.0
.data 4904 4904 0 0.0
.rodata 99468 99468 0 0.0
.text 954792 954792 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740555 740555 0 0.0
(read/write) 167088 167088 0 0.0
.bss 89500 89500 0 0.0
.data 3424 3424 0 0.0
.rodata 84911 84911 0 0.0
.text 655256 655256 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757883 757883 0 0.0
(read/write) 177268 177268 0 0.0
.bss 99636 99636 0 0.0
.data 3444 3444 0 0.0
.rodata 79951 79951 0 0.0
.text 677540 677540 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744859 744859 0 0.0
(read/write) 171716 171716 0 0.0
.bss 94084 94084 0 0.0
.data 3444 3444 0 0.0
.rodata 105751 105751 0 0.0
.text 638720 638720 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 698907 698907 0 0.0
(read/write) 166124 166124 0 0.0
.bss 88304 88304 0 0.0
.data 3412 3412 0 0.0
.rodata 80679 80679 0 0.0
.text 617840 617840 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 684563 684563 0 0.0
(read/write) 166264 166264 0 0.0
.bss 88456 88456 0 0.0
.data 3408 3408 0 0.0
.rodata 76519 76519 0 0.0
.text 607656 607656 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564690 564690 0 0.0
(read/write) 207520 207520 0 0.0
.bss 200980 200980 0 0.0
.data 1416 1416 0 0.0
.rodata 83802 83802 0 0.0
.text 478768 478768 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617546 617546 0 0.0
(read/write) 207860 207860 0 0.0
.bss 201296 201296 0 0.0
.data 1444 1444 0 0.0
.rodata 105674 105674 0 0.0
.text 509752 509752 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 558519 558519 0 0.0
.app_xip_area 448881 448881 0 0.0
.bss 64552 64552 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540703 540703 0 0.0
.app_xip_area 426385 426385 0 0.0
.bss 69200 69200 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 579007 579007 0 0.0
.app_xip_area 470753 470753 0 0.0
.bss 63240 63240 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 554983 554983 0 0.0
.app_xip_area 443625 443625 0 0.0
.bss 66240 66240 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1012772 1012772 0 0.0
.bss 172464 172464 0 0.0
.data 2696 2696 0 0.0
.text 837592 837592 0 0.0
BRD4187C (read/write) 1098652 1098652 0 0.0
.bss 196092 196092 0 0.0
.data 3304 3304 0 0.0
.text 899236 899236 0 0.0
lock-app BRD4161A+wf200 (read/write) 1104680 1104680 0 0.0
.bss 187064 187064 0 0.0
.data 2708 2708 0 0.0
.text 914884 914884 0 0.0
window-app BRD4187C (read/write) 1133464 1133464 0 0.0
.bss 168444 168444 0 0.0
.data 3176 3176 0 0.0
.text 961824 961824 0 0.0
esp32 all-clusters-app c3devkit (read only) 1133426 1133426 0 0.0
(read/write) 1670956 1670956 0 0.0
.dram0.bss 72432 72432 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241656 241656 0 0.0
.flash.text 1133426 1133426 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1178335 1178335 0 0.0
(read/write) 520952 520952 0 0.0
.dram0.bss 79080 79080 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273488 273488 0 0.0
.flash.text 1172951 1172951 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 592940 592940 0 0.0
(read/write) 88104 88104 0 0.0
.bss 71344 71344 0 0.0
.data 2136 2136 0 0.0
.text 592404 592404 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688472 688472 0 0.0
.bss 67544 67544 0 0.0
.data 2720 2720 0 0.0
.text 574728 574728 0 0.0
light k32w0+release (read only) 592660 592660 0 0.0
(read/write) 87780 87780 0 0.0
.bss 71032 71032 0 0.0
.data 2124 2124 0 0.0
.text 592124 592124 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780620 780620 0 0.0
.bss 77220 77220 0 0.0
.data 1932 1932 0 0.0
.text 658008 658008 0 0.0
lock k32w0+release (read only) 564500 564500 0 0.0
(read/write) 85608 85608 0 0.0
.bss 68920 68920 0 0.0
.data 2064 2064 0 0.0
.text 563964 563964 0 0.0
linux air-purifier-app debug (read only) 2503901 2503901 0 0.0
(read/write) 126832 126832 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72408 72408 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 177704 177704 0 0.0
.text 2151701 2151701 0 0.0
all-clusters-app debug (read only) 5327345 5327345 0 0.0
(read/write) 429856 429856 0 0.0
.bss 130032 130032 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 288736 288736 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 302812 302812 0 0.0
.text 4636099 4636099 0 0.0
all-clusters-minimal-app debug (read only) 4929777 4929801 24 0.0
(read/write) 234376 234408 32 0.0
.bss 127824 127856 32 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95616 95616 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 271053 271053 0 0.0
.text 4426947 4426947 0 0.0
bridge-app debug (read only) 4402673 4402673 0 0.0
(read/write) 215680 215680 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84992 84992 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 218741 218741 0 0.0
.text 3965907 3965907 0 0.0
chip-tool debug (read only) 10749121 10749121 0 0.0
(read/write) 465424 465424 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 359112 359112 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 401193 401193 0 0.0
.text 9718691 9718691 0 0.0
chip-tool-ipv6only arm64 (read only) 10599880 10599880 0 0.0
(read/write) 530664 530664 0 0.0
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 397000 397000 0 0.0
.dynamic 512 512 0 0.0
.got 18960 18960 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 325248 325248 0 0.0
.text 9470856 9470856 0 0.0
lighting-app debug+rpc+ui (read only) 5273625 5273625 0 0.0
(read/write) 224400 224400 0 0.0
.bss 119168 119168 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93248 93248 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 338324 338324 0 0.0
.text 4691395 4691395 0 0.0
lock-app debug (read only) 4487801 4487801 0 0.0
(read/write) 203296 203296 0 0.0
.bss 113632 113632 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79272 79272 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246677 246677 0 0.0
.text 4031587 4031587 0 0.0
ota-provider-app debug (read only) 4151801 4151801 0 0.0
(read/write) 192448 192448 0 0.0
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68976 68976 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200981 200981 0 0.0
.text 3759491 3759491 0 0.0
ota-requestor-app debug (read only) 4238137 4238137 0 0.0
(read/write) 196696 196696 0 0.0
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 71952 71952 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204789 204789 0 0.0
.text 3837715 3837715 0 0.0
shell debug (read only) 2768337 2768337 0 0.0
(read/write) 149736 149736 0 0.0
.bss 60680 60680 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82464 82464 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 181056 181056 0 0.0
.text 2416594 2416594 0 0.0
thermostat-no-ble arm64 (read only) 4388976 4388976 0 0.0
(read/write) 245176 245176 0 0.0
.bss 122248 122248 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102048 102048 0 0.0
.dynamic 512 512 0 0.0
.got 11944 11944 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161932 161932 0 0.0
.text 3887464 3887464 0 0.0
tv-app debug (read only) 5275185 5275185 0 0.0
(read/write) 345464 345464 0 0.0
.bss 242688 242688 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90480 90480 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 267709 267709 0 0.0
.text 4772451 4772451 0 0.0
tv-casting-app debug (read only) 8686921 8686921 0 0.0
(read/write) 322336 322336 0 0.0
.bss 156256 156256 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 156768 156768 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 346856 346856 0 0.0
.text 7916291 7916291 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523296 2523296 0 0.0
.bss 220032 220032 0 0.0
.data 5136 5136 0 0.0
.text 1485980 1485980 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058232 1058232 0 0.0
bss 128931 128931 0 0.0
rodata 104360 104360 0 0.0
text 777304 777304 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1184576 1184576 0 0.0
bss 121133 121133 0 0.0
rodata 138296 138296 0 0.0
text 774820 774820 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043448 1043456 8 0.0
bss 129210 129224 14 0.0
rodata 99616 99624 8 0.0
text 766980 766980 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836328 836328 0 0.0
(read/write) 1737348 1737348 0 0.0
.bss 194532 194532 0 0.0
.data 2480 2480 0 0.0
.text 1531948 1531948 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838056 838048 -8 -0.0
(read/write) 1701164 1701180 16 0.0
.bss 192804 192812 8 0.0
.data 2480 2480 0 0.0
.text 1497492 1497500 8 0.0
light cy8ckit_062s2_43012 (read only) 844736 844736 0 0.0
(read/write) 1627252 1627252 0 0.0
.bss 186236 186236 0 0.0
.data 2368 2368 0 0.0
.text 1430260 1430260 0 0.0
lock cy8ckit_062s2_43012 (read only) 817664 817664 0 0.0
(read/write) 1654260 1654260 0 0.0
.bss 213292 213292 0 0.0
.data 2384 2384 0 0.0
.text 1430196 1430196 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1114752 1114752 0 0.0
.bss 101168 101168 0 0.0
.data 748 748 0 0.0
.text 627128 627128 0 0.0
lock-app qpg6105+debug (read/write) 1076060 1076060 0 0.0
.bss 95936 95936 0 0.0
.data 780 780 0 0.0
.text 588436 588436 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817822 817822 0 0.0
bss 53708 53708 0 0.0
text 611140 611140 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1075732 1075732 0 0.0
bss 99976 99976 0 0.0
text 758360 758360 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1080516 1080536 20 0.0
bss 109660 109672 12 0.0
text 749946 749946 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932804 932804 0 0.0
bss 94180 94180 0 0.0
text 644882 644882 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817942 817942 0 0.0
bss 53760 53760 0 0.0
text 611356 611356 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 972012 972012 0 0.0
bss 77580 77580 0 0.0
text 689274 689274 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1090416 1090416 0 0.0
bss 99744 99744 0 0.0
text 767070 767070 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 958732 958732 0 0.0
bss 95832 95832 0 0.0
text 643338 643338 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 946012 946012 0 0.0
bss 92288 92288 0 0.0
text 660550 660550 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 874304 874304 0 0.0
bss 67596 67596 0 0.0
text 617762 617762 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 814988 814988 0 0.0
bss 55832 55832 0 0.0
text 584716 584716 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 830688 830688 0 0.0
bss 56244 56244 0 0.0
text 595324 595324 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 706192 706192 0 0.0
bss 73620 73620 0 0.0
text 462342 462342 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819666 819666 0 0.0
bss 53844 53844 0 0.0
text 614080 614080 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871701 871701 0 0.0
bss 59308 59308 0 0.0
text 626068 626068 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 839040 839040 0 0.0
bss 56128 56128 0 0.0
text 602882 602882 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 833548 833548 0 0.0
bss 56480 56480 0 0.0
text 597116 597116 0 0.0

@mergify mergify bot merged commit a454ccd into project-chip:master Nov 23, 2023
57 checks passed
@lpbeliveau-silabs lpbeliveau-silabs deleted the bugfix/scenes_attributes_ram branch December 10, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants