-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Create ICDConfigurationData class with associated refactor #30618
[ICD] Create ICDConfigurationData class with associated refactor #30618
Conversation
10a8c86
to
3095155
Compare
PR #30618: Size comparison from 1bb4be5 to 3095155 Full report (10 builds for bl602, bl702, bl702l)
|
PR #30618: Size comparison from 1bb4be5 to 06b663a Full report (10 builds for bl602, bl702, bl702l)
|
a720e21
to
527445c
Compare
PR #30618: Size comparison from 1b16ca3 to 527445c Full report (12 builds for bl602, bl702, bl702l, linux)
|
59b3821
to
97a6e1e
Compare
Co-authored-by: Boris Zbarsky <[email protected]>
da9450c
to
2e2f2ea
Compare
PR #30618: Size comparison from ed891e2 to 1a8efa7 Increases above 0.2%:
Increases (4 builds for cc13x4_26x4, cc32xx, mbed)
Decreases (1 build for cc13x4_26x4)
Full report (16 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect)
|
PR #30618: Size comparison from ed891e2 to 83e9207 Increases above 0.2%:
Increases (10 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg)
Decreases (4 builds for cc13x4_26x4, cyw30739, psoc6)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #30618: Size comparison from ed891e2 to 16cdb44 Increases above 0.2%:
Increases (1 build for cc32xx)
Full report (2 builds for cc32xx)
|
replace pointer with instance call
16cdb44
to
ea2d1ae
Compare
PR #30618: Size comparison from 28c679c to ea2d1ae Increases above 0.2%:
Increases (20 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
Decreases (11 builds for cc13x4_26x4, cyw30739, psoc6, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Description
Implementation of the ICD feature set created a circular dependencie issue which was caused by the ICDManager needing to send Check-In messages and being the owner of the Fast Poll configuration that is used by the ReliableMessageMgr.
This was also a problem for the ReliableMessageProtocolConfig which requires the Fast poll config, slow poll config owned by the ICD Manager"
To circumvent the issue, this PR adds the ICDData class that will own all the configurations. This will allow all the consumers to depend on this class for the data without causing a circular dependency. Having the ICDData class also allows us to simplify the icd-management-cluster since it is not longuer required for it to manage data.
fixes #30527
fixes #30240
fixes #29289
fixes #24289
Tests
PR does not change the behvior of the current implementation.
CI to validate behavior is unchanged.