-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'cluster side' from matter IDL files #30605
Merged
mergify
merged 30 commits into
project-chip:master
from
andy31415:no_client_server_cluster
Nov 28, 2023
Merged
Remove 'cluster side' from matter IDL files #30605
mergify
merged 30 commits into
project-chip:master
from
andy31415:no_client_server_cluster
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cares about client/server status
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn and
Damian-Nordic
November 21, 2023 19:26
PR #30605: Size comparison from 971e060 to 413e854 Increases (6 builds for cc13x4_26x4, cyw30739, efr32, linux, mbed)
Decreases (25 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #30605: Size comparison from 971e060 to f0c8ce4 Increases (3 builds for cc13x4_26x4, mbed)
Decreases (13 builds for cc13x4_26x4, cc32xx, k32w, nrfconnect, qpg)
Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #30605: Size comparison from 971e060 to 0b14bd9 Increases (1 build for mbed)
Decreases (4 builds for cc32xx, qpg)
Full report (5 builds for cc32xx, mbed, qpg)
|
PR #30605: Size comparison from 971e060 to e5ad825 Increases (8 builds for cc13x4_26x4, cyw30739, efr32, linux, mbed, telink)
Decreases (51 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Nov 22, 2023
PR #30605: Size comparison from ac1536d to b9b5af8 Increases (9 builds for cc13x4_26x4, cyw30739, efr32, linux, mbed, telink)
Decreases (47 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30605: Size comparison from b74fef0 to 0cfe4cd Increases (10 builds for cc13x4_26x4, cyw30739, efr32, linux, mbed, telink)
Decreases (48 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30605: Size comparison from 14d7054 to 470d4c3 Increases (9 builds for cc13x4_26x4, cyw30739, efr32, linux, mbed, telink)
Decreases (50 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZAP has client and server clusters in its definitons, however the matter data model just has "clusters" and the instantiations on endpoints define if a cluster shows up on an endpoint or not as well as what it exposes (what attributes, events and commands).
This is to prepare for using CSA Data Model XML - those XMLs only define the data model and don't have a client/server side.
Changes:
Once project-chip/zap#1216 can be used, we will be able to remove support for cluster duplication.