-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a counter trace macro to the tracing for getting insights from counters in chip and implemented the macro for ESP32 platform... #30591
Conversation
f0263e1
to
925eb56
Compare
PR #30591: Size comparison from a3c5d19 to 925eb56 Increases (14 builds for esp32, linux)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offline discussion: counters are useful, however I am asking for this to not become a "only one backend ever supports this".
If we are to add counter support, other backends should too. In particular perfetto has counters (I see TRACE_COUNTER
exists) and having logging have something probably also works (e.g. it could be a static atomic variable that gets logged on every call).
925eb56
to
cbf5507
Compare
PR #30591: Size comparison from 8e3d98c to cbf5507 Increases (14 builds for esp32, linux)
Decreases (3 builds for efr32, linux)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
cbf5507
to
f055605
Compare
PR #30591: Size comparison from 4fe0f8d to 21bdb63 Increases above 0.2%:
Increases (14 builds for esp32, linux)
Decreases (5 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
21bdb63
to
cfb0e5f
Compare
PR #30591: Size comparison from e49c56d to 986e61d Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
986e61d
to
7522efe
Compare
PR #30591: Size comparison from e49c56d to 7522efe Increases (14 builds for esp32, linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
7522efe
to
0cae929
Compare
PR #30591: Size comparison from 711ca50 to 94828a9 Increases above 0.2%:
Increases (14 builds for esp32, linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
94828a9
to
e73b27f
Compare
PR #30591: Size comparison from 0bcb061 to e73b27f Increases above 0.2%:
Increases (14 builds for esp32, linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
e73b27f
to
24367ed
Compare
PR #30591: Size comparison from f59323b to 24367ed Increases above 0.2%:
Increases (12 builds for linux)
Decreases (2 builds for linux)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
24367ed
to
11bafe1
Compare
…ne and multiplexed
a986b77
to
f56c30d
Compare
PR #30591: Size comparison from b389c60 to f56c30d Increases above 0.2%:
Increases (12 builds for linux)
Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested after checking if previous comments were resolved or not:
- specifically "group" is part of the macro invocation however it is not used for counter naming and as a result it can create overlapping counters (e.g.
MATTER_TRACE_COUNTER("ABC", "A");
andMATTER_TRACE_COUNTER("ABC", "B");
would create the same perfetto counter and would probably report the same in esp. This is not ok. Either group should be used, or, more likely, group argument should be dropped.
PR #30591: Size comparison from b389c60 to 21e8cb6 Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (13 builds for bl702l, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #30591: Size comparison from b389c60 to 4fc8ddb Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (12 builds for bl702l, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Change Overview:
Testing
Tested the ESP32 lighting app with and without tracing enabled and checked for the behaviour.