Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Dryer device type #30584

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Adding Dryer device type #30584

merged 2 commits into from
Nov 28, 2023

Conversation

eahove
Copy link
Contributor

@eahove eahove commented Nov 20, 2023

This PR adds only the device type to the SDK.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited
Loading

PR #30584: Size comparison from 2899e70 to 55f0f79

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2899e70 55f0f79 change % change
bl602 lighting-app bl602 (read/write) 1410582 1410582 0 0.0
.bss 85048 85048 0 0.0
.data 9376 9376 0 0.0
.rodata 156688 156688 0 0.0
.text 1078810 1078810 0 0.0
bl602+mfd (read/write) 1425022 1425022 0 0.0
.bss 85216 85216 0 0.0
.data 9344 9344 0 0.0
.rodata 155648 155648 0 0.0
.text 1094162 1094162 0 0.0
bl602+rpc (read/write) 1458366 1458366 0 0.0
.bss 93080 93080 0 0.0
.data 9744 9744 0 0.0
.rodata 164312 164312 0 0.0
.text 1110554 1110554 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1176731 1176731 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106436 106436 0 0.0
.text 949286 949286 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1187599 1187599 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105376 105376 0 0.0
.text 961094 961094 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1276795 1276795 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121844 121844 0 0.0
.text 1024352 1024352 0 0.0
bl706-eth (read/write) 995593 995593 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99504 99504 0 0.0
.text 741708 741708 0 0.0
bl706-wifi (read/write) 1231390 1231390 0 0.0
.bss 10657 10657 0 0.0
.data 3568 3568 0 0.0
.rodata 120376 120376 0 0.0
.text 966754 966754 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1146448 1146448 0 0.0
.bss 16408 16408 0 0.0
.data 4920 4920 0 0.0
.rodata 100440 100440 0 0.0
.text 942384 942384 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1157908 1157908 0 0.0
.bss 16584 16584 0 0.0
.data 4904 4904 0 0.0
.rodata 99380 99380 0 0.0
.text 954760 954760 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740387 740387 0 0.0
(read/write) 167088 167088 0 0.0
.bss 89500 89500 0 0.0
.data 3424 3424 0 0.0
.rodata 84831 84831 0 0.0
.text 655168 655168 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757827 757827 0 0.0
(read/write) 177268 177268 0 0.0
.bss 99636 99636 0 0.0
.data 3444 3444 0 0.0
.rodata 79951 79951 0 0.0
.text 677484 677484 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744699 744699 0 0.0
(read/write) 171716 171716 0 0.0
.bss 94084 94084 0 0.0
.data 3444 3444 0 0.0
.rodata 105679 105679 0 0.0
.text 638632 638632 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 698747 698747 0 0.0
(read/write) 166124 166124 0 0.0
.bss 88304 88304 0 0.0
.data 3412 3412 0 0.0
.rodata 80607 80607 0 0.0
.text 617752 617752 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 684403 684403 0 0.0
(read/write) 166264 166264 0 0.0
.bss 88456 88456 0 0.0
.data 3408 3408 0 0.0
.rodata 76447 76447 0 0.0
.text 607568 607568 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 565290 565290 0 0.0
(read/write) 207520 207520 0 0.0
.bss 200980 200980 0 0.0
.data 1416 1416 0 0.0
.rodata 83866 83866 0 0.0
.text 479300 479300 0 0.0
lock CC3235SF_LAUNCHXL (read only) 617546 617546 0 0.0
(read/write) 207860 207860 0 0.0
.bss 201296 201296 0 0.0
.data 1444 1444 0 0.0
.rodata 105674 105674 0 0.0
.text 509752 509752 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 558455 558455 0 0.0
.app_xip_area 448817 448817 0 0.0
.bss 64552 64552 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540631 540631 0 0.0
.app_xip_area 426313 426313 0 0.0
.bss 69200 69200 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578807 578807 0 0.0
.app_xip_area 470553 470553 0 0.0
.bss 63240 63240 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 554871 554871 0 0.0
.app_xip_area 443513 443513 0 0.0
.bss 66240 66240 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1012580 1012580 0 0.0
.bss 172464 172464 0 0.0
.data 2696 2696 0 0.0
.text 837400 837400 0 0.0
BRD4187C (read/write) 1098460 1098460 0 0.0
.bss 196092 196092 0 0.0
.data 3304 3304 0 0.0
.text 899044 899044 0 0.0
lock-app BRD4161A+wf200 (read/write) 1104632 1104632 0 0.0
.bss 187064 187064 0 0.0
.data 2708 2708 0 0.0
.text 914836 914836 0 0.0
window-app BRD4187C (read/write) 1133272 1133272 0 0.0
.bss 168444 168444 0 0.0
.data 3176 3176 0 0.0
.text 961632 961632 0 0.0
esp32 all-clusters-app c3devkit (read only) 1133232 1133232 0 0.0
(read/write) 1670868 1670868 0 0.0
.dram0.bss 72432 72432 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241568 241568 0 0.0
.flash.text 1133232 1133232 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1178135 1178135 0 0.0
(read/write) 520872 520872 0 0.0
.dram0.bss 79080 79080 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273408 273408 0 0.0
.flash.text 1172751 1172751 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 592828 592828 0 0.0
(read/write) 88104 88104 0 0.0
.bss 71344 71344 0 0.0
.data 2136 2136 0 0.0
.text 592292 592292 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688296 688296 0 0.0
.bss 67544 67544 0 0.0
.data 2720 2720 0 0.0
.text 574552 574552 0 0.0
light k32w0+release (read only) 592532 592532 0 0.0
(read/write) 87780 87780 0 0.0
.bss 71032 71032 0 0.0
.data 2124 2124 0 0.0
.text 591996 591996 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780428 780428 0 0.0
.bss 77220 77220 0 0.0
.data 1932 1932 0 0.0
.text 657816 657816 0 0.0
lock k32w0+release (read only) 564372 564372 0 0.0
(read/write) 85608 85608 0 0.0
.bss 68920 68920 0 0.0
.data 2064 2064 0 0.0
.text 563836 563836 0 0.0
linux air-purifier-app debug (read only) 2504989 2504989 0 0.0
(read/write) 126832 126832 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72408 72408 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 177512 177512 0 0.0
.text 2152981 2152981 0 0.0
all-clusters-app debug (read only) 5326449 5326449 0 0.0
(read/write) 429888 429888 0 0.0
.bss 130032 130032 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 288752 288752 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 302556 302556 0 0.0
.text 4635459 4635459 0 0.0
all-clusters-minimal-app debug (read only) 4928929 4928929 0 0.0
(read/write) 234376 234376 0 0.0
.bss 127824 127824 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95616 95616 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 270765 270765 0 0.0
.text 4426387 4426387 0 0.0
bridge-app debug (read only) 4401857 4401857 0 0.0
(read/write) 215680 215680 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84992 84992 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 218485 218485 0 0.0
.text 3965347 3965347 0 0.0
chip-tool debug (read only) 10745225 10745225 0 0.0
(read/write) 465416 465416 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 359112 359112 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 400809 400809 0 0.0
.text 9715203 9715203 0 0.0
chip-tool-ipv6only arm64 (read only) 10596616 10596616 0 0.0
(read/write) 529776 529776 0 0.0
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 396976 396976 0 0.0
.dynamic 512 512 0 0.0
.got 18960 18960 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 325024 325024 0 0.0
.text 9467832 9467832 0 0.0
lighting-app debug+rpc+ui (read only) 5272777 5272777 0 0.0
(read/write) 224400 224400 0 0.0
.bss 119168 119168 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93248 93248 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 338036 338036 0 0.0
.text 4690835 4690835 0 0.0
lock-app debug (read only) 4487033 4487033 0 0.0
(read/write) 203296 203296 0 0.0
.bss 113632 113632 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79272 79272 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246453 246453 0 0.0
.text 4031043 4031043 0 0.0
ota-provider-app debug (read only) 4151177 4151177 0 0.0
(read/write) 192448 192448 0 0.0
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68976 68976 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200821 200821 0 0.0
.text 3759027 3759027 0 0.0
ota-requestor-app debug (read only) 4237481 4237481 0 0.0
(read/write) 196696 196696 0 0.0
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 71952 71952 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204597 204597 0 0.0
.text 3837251 3837251 0 0.0
shell debug (read only) 2767905 2767905 0 0.0
(read/write) 149736 149736 0 0.0
.bss 60680 60680 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82464 82464 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 180800 180800 0 0.0
.text 2416418 2416418 0 0.0
thermostat-no-ble arm64 (read only) 4388528 4388528 0 0.0
(read/write) 245592 245592 0 0.0
.bss 122248 122248 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102048 102048 0 0.0
.dynamic 512 512 0 0.0
.got 11944 11944 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161900 161900 0 0.0
.text 3887048 3887048 0 0.0
tv-app debug (read only) 5271025 5271025 0 0.0
(read/write) 345208 345208 0 0.0
.bss 242432 242432 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90480 90480 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 267261 267261 0 0.0
.text 4768739 4768739 0 0.0
tv-casting-app debug (read only) 8686425 8686425 0 0.0
(read/write) 322368 322368 0 0.0
.bss 156288 156288 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 156768 156768 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 346664 346664 0 0.0
.text 7915987 7915987 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523088 2523088 0 0.0
.bss 220032 220032 0 0.0
.data 5136 5136 0 0.0
.text 1485772 1485772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1058012 1058012 0 0.0
bss 128931 128931 0 0.0
rodata 104284 104284 0 0.0
text 777160 777160 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1184464 1184464 0 0.0
bss 121133 121133 0 0.0
rodata 138296 138296 0 0.0
text 774708 774708 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1043288 1043288 0 0.0
bss 129210 129210 0 0.0
rodata 99536 99536 0 0.0
text 766888 766888 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836328 836328 0 0.0
(read/write) 1737124 1737124 0 0.0
.bss 194532 194532 0 0.0
.data 2480 2480 0 0.0
.text 1531724 1531724 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838056 838056 0 0.0
(read/write) 1700964 1700964 0 0.0
.bss 192804 192804 0 0.0
.data 2480 2480 0 0.0
.text 1497292 1497292 0 0.0
light cy8ckit_062s2_43012 (read only) 844736 844736 0 0.0
(read/write) 1627068 1627068 0 0.0
.bss 186236 186236 0 0.0
.data 2368 2368 0 0.0
.text 1430076 1430076 0 0.0
lock cy8ckit_062s2_43012 (read only) 817664 817664 0 0.0
(read/write) 1654076 1654076 0 0.0
.bss 213292 213292 0 0.0
.data 2384 2384 0 0.0
.text 1430012 1430012 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1114560 1114560 0 0.0
.bss 101168 101168 0 0.0
.data 748 748 0 0.0
.text 626936 626936 0 0.0
lock-app qpg6105+debug (read/write) 1075700 1075700 0 0.0
.bss 95936 95936 0 0.0
.data 780 780 0 0.0
.text 588076 588076 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817426 817426 0 0.0
bss 53700 53700 0 0.0
text 610942 610942 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1075500 1075500 0 0.0
bss 99976 99976 0 0.0
text 758212 758212 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1080340 1080340 0 0.0
bss 109660 109660 0 0.0
text 749848 749848 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932628 932628 0 0.0
bss 94180 94180 0 0.0
text 644784 644784 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817554 817554 0 0.0
bss 53752 53752 0 0.0
text 611158 611158 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 971584 971584 0 0.0
bss 77572 77572 0 0.0
text 689030 689030 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1090240 1090240 0 0.0
bss 99744 99744 0 0.0
text 766972 766972 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 958344 958344 0 0.0
bss 95824 95824 0 0.0
text 643144 643144 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945836 945836 0 0.0
bss 92288 92288 0 0.0
text 660452 660452 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 873916 873916 0 0.0
bss 67588 67588 0 0.0
text 617568 617568 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 814608 814608 0 0.0
bss 55832 55832 0 0.0
text 584522 584522 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 830300 830300 0 0.0
bss 56236 56236 0 0.0
text 595130 595130 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 706192 706192 0 0.0
bss 73620 73620 0 0.0
text 462342 462342 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819286 819286 0 0.0
bss 53844 53844 0 0.0
text 613882 613882 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871313 871313 0 0.0
bss 59300 59300 0 0.0
text 625874 625874 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838652 838652 0 0.0
bss 56120 56120 0 0.0
text 602688 602688 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 833160 833160 0 0.0
bss 56472 56472 0 0.0
text 596922 596922 0 0.0

@eahove eahove marked this pull request as ready for review November 20, 2023 23:49
cecille
cecille reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@cecille cecille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: how did you test this?

Just checking the setup here - it looks like serverLocked corresponds to optional/mandatory (ie, does this control if the GUI is changeable?) Are server and client the defaults for zap? What does lockOthers control?

If my description above is accurate, this looks correct, I just want to confirm before checkmarking.

@eahove
Copy link
Contributor Author

eahove commented Nov 27, 2023

Q: how did you test this?

Just checking the setup here - it looks like serverLocked corresponds to optional/mandatory (ie, does this control if the GUI is changeable?) Are server and client the defaults for zap? What does lockOthers control?

If my description above is accurate, this looks correct, I just want to confirm before checkmarking.

This is based on the device definition for the MA-laundry-washer which is part of the previous spec. The two devices are basically the same, just differing by a slight rename of 2 of the clusters.

@woody-apple woody-apple added this to the 1.3 Feature Complete milestone Nov 27, 2023
@mergify mergify bot merged commit 8f76c06 into project-chip:master Nov 28, 2023
57 checks passed
bzbarsky-apple
bzbarsky-apple reviewed Dec 7, 2023
View reviewed changes
src/app/zap-templates/zcl/data-model/chip/matter-devices.xml
<include cluster="Identify" client="false" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true"></include>
<include cluster="On/Off" client="false" server="false" clientLocked="true" serverLocked="false"></include>
<include cluster="Laundry Mode" client="false" server="false" clientLocked="true" serverLocked="false"></include>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But ... there is no "Laundry Mode" cluster in Matter XML, and this does not match the current spec either. @eahove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@cecille cecille cecille approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin review - approved
Projects
[1.3] SDK Feature Complete
Status: Done
[Platform] Darwin
Status: Done
Milestone
1.3 Feature Complete
Development

Successfully merging this pull request may close these issues.
4 participants
@eahove @cecille @woody-apple @bzbarsky-apple