Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operational advertising in chip-tool. #30457

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix operational advertising in chip-tool. #30457

merged 1 commit into from
Nov 14, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

chip-tool was never setting enableServerInteractions on the commissioner params, and it happened to work as long as we unconditionally advertised everything as long as server interactions were enabled on the factory, even if specific commissioners did not want to enable server interactions.

Now that this is properly controller per-commissioner, we need to actually set the boolean we should have been setting all along.

@bzbarsky-apple
Fix operational advertising in chip-tool.
ccf0d1b 
chip-tool was never setting enableServerInteractions on the commissioner params,
and it happened to work as long as we unconditionally advertised everything
as long as server interactions were enabled on the factory, even if specific
commissioners did not want to enable server interactions.

Now that this is properly controller per-commissioner, we need to actually set
the boolean we should have been setting all along.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

PR #30457: Size comparison from 7c71cb5 to ccf0d1b

Increases above 0.2%:

platform target config section 7c71cb5 ccf0d1b change % change
linux chip-tool-ipv6only arm64 (read/write) 512864 516032 3168 0.6
Increases (3 builds for linux)
platform target config section 7c71cb5 ccf0d1b change % change
linux chip-tool debug (read only) 10363545 10363705 160 0.0
.text 9365699 9365859 160 0.0
chip-tool-ipv6only arm64 (read/write) 512864 516032 3168 0.6
tv-casting-app debug (read only) 8301577 8301625 48 0.0
.text 7553395 7553443 48 0.0
Decreases (1 build for linux)
platform target config section 7c71cb5 ccf0d1b change % change
linux chip-tool-ipv6only arm64 (read only) 10240624 10237456 -3168 -0.0
.text 9143784 9140616 -3168 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7c71cb5 ccf0d1b change % change
bl602 lighting-app bl602 (read/write) 1408030 1408030 0 0.0
.bss 84504 84504 0 0.0
.data 9376 9376 0 0.0
.rodata 156408 156408 0 0.0
.text 1077084 1077084 0 0.0
bl602+mfd (read/write) 1422470 1422470 0 0.0
.bss 84672 84672 0 0.0
.data 9344 9344 0 0.0
.rodata 155368 155368 0 0.0
.text 1092436 1092436 0 0.0
bl602+rpc (read/write) 1455814 1455814 0 0.0
.bss 92536 92536 0 0.0
.data 9744 9744 0 0.0
.rodata 164032 164032 0 0.0
.text 1108828 1108828 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1174191 1174191 0 0.0
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106148 106148 0 0.0
.text 947578 947578 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1185315 1185315 0 0.0
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105088 105088 0 0.0
.text 959642 959642 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1274255 1274255 0 0.0
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121556 121556 0 0.0
.text 1022644 1022644 0 0.0
bl706-eth (read/write) 993125 993125 0 0.0
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99236 99236 0 0.0
.text 740050 740050 0 0.0
bl706-wifi (read/write) 1228566 1228566 0 0.0
.bss 10657 10657 0 0.0
.data 3568 3568 0 0.0
.rodata 120096 120096 0 0.0
.text 964756 964756 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1143904 1143904 0 0.0
.bss 16408 16408 0 0.0
.data 4920 4920 0 0.0
.rodata 100152 100152 0 0.0
.text 940672 940672 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1155364 1155364 0 0.0
.bss 16584 16584 0 0.0
.data 4904 4904 0 0.0
.rodata 99092 99092 0 0.0
.text 953048 953048 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 737763 737763 0 0.0
(read/write) 166528 166528 0 0.0
.bss 88940 88940 0 0.0
.data 3424 3424 0 0.0
.rodata 84647 84647 0 0.0
.text 652728 652728 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759467 759467 0 0.0
(read/write) 176820 176820 0 0.0
.bss 99188 99188 0 0.0
.data 3444 3444 0 0.0
.rodata 80223 80223 0 0.0
.text 678852 678852 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746755 746755 0 0.0
(read/write) 171276 171276 0 0.0
.bss 93644 93644 0 0.0
.data 3444 3444 0 0.0
.rodata 106279 106279 0 0.0
.text 640084 640084 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 697531 697531 0 0.0
(read/write) 165628 165628 0 0.0
.bss 87808 87808 0 0.0
.data 3412 3412 0 0.0
.rodata 80415 80415 0 0.0
.text 616728 616728 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 683211 683211 0 0.0
(read/write) 165760 165760 0 0.0
.bss 87952 87952 0 0.0
.data 3408 3408 0 0.0
.rodata 76247 76247 0 0.0
.text 606576 606576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564322 564322 0 0.0
(read/write) 206496 206496 0 0.0
.bss 199956 199956 0 0.0
.data 1416 1416 0 0.0
.rodata 83682 83682 0 0.0
.text 478516 478516 0 0.0
lock CC3235SF_LAUNCHXL (read only) 620578 620578 0 0.0
(read/write) 206900 206900 0 0.0
.bss 200336 200336 0 0.0
.data 1444 1444 0 0.0
.rodata 106298 106298 0 0.0
.text 512160 512160 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 555063 555063 0 0.0
.app_xip_area 446137 446137 0 0.0
.bss 63840 63840 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 541215 541215 0 0.0
.app_xip_area 427489 427489 0 0.0
.bss 68608 68608 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576911 576911 0 0.0
.app_xip_area 469313 469313 0 0.0
.bss 62584 62584 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 552927 552927 0 0.0
.app_xip_area 442241 442241 0 0.0
.bss 65568 65568 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1009020 1009020 0 0.0
.bss 171920 171920 0 0.0
.data 2696 2696 0 0.0
.text 834384 834384 0 0.0
BRD4187C (read/write) 1095204 1095204 0 0.0
.bss 195564 195564 0 0.0
.data 3304 3304 0 0.0
.text 896316 896316 0 0.0
lock-app BRD4161A+wf200 (read/write) 1105696 1105696 0 0.0
.bss 186640 186640 0 0.0
.data 2712 2712 0 0.0
.text 916324 916324 0 0.0
window-app BRD4187C (read/write) 1131432 1131432 0 0.0
.bss 167972 167972 0 0.0
.data 3176 3176 0 0.0
.text 960264 960264 0 0.0
esp32 all-clusters-app c3devkit (read only) 1130404 1130404 0 0.0
(read/write) 1670084 1670084 0 0.0
.dram0.bss 71848 71848 0 0.0
.dram0.data 12996 12996 0 0.0
.flash.rodata 241360 241360 0 0.0
.flash.text 1130404 1130404 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1175471 1175471 0 0.0
(read/write) 520080 520080 0 0.0
.dram0.bss 78496 78496 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 273200 273200 0 0.0
.flash.text 1170087 1170087 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 591756 591756 0 0.0
(read/write) 87600 87600 0 0.0
.bss 70840 70840 0 0.0
.data 2136 2136 0 0.0
.text 591220 591220 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 686832 686832 0 0.0
.bss 67040 67040 0 0.0
.data 2720 2720 0 0.0
.text 573592 573592 0 0.0
light k32w0+release (read only) 591444 591444 0 0.0
(read/write) 87276 87276 0 0.0
.bss 70528 70528 0 0.0
.data 2124 2124 0 0.0
.text 590908 590908 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 778836 778836 0 0.0
.bss 76716 76716 0 0.0
.data 1932 1932 0 0.0
.text 656728 656728 0 0.0
lock k32w0+release (read only) 563276 563276 0 0.0
(read/write) 85104 85104 0 0.0
.bss 68416 68416 0 0.0
.data 2064 2064 0 0.0
.text 562740 562740 0 0.0
linux air-purifier-app debug (read only) 2479645 2479645 0 0.0
(read/write) 126352 126352 0 0.0
.bss 46720 46720 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72168 72168 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 177512 177512 0 0.0
.text 2128213 2128213 0 0.0
all-clusters-app debug (read only) 5281241 5281241 0 0.0
(read/write) 418872 418872 0 0.0
.bss 128944 128944 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 278832 278832 0 0.0
.dynamic 624 624 0 0.0
.got 5368 5368 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 299868 299868 0 0.0
.text 4601587 4601587 0 0.0
all-clusters-minimal-app debug (read only) 4894297 4894297 0 0.0
(read/write) 233152 233152 0 0.0
.bss 126768 126768 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95440 95440 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 270413 270413 0 0.0
.text 4392675 4392675 0 0.0
bridge-app debug (read only) 4376449 4376449 0 0.0
(read/write) 215200 215200 0 0.0
.bss 118968 118968 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 84768 84768 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 218485 218485 0 0.0
.text 3940211 3940211 0 0.0
chip-tool debug (read only) 10363545 10363705 160 0.0
(read/write) 448968 448968 0 0.0
.bss 93816 93816 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 342920 342920 0 0.0
.dynamic 624 624 0 0.0
.got 5800 5800 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 391945 391945 0 0.0
.text 9365699 9365859 160 0.0
chip-tool-ipv6only arm64 (read only) 10240624 10237456 -3168 -0.0
(read/write) 512864 516032 3168 0.6
.bss 103144 103144 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 380432 380432 0 0.0
.dynamic 512 512 0 0.0
.got 18624 18624 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 317800 317800 0 0.0
.text 9143784 9140616 -3168 -0.0
lighting-app debug+rpc+ui (read only) 5239969 5239969 0 0.0
(read/write) 223368 223368 0 0.0
.bss 118432 118432 0 0.0
.data 4384 4384 0 0.0
.data.rel.ro 92976 92976 0 0.0
.dynamic 672 672 0 0.0
.got 5912 5912 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 338068 338068 0 0.0
.text 4658579 4658579 0 0.0
lock-app debug (read only) 4476105 4476105 0 0.0
(read/write) 203344 203344 0 0.0
.bss 113504 113504 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79432 79432 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 247765 247765 0 0.0
.text 4018627 4018627 0 0.0
ota-provider-app debug (read only) 4133369 4133369 0 0.0
(read/write) 192192 192192 0 0.0
.bss 113568 113568 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 68784 68784 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200309 200309 0 0.0
.text 3742211 3742211 0 0.0
ota-requestor-app debug (read only) 4219657 4219657 0 0.0
(read/write) 196440 196440 0 0.0
.bss 114592 114592 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 71744 71744 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204053 204053 0 0.0
.text 3820451 3820451 0 0.0
shell debug (read only) 2743313 2743313 0 0.0
(read/write) 148576 148576 0 0.0
.bss 59592 59592 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82400 82400 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 179616 179616 0 0.0
.text 2393778 2393778 0 0.0
thermostat-no-ble arm64 (read only) 4371928 4371928 0 0.0
(read/write) 245768 245768 0 0.0
.bss 122184 122184 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 101776 101776 0 0.0
.dynamic 512 512 0 0.0
.got 11928 11928 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161540 161540 0 0.0
.text 3871384 3871384 0 0.0
tv-app debug (read only) 5245489 5245489 0 0.0
(read/write) 344664 344664 0 0.0
.bss 242112 242112 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90240 90240 0 0.0
.dynamic 624 624 0 0.0
.got 5536 5536 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 267261 267261 0 0.0
.text 4743475 4743475 0 0.0
tv-casting-app debug (read only) 8301577 8301625 48 0.0
(read/write) 315712 315712 0 0.0
.bss 156000 156000 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 150384 150384 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 339848 339848 0 0.0
.text 7553395 7553443 48 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525376 2525376 0 0.0
.bss 219064 219064 0 0.0
.data 5136 5136 0 0.0
.text 1488060 1488060 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1054656 1054656 0 0.0
bss 128343 128343 0 0.0
rodata 104080 104080 0 0.0
text 774644 774644 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1181504 1181504 0 0.0
bss 120545 120545 0 0.0
rodata 138272 138272 0 0.0
text 772348 772348 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1039996 1039996 0 0.0
bss 128636 128636 0 0.0
rodata 99348 99348 0 0.0
text 764432 764432 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837624 837624 0 0.0
(read/write) 1732884 1732884 0 0.0
.bss 193236 193236 0 0.0
.data 2480 2480 0 0.0
.text 1528780 1528780 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839344 839344 0 0.0
(read/write) 1696756 1696756 0 0.0
.bss 191516 191516 0 0.0
.data 2480 2480 0 0.0
.text 1494372 1494372 0 0.0
light cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1622940 1622940 0 0.0
.bss 185076 185076 0 0.0
.data 2368 2368 0 0.0
.text 1427108 1427108 0 0.0
lock cy8ckit_062s2_43012 (read only) 818632 818632 0 0.0
(read/write) 1655788 1655788 0 0.0
.bss 212324 212324 0 0.0
.data 2384 2384 0 0.0
.text 1432692 1432692 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178784 1178784 0 0.0
.bss 100664 100664 0 0.0
.data 748 748 0 0.0
.text 625624 625624 0 0.0
lock-app qpg6105+debug (read/write) 1139548 1139548 0 0.0
.bss 95408 95408 0 0.0
.data 780 780 0 0.0
.text 586388 586388 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 811738 811738 0 0.0
bss 53132 53132 0 0.0
text 606380 606380 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1071804 1071804 0 0.0
bss 99388 99388 0 0.0
text 755342 755342 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1076736 1076736 0 0.0
bss 109084 109084 0 0.0
text 747044 747044 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 930636 930636 0 0.0
bss 93684 93684 0 0.0
text 643580 643580 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 814982 814982 0 0.0
bss 53240 53240 0 0.0
text 609430 609430 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 969220 969220 0 0.0
bss 77040 77040 0 0.0
text 687356 687356 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1086552 1086552 0 0.0
bss 99192 99192 0 0.0
text 764144 764144 0 0.0
lock-app-dfu tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 872366 872366 0 0.0
bss 53940 53940 0 0.0
text 639276 639276 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943932 943932 0 0.0
bss 91792 91792 0 0.0
text 659322 659322 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 871628 871628 0 0.0
bss 67076 67076 0 0.0
text 615954 615954 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 812192 812192 0 0.0
bss 55320 55320 0 0.0
text 582932 582932 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 827892 827892 0 0.0
bss 55724 55724 0 0.0
text 593546 593546 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705712 705712 0 0.0
bss 73232 73232 0 0.0
text 462250 462250 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 816710 816710 0 0.0
bss 53332 53332 0 0.0
text 612160 612160 0 0.0
temperature-measurement-app tlsr9528a_retention (read only) 51910 51910 0 0.0
(read/write) 802650 802650 0 0.0
bss 53052 53052 0 0.0
text 600176 600176 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 833284 833284 0 0.0
bss 55608 55608 0 0.0
text 598288 598288 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 830752 830752 0 0.0
bss 55960 55960 0 0.0
text 595338 595338 0 0.0

@mergify mergify bot merged commit 68abf76 into project-chip:master Nov 14, 2023
57 checks passed
@bzbarsky-apple bzbarsky-apple deleted the fix-chip-tool-operational-advertising branch November 14, 2023 16:29
@mkardous-silabs mkardous-silabs mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@arkq arkq arkq approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @arkq @mkardous-silabs