-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Scenes-Server on Fabric Removal #30419
Merged
lpbeliveau-silabs
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_on_fabric_removal
Nov 15, 2023
Merged
[Scenes] Scenes-Server on Fabric Removal #30419
lpbeliveau-silabs
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_on_fabric_removal
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpbeliveau-silabs
force-pushed
the
feature/scenes_on_fabric_removal
branch
from
November 10, 2023 18:33
9f20142
to
44dead0
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
LuDuda and
mhazley
November 10, 2023 18:35
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 10, 2023 18:35
PR #30419: Size comparison from 8d8d8a2 to 44dead0 Increases (4 builds for cc13x4_26x4, nrfconnect)
Full report (11 builds for cc13x4_26x4, mbed, nrfconnect, qpg)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes_on_fabric_removal
branch
from
November 10, 2023 19:01
44dead0
to
2008b74
Compare
PR #30419: Size comparison from 8d8d8a2 to 2008b74 Increases (19 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 13, 2023
lpbeliveau-silabs
force-pushed
the
feature/scenes_on_fabric_removal
branch
from
November 14, 2023 22:05
fd6da56
to
d999542
Compare
PR #30419: Size comparison from 4f75863 to d999542 Increases (19 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 15, 2023
woody-apple
force-pushed
the
feature/scenes_on_fabric_removal
branch
from
November 15, 2023 08:33
d999542
to
e3d5155
Compare
PR #30419: Size comparison from 512fa70 to e3d5155 Increases (19 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
merged commit Nov 15, 2023
26ec08f
into
project-chip:master
53 of 54 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabric Removal callback added to scenes-server to clear the scenes in storage for the removed fabric.