-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update session parameters to be inline with matter 1.3 spec #30405
Merged
tehampson
merged 14 commits into
project-chip:master
from
tehampson:session-parameters-for-matter-1-3
Nov 15, 2023
Merged
Update session parameters to be inline with matter 1.3 spec #30405
tehampson
merged 14 commits into
project-chip:master
from
tehampson:session-parameters-for-matter-1-3
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30405: Size comparison from dbd6d1d to 2bb9e60 Increases (3 builds for cc32xx, mbed)
Full report (3 builds for cc32xx, mbed)
|
PR #30405: Size comparison from dbd6d1d to 61efa3a Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
commented
Nov 10, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248 and
hicklin
November 10, 2023 21:04
tehampson
commented
Nov 10, 2023
PR #30405: Size comparison from dbd6d1d to a7c3c7c Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for cc32xx, linux, mbed, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 13, 2023
andy31415
reviewed
Nov 13, 2023
andy31415
reviewed
Nov 13, 2023
andy31415
reviewed
Nov 13, 2023
andy31415
reviewed
Nov 13, 2023
53 tasks
andy31415
reviewed
Nov 14, 2023
andy31415
reviewed
Nov 14, 2023
andy31415
approved these changes
Nov 14, 2023
bzbarsky-apple
approved these changes
Nov 15, 2023
PR #30405: Size comparison from 26ec08f to 3b44db2 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (25 builds for cc13x4_26x4, cc32xx, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Session Parameter to reflect latest 1.3 spec
In 1.3 more Session Parameters have been added and are now always expected to be sent over during session establishment.
This is required to get batch invoke feature for 1.3. In order for a client device to understand how many commands it may send to a server, the server must advertise how many paths per invoke it supports.
Test: