-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Endpoint Add and Remove support #30391
Merged
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes-server-endpoint-init-shutdown
Nov 15, 2023
Merged
[Scenes] Endpoint Add and Remove support #30391
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes-server-endpoint-init-shutdown
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
LuDuda,
mhazley and
mkardous-silabs
November 9, 2023 18:46
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 9, 2023 18:46
PR #30391: Size comparison from 491354a to 2c935dd Full report (3 builds for cc32xx, mbed)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes-server-endpoint-init-shutdown
branch
from
November 9, 2023 19:09
2c935dd
to
112ae52
Compare
PR #30391: Size comparison from 491354a to 112ae52 Full report (2 builds for cc32xx)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes-server-endpoint-init-shutdown
branch
from
November 9, 2023 19:22
112ae52
to
65f20ad
Compare
PR #30391: Size comparison from b0f5983 to 65f20ad Increases (5 builds for cc13x4_26x4, cyw30739, psoc6)
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes-server-endpoint-init-shutdown
branch
from
November 9, 2023 20:33
46fe96c
to
f0e1e46
Compare
PR #30391: Size comparison from b0f5983 to f0e1e46 Increases (16 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, psoc6, telink)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes-server-endpoint-init-shutdown
branch
from
November 9, 2023 22:15
f0e1e46
to
42e9965
Compare
PR #30391: Size comparison from b0f5983 to 42e9965 Increases (16 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, psoc6, telink)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes-server-endpoint-init-shutdown
branch
from
November 10, 2023 19:19
42e9965
to
ff49832
Compare
PR #30391: Size comparison from 8d8d8a2 to ff49832 Increases (19 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…and updated config-data to signal scenes uses those init callbacks
lpbeliveau-silabs
force-pushed
the
feature/scenes-server-endpoint-init-shutdown
branch
from
November 13, 2023 05:05
ff49832
to
ab73231
Compare
PR #30391: Size comparison from be5a949 to ab73231 Increases (16 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, psoc6, telink)
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes-server-endpoint-init-shutdown
branch
from
November 13, 2023 15:02
ab73231
to
dd2be5c
Compare
PR #30391: Size comparison from baa1d7a to dd2be5c Increases (19 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 13, 2023
bzbarsky-apple
approved these changes
Nov 15, 2023
lpbeliveau-silabs
deleted the
feature/scenes-server-endpoint-init-shutdown
branch
December 10, 2024 14:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the endpoint init code to the ember af init callback in scenes and updated config-data to signal scenes uses those init callbacks. Also added endpoint shutdown callback and creatte RemoveEndpoint method in the SceneTable, along with unit test.
Fixes : #26877