-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] make LastConfiguredBy optional #30308
Merged
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes-lastconfiguredby-optionnal
Nov 8, 2023
Merged
[Scenes] make LastConfiguredBy optional #30308
mergify
merged 2 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes-lastconfiguredby-optionnal
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
LuDuda,
mhazley,
mkardous-silabs and
mspang
November 8, 2023 13:40
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 8, 2023 13:40
lpbeliveau-silabs
force-pushed
the
bugfix/scenes-lastconfiguredby-optionnal
branch
from
November 8, 2023 13:43
7337243
to
9b1035d
Compare
mkardous-silabs
approved these changes
Nov 8, 2023
lpbeliveau-silabs
force-pushed
the
bugfix/scenes-lastconfiguredby-optionnal
branch
from
November 8, 2023 13:45
9b1035d
to
802d825
Compare
PR #30308: Size comparison from 368b9a0 to 802d825 Increases (4 builds for esp32, psoc6)
Decreases (14 builds for cc13x4_26x4, cyw30739, efr32, esp32, nrfconnect, psoc6, telink)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 8, 2023
Co-authored-by: mkardous-silabs <[email protected]>
PR #30308: Size comparison from 368b9a0 to b382a5b Increases above 0.2%:
Increases (16 builds for esp32, psoc6, telink)
Decreases (27 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
changed the title
[Scenes] make LastConfiguredBy optionnal
[Scenes] make LastConfiguredBy optional
Nov 8, 2023
lpbeliveau-silabs
deleted the
bugfix/scenes-lastconfiguredby-optionnal
branch
December 10, 2024 14:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsupported Attribute in UpdateLastConfiguredBy no longer causes commands to fail.
Fixes: #30255