-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs]Fix a memory leak in Efr32PsaOperationalKeystore #30292
Merged
mergify
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix/psa_opkey_memory_leak
Nov 8, 2023
Merged
[Silabs]Fix a memory leak in Efr32PsaOperationalKeystore #30292
mergify
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix/psa_opkey_memory_leak
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
November 7, 2023 20:46
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 7, 2023 20:47
PR #30292: Size comparison from 2d62ad1 to 2e100f0 Increases (4 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Nov 7, 2023
jmartinez-silabs
changed the title
[Silabs]Fix a memory leak Efr32PsaOperationalKeystore
[Silabs]Fix a memory leak in Efr32PsaOperationalKeystore
Nov 7, 2023
lpbeliveau-silabs
approved these changes
Nov 7, 2023
andy31415
reviewed
Nov 7, 2023
andy31415
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving platform specific changes with platform owner checkmarks.
Up to you if you want to follow up on readability suggestion.
PR #30292: Size comparison from 2d62ad1 to fd19007 Increases above 0.2%:
Increases (22 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6)
Decreases (9 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At
CommitOpKeypairForFabric
completion,mPendingKeypair
and related variables were "cleared" butmPendingKeypair
wasn't freed.Fix it by reuse
ResetPendingKey
that correctly clean upmPendingKeypair
but with an added argument to keep theopaqueKey
that can be maintained in thecachedKey
. The argument defaults to false to keep other calls toResetPendingKey
unchanged.