-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/energypreferences #30244
Feature/energypreferences #30244
Conversation
PR #30244: Size comparison from cc5b41a to cd5f3c6 Decreases (1 build for efr32)
Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, k32w, mbed, qpg, stm32)
|
PR #30244: Size comparison from cc5b41a to 985477c Increases above 0.2%:
Increases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (5 builds for cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
examples/all-clusters-app/all-clusters-common/src/energy-preference-delegate.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
PR #30244: Size comparison from cc5b41a to 4dc866e Increases above 0.2%:
Increases (12 builds for k32w, mbed, nrfconnect, qpg, stm32)
Decreases (7 builds for cc13x4_26x4, cc32xx)
Full report (19 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
PR #30244: Size comparison from cc5b41a to 2667aeb Increases above 0.2%:
Increases (30 builds for bl602, bl702, bl702l, cyw30739, k32w, mbed, nrfconnect, psoc6, qpg, stm32)
Decreases (11 builds for cc13x4_26x4, cc32xx, psoc6)
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #30244: Size comparison from cc5b41a to b84b03b Increases above 0.2%:
Increases (4 builds for mbed, nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
src/app/clusters/energy-preference-server/energy-preference-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/energy-preference-server/energy-preference-server.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
* Adding the Energy Preferences XML * Added just the xml and regenerated. No implementations yet as requested. * regen * put the cluster back into all-clusters after merge. * Apply suggestions from code review Added suggestions for ARRAY vs array Co-authored-by: Boris Zbarsky <[email protected]> * regenerate * Finished up impl for energy-preferences * Added some error checking for features, and constraint checking. Also turned on the features in the all-clusters-app * Restyled by whitespace * Restyled by clang-format * Fixed copy paste bug * Removed some unecessary changes and a comment. * initialize the delegate pointer * Put the cluster back in the all-clusters app after the merge * Fixed minor issues from review * Restyled by whitespace * Addressing some review concerns * Some more comments resolved * Better documentation, a set of braces I missed last time around, and added an extra header include. * fix build error after merge * Restyled by whitespace * Restyled by clang-format * Update src/app/clusters/energy-preference-server/energy-preference-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Implement proposed API changes with clearer delineation of storage * Restyled by clang-format * Typo * Regen zap, update code to reflect the updated return from Feature::Get * ZAP regen, to fix merge errors * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address suggestion re: optionality conversion * Fix one more omission * another small fix * Fix up copyright headers * Restyled by clang-format * Reinitialize storage objects on every iteration * fix typo * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Robert Szewczyk <[email protected]>
* Adding the Energy Preferences XML * Added just the xml and regenerated. No implementations yet as requested. * regen * put the cluster back into all-clusters after merge. * Apply suggestions from code review Added suggestions for ARRAY vs array Co-authored-by: Boris Zbarsky <[email protected]> * regenerate * Finished up impl for energy-preferences * Added some error checking for features, and constraint checking. Also turned on the features in the all-clusters-app * Restyled by whitespace * Restyled by clang-format * Fixed copy paste bug * Removed some unecessary changes and a comment. * initialize the delegate pointer * Put the cluster back in the all-clusters app after the merge * Fixed minor issues from review * Restyled by whitespace * Addressing some review concerns * Some more comments resolved * Better documentation, a set of braces I missed last time around, and added an extra header include. * fix build error after merge * Restyled by whitespace * Restyled by clang-format * Update src/app/clusters/energy-preference-server/energy-preference-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Implement proposed API changes with clearer delineation of storage * Restyled by clang-format * Typo * Regen zap, update code to reflect the updated return from Feature::Get * ZAP regen, to fix merge errors * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address suggestion re: optionality conversion * Fix one more omission * another small fix * Fix up copyright headers * Restyled by clang-format * Reinitialize storage objects on every iteration * fix typo * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Robert Szewczyk <[email protected]>
Energy Preferences cluster implementation and example app.