-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Use of "contains" in Yaml S 2.2 #30241
Merged
mergify
merged 1 commit into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes_yaml_2_2_efs_contains_check
Nov 8, 2023
Merged
[Scenes] Use of "contains" in Yaml S 2.2 #30241
mergify
merged 1 commit into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes_yaml_2_2_efs_contains_check
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30241: Size comparison from 0baa1c6 to fc5613e Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_yaml_2_2_efs_contains_check
branch
from
November 6, 2023 16:05
fc5613e
to
6027c9e
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
LuDuda
November 6, 2023 16:06
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 6, 2023 16:06
PR #30241: Size comparison from 0f5f708 to 6027c9e Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes_yaml_2_2_efs_contains_check
branch
from
November 7, 2023 20:23
6027c9e
to
9c729a2
Compare
PR #30241: Size comparison from 2d62ad1 to 9c729a2 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Nov 7, 2023
jmartinez-silabs
approved these changes
Nov 7, 2023
bzbarsky-apple
approved these changes
Nov 8, 2023
lpbeliveau-silabs
deleted the
bugfix/scenes_yaml_2_2_efs_contains_check
branch
December 10, 2024 14:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #30218 is merged, we can use the "contains" method when checking EFS in ViewScene command's Response.
Removed the explicit value check.