Implement Non concurrent mode #30201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were extra curly braces that failed on some (but not all?) CI runs.
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #30201: Size comparison from a61a58f to a8ce91b Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, bl702l, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 18, 2023
tima-q
reviewed
Nov 20, 2023
cecille
approved these changes
Nov 20, 2023
|
PR #30201: Size comparison from a3c5d19 to f285b38 Increases above 0.2%:
Increases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #30201: Size comparison from 4e2d489 to 050d0b3 Increases above 0.2%:
Increases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl702l, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
DamMicSzm
pushed a commit
to DamMicSzm/connectedhomeip
that referenced
this pull request
Nov 30, 2023
* Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Correct intermittent missing SSID(project-chip#29865) * ConnectNetworkResponse Supression (project-chip#29865) * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Fix merge issue with ICD attributes(project-chip#29865) * Fix darwin-tests workflow file syntax. (project-chip#30162) There were extra curly braces that failed on some (but not all?) CI runs. * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Fix merge issue with ICD attributes(project-chip#29865) * Only start WiFi on BLE Commissioning pass(project-chip#29865) * Remove use of Breadcrumb::Get from BLE (project-chip#29865) * Add non-concurrent SupportsConcurrentConnection * Address CI build issues (project-chip#29865) * Fix style issue (project-chip#29865) * Fix read of SupportsConcurrentConnection (project-chip#29865) * Fix merge issue with ICD attributes(project-chip#29865) * Only start WiFi on BLE Commissioning pass(project-chip#29865) * Remove use of Breadcrumb::Get from BLE (project-chip#29865) * Tidy comments (project-chip#29865) * Default on error, check timeout, tidy up (project-chip#29865) * Make log messages user friendly (project-chip#29865) * Change to compile time non-concurrent mode(project-chip#29865) * Restyled by whitespace * Restyled by clang-format * Improve code style (project-chip#29865) * Restyled by clang-format * Add CommandHandler issue reference 30576 (project-chip#29865) --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Non-Concurrent mode as described in #29865. That is, BLE is stopped before the Operation channel (in this case Wi-Fi) is started. This is using Linux so the Wi-Fi is controlled via wpa-supplicant. Changes update chip-tool and the example Linux (RaspberryPi) Lighting App.
chip-tool :
The code now requests the mandatory attribute
SupportsConcurrentConnectionin a second attribute request and whenSupportsConcurrentConnection=Falsedoes not wait forConnectNetworkResponseover BLE as it will not be transmitted. Once the Wi-Fi associates to the network, commissioning continues as normal.lighting-app:
To place the system into non-concurrent mode the two changes below are needed. This modifies the code to close the BLE before starting wpa_supplicant to continue the commissioning process. The
ConnectNetworkResponseis not sent.This has been tested in
SupportsConcurrentConnection=FalseandSupportsConcurrentConnection=Truemodes and both modes commission the lighting-app onto the network. Test logs for both scenarios attached.SupportsConcurrentOperation_False_chip-lighting.txt
SupportsConcurrentOperation_False_chip-tool.txt
SupportsConcurrentOperation_True_chip-lighting.txt
SupportsConcurrentOperation_True_chip-tool.txt
Using this means that Core Specification Test [TC-DD-3.2] Commissioning Flow - Non-concurrent [DUT -
Commissionee] can be reinstated.