Small ChipCert refactoring in preparation for more work on PDC #30163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
... and tidy up the API of some other helpers a little to make them easier to re-use.
ksperling-apple
force-pushed
the
pdc-chipcert-prep
branch
from
50fa077 to
f61524f
Compare
|
PR #30163: Size comparison from edfc199 to f61524f Increases above 0.2%:
Increases (33 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6)
Decreases (40 builds for bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 2, 2023
woody-apple
approved these changes
Nov 2, 2023
arkq
approved these changes
Nov 2, 2023
|
PR #30163: Size comparison from edfc199 to d68b777 Increases above 0.2%:
Increases (33 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6)
Decreases (40 builds for bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #30163: Size comparison from edfc199 to efdf342 Increases (29 builds for bl702, bl702l, cc32xx, efr32, k32w, linux, psoc6)
Decreases (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
| @@ -569,7 +569,7 @@ struct X509CertRequestParams | |||
| * | |||
| * @return Returns a CHIP_ERROR on error, CHIP_NO_ERROR otherwise | |||
| **/ | |||
| CHIP_ERROR NewRootX509Cert(const X509CertRequestParams & requestParams, Crypto::P256Keypair & issuerKeypair, | |||
| CHIP_ERROR NewRootX509Cert(const X509CertRequestParams & requestParams, const Crypto::P256Keypair & issuerKeypair, | |||
There was a problem hiding this comment.
This will break users that derived P256Keypair in a way that it internally mutates state with any of the methods, which was allowed before. It would have been best to leave this alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.