-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread diagnostics to spec #30153
Merged
mergify
merged 18 commits into
project-chip:master
from
andy31415:thread_diagnostics_to_spec
Nov 2, 2023
Merged
Thread diagnostics to spec #30153
mergify
merged 18 commits into
project-chip:master
from
andy31415:thread_diagnostics_to_spec
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
November 1, 2023 16:38
andy31415
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Nov 1, 2023
PR #30153: Size comparison from c2fae17 to d85d46b Increases (48 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl702, bl702l, cc32xx, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
added
the
Spec XML align
SDK XML does not match the spec (including naming, etc)
label
Nov 1, 2023
src/app/zap-templates/zcl/data-model/chip/thread-network-diagnostics-cluster.xml
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
previously requested changes
Nov 2, 2023
src/app/zap-templates/zcl/data-model/chip/thread-network-diagnostics-cluster.xml
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
documentation
Improvements or additions to documentation
platform
linux
labels
Nov 2, 2023
PR #30153: Size comparison from bba25c5 to 52800ac Increases (27 builds for bl702, bl702l, cc13x4_26x4, cc32xx, esp32, k32w, linux, mbed, nrfconnect, qpg)
Decreases (3 builds for linux)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, k32w, linux, mbed, nrfconnect, qpg)
|
andy31415
dismissed
bzbarsky-apple’s stale review
November 2, 2023 14:31
Reverted the List suffix change and created a spec PR instead.
PR #30153: Size comparison from bba25c5 to 0cf2e86 Increases (5 builds for cc32xx, mbed, qpg)
Full report (5 builds for cc32xx, mbed, qpg)
|
bzbarsky-apple
approved these changes
Nov 2, 2023
PR #30153: Size comparison from 38fa902 to 7a272a6 Increases (48 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
review - approved
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Spec XML align
SDK XML does not match the spec (including naming, etc)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
NOT changed (will have to update spec because of ABI)