-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTA Requester Option - skip Image Execution #30146
Merged
mergify
merged 3 commits into
project-chip:master
from
joonhaengHeo:add_ota_provider_option_for_skip_exec_image
Nov 1, 2023
Merged
Add OTA Requester Option - skip Image Execution #30146
mergify
merged 3 commits into
project-chip:master
from
joonhaengHeo:add_ota_provider_option_for_skip_exec_image
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
November 1, 2023 10:19
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mlepage-google,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 1, 2023 10:19
PR #30146: Size comparison from e5e93bf to c9bfea6 Increases above 0.2%:
Increases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 1, 2023
yufengwangca
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the OTA Provider, I need to check whether each command is received.
However, in the current OTA requester app, if the OTA Image is not validated, only BDX protocol transmission can be tested and no commands are sent thereafter. (ApplyUpdateRequest, NotifyUpdateApplied)
I added an option to skip OTA image execution for testing, so I can check that each command is sent even when using an image that is not valid.