-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASR] add more basic info to factory data #30123
Conversation
tx2rx
commented
Oct 31, 2023
- add more basic info to factory data
- Move asr_factory_config to ASRFactoryDataParser
85ae33f
to
1023575
Compare
39b48ea
to
3252fed
Compare
PR #30123: Size comparison from 1890490 to 3252fed Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as platform code ... however I start thinking that the FactoryDataParser could use some readability improvements (but did not have time to actually review it)
1800be3
to
63764b0
Compare
PR #30123: Size comparison from bfc8c32 to 63764b0 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30123: Size comparison from bfc8c32 to 2cef4e2 Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (35 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, telink)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
2cef4e2
to
63764b0
Compare
PR #30123: Size comparison from 24d38da to 63764b0 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30123: Size comparison from 9eb23a5 to 052361b Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
052361b
to
4016e07
Compare
PR #30123: Size comparison from 7c71cb5 to 4016e07 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@andy31415 hi Andrei. can this PR be merged? |