Cluster: Add Temperature Measurement commands to chip-tool and src/app #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
andy31415
approved these changes
Oct 2, 2020
BroderickCarlin
approved these changes
Oct 2, 2020
rwalker-apple
approved these changes
Oct 2, 2020
| case 0x29: { // "Int16" | ||
| int16_t value; | ||
| CHECK_MESSAGE_LENGTH(messageLen == 2); | ||
| value = chip::Encoding::LittleEndian::Read16(message); |
There was a problem hiding this comment.
This isn't really right. Read16 will read a uint16_t, and this assignment is undefined behavior if the value is outside the int16_t range. Now hopefully that will never happen in practice, but we need a better setup for this long-term, and definitely before we enable -Wconversion tree-wide.
| int16_t value; | ||
| CHECK_MESSAGE_LENGTH(messageLen == 2); | ||
| value = chip::Encoding::LittleEndian::Read16(message); | ||
| ChipLogProgress(chipTool, "Attribute value: '0x%04x'", value); |
There was a problem hiding this comment.
That format string doesn't really make that much sense for a signed int16_t, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to have an minimal example application that would serve as a baseline for memory consumption, it would be nice to use a simple cluster that has only attributes.
The current PR add a command in chip-tool and the corresponding method on src/app to read the current temperature from the Temperature Measurement server.
Summary of Changes
Fixes #2982, #2981